This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Use MAX associated const #9196
Merged
Use MAX associated const #9196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilescope
requested review from
andresilva,
athei,
kianenigma,
NikVolf and
shawntabrizi
as code owners
athei
added
A0-please_review
coriolinus
approved these changes
Jun 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #9189 now that I've untangled my git.
As mentioned in the earlier PR
u32::max_value()and friends are deprecated in favour of the associated constsu32::MAX. It's less code to read and a little less work for the compiler.