Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove RandomNumberGenerator #9198

Merged
2 commits merged into from
Jun 24, 2021
Merged

Remove RandomNumberGenerator #9198

2 commits merged into from
Jun 24, 2021

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Jun 24, 2021

This is not used in Substrate/Polkadot. If someone else needs it, they
can copy the code or use chacha.

Closes: #7444

@bkchr
Remove RandomNumberGenerator
5020862 
This is not used in Substrate/Polkadot. If someone else needs it, they
can copy the code or use chacha.
@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jun 24, 2021
@bkchr bkchr mentioned this pull request Jun 24, 2021
Closed
@coriolinus
Copy link
Contributor

Can't comment inline because it's not part of the diff, but you need to remove pub mod random_number_generator on line 57 for this to work.

@bkchr
Copy link
Member Author

bkchr commented Jun 24, 2021

bot merge

@ghost
Copy link

ghost commented Jun 24, 2021

Waiting for commit status.

@ghost ghost merged commit 77dcc4f into master Jun 24, 2021
@ghost ghost deleted the bkchr-remove-random-number-generator branch June 24, 2021 14:19
This was referenced Jun 24, 2021
Closed
Closed
athei pushed a commit that referenced this pull request Jun 25, 2021
@bkchr @athei
Remove RandomNumberGenerator (#9198)
dc056f8 
* Remove RandomNumberGenerator

This is not used in Substrate/Polkadot. If someone else needs it, they
can copy the code or use chacha.

* 🤦
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coriolinus coriolinus coriolinus approved these changes

@andresilva andresilva andresilva approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RandomNumberGenerator panicking on pick_u32(u32::max_value)
3 participants
@bkchr @coriolinus @andresilva