Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Discussion - Remove DEX Runtime API from RPC. #208

Open
hbulgarini opened this issue Jun 5, 2023 · 2 comments
Open

Discussion - Remove DEX Runtime API from RPC. #208

hbulgarini opened this issue Jun 5, 2023 · 2 comments
Assignees
Labels
discussion Discussions about design/implementations/etc.

Comments

@hbulgarini
Copy link
Contributor

hbulgarini commented Jun 5, 2023

It seems there is an agreement that custom RPC calls should be avoided and query any runtime API by using state_call.
At the moment Trappist node is implementing a custom RPC call for the Dex pallet here.

The point to discuss and agree here is if the Dex custom RPC are really needed or if they can be replaced by using state_call.

Reference discussions:

paritytech/capi#228 (comment)
paritytech/substrate#12358

kudos to @evilrobot-01 for the head ups

@hbulgarini hbulgarini added the discussion Discussions about design/implementations/etc. label Jun 5, 2023
@hbulgarini hbulgarini added this to the Trappist M1 / XCM v2 milestone Jun 5, 2023
@evilrobot-01
Copy link
Contributor

I think the fact that the runtime API being upgradeable without needing a node redeployment is a nice property, despite the additional step of tunneling the runtime API call via state_call.

@valentinfernandez1
Copy link
Contributor

I can take this, it really takes a few minutes

@valentinfernandez1 valentinfernandez1 self-assigned this Jul 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
discussion Discussions about design/implementations/etc.
Projects
None yet
Development

No branches or pull requests

4 participants