Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow socks5 support on proxy settings #184

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

shimonoe
Copy link

This change allows socks5 on proxy settings by creating an socks5 Dialer on transport layer. Also, this is case insensitive, so user can set proxy by declaring in any case.

    - Added support for socks5 on http.Transport as a proxy
=========

    - Fixed bug in socks5 detection. Parsed as a lower case and compared to "socks5" to match in case of case variation in input.
@101usb
Copy link

101usb commented Oct 10, 2018

@shimonoe , the proxy is not being used If I set a timeout

timeout := 10000 * time.Millisecond
request := gorequest.New().Proxy("socks5://8.8.8.8:9999").Timeout(timeout)
resp,_,err := request.Get("www.google.com").End()
fmt.Println(resp, err)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants