-
-
Notifications
You must be signed in to change notification settings - Fork 213
feat: Add client access via ParseDioClient.client and ParseHTTPClient.client
#1025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add client access via ParseDioClient.client and ParseHTTPClient.client
#1025
Conversation
|
I will reformat the title to use the proper commit message syntax. |
Thanks for opening this pull request! |
|
I will reformat the title to use the proper commit message syntax. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1025 +/- ##
==========================================
+ Coverage 43.37% 47.26% +3.88%
==========================================
Files 61 53 -8
Lines 3463 3140 -323
==========================================
- Hits 1502 1484 -18
+ Misses 1961 1656 -305 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems pretty straight forward.
|
Could you rephrase the PR title to better understand the new feature? Maybe also add the class or method name. |
ParseDioClient.dioClient and ParseHTTPClient.httpClient
ParseDioClient.dioClient and ParseHTTPClient.httpClientParseDioClient.dioClient and ParseHTTPClient.httpClient
mtrezza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; if the new PR title makes sense, then I'll go ahead and merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 1 thing:
Would it make sense to name the properties just client as in ParseDioClient.client, ParseHTTPClient.client? The class names already say what type of client it is.
Good suggestion. |
Changed. |
ParseDioClient.dioClient and ParseHTTPClient.httpClientParseDioClient.client and ParseHTTPClient.client
mtrezza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
# [10.0.0](flutter-9.0.0...flutter-10.0.0) (2025-11-28) ### Bug Fixes * `ParseXFile` uploads file with content-type `application/octet-stream` if not explicitly set ([#1048](#1048)) ([a47f2a0](a47f2a0)) * Add support for Dart 3.4, 3.5; remove support for Dart 3.0, 3.1 ([#1016](#1016)) ([a3449f4](a3449f4)) * HTTP client exception not handled properly resulting in incorrectly formatted error ([#1021](#1021)) ([4f20640](4f20640)) ### Features * Add client access via `ParseDioClient.client` and `ParseHTTPClient.client` ([#1025](#1025)) ([af14388](af14388)) * Remove support for expired Dart and Flutter versions ([#1052](#1052)) ([dbeb5cb](dbeb5cb)) ### BREAKING CHANGES * This release removes support for Dart 3.2 - 3.9 and Flutter 3.16 - 3.37. These versions exceeded their 6-month support window after the next significant version release. The minimum required versions are now Dart 3.10 and Flutter 3.38. ([dbeb5cb](dbeb5cb))
Pull Request
Issue
Closes: #1023
Approach
Add a function to access client in parse clients.
Tasks