From 87c090f280258d79d457fa714a4c8a27b27c4db4 Mon Sep 17 00:00:00 2001 From: Damian Stasik <920747+damianstasik@users.noreply.github.com> Date: Sun, 25 Sep 2022 18:12:46 +0200 Subject: [PATCH] ci: remove Node 12 support completely --- .github/workflows/ci.yml | 2 -- README.md | 3 +-- ci/ciCheck.js | 3 +-- package.json | 2 +- src/lib/tests/e2e/dashboard.e2e.test.js | 1 - 5 files changed, 3 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index fdad25a3cd..09692e6150 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -111,8 +111,6 @@ jobs: strategy: matrix: include: - - name: Node 12 - NODE_VERSION: 12.22.12 - name: Node 14 NODE_VERSION: 14.20.0 - name: Node 16 diff --git a/README.md b/README.md index a4e96e3de5..87ffcd5e44 100644 --- a/README.md +++ b/README.md @@ -5,7 +5,7 @@ [![Build Status](https://github.com/parse-community/parse-dashboard/workflows/ci/badge.svg?branch=alpha)](https://github.com/parse-community/parse-dashboard/actions?query=workflow%3Aci+branch%3Aalpha) [![Snyk Badge](https://snyk.io/test/github/parse-community/parse-dashboard/badge.svg)](https://snyk.io/test/github/parse-community/parse-dashboard) -[![Node Version](https://img.shields.io/badge/nodejs-12,_14,_16,_18-green.svg?logo=node.js&style=flat)](https://nodejs.org/) +[![Node Version](https://img.shields.io/badge/nodejs-14,_16,_18-green.svg?logo=node.js&style=flat)](https://nodejs.org/) [![auto-release](https://img.shields.io/badge/%F0%9F%9A%80-auto--release-9e34eb.svg)](https://github.com/parse-community/parse-dashboard/releases) [![npm latest version](https://img.shields.io/npm/v/parse-dashboard/latest.svg)](https://www.npmjs.com/package/parse-dashboard) @@ -102,7 +102,6 @@ Parse Dashboard is continuously tested with the most recent releases of Node.js | Version | Latest Version | End-of-Life | Compatible | |------------|----------------|-------------|--------------| -| Node.js 12 | 12.22.12 | April 2022 | ✅ Yes | | Node.js 14 | 14.20.0 | April 2023 | ✅ Yes | | Node.js 16 | 16.17.0 | April 2024 | ✅ Yes | | Node.js 18 | 18.9.0 | May 2025 | ✅ Yes | diff --git a/ci/ciCheck.js b/ci/ciCheck.js index 2c24db28c8..492ab04ee6 100644 --- a/ci/ciCheck.js +++ b/ci/ciCheck.js @@ -25,8 +25,7 @@ async function checkNodeVersions() { releasedVersions, latestComponent: CiVersionCheck.versionComponents.minor, ignoreReleasedVersions: [ - '<12.0.0', // These versions have reached their end-of-life support date - '>=13.0.0 <14.0.0', // These versions have reached their end-of-life support date + '<14.0.0', // These versions have reached their end-of-life support date '>=15.0.0 <16.0.0', // These versions have reached their end-of-life support date '>=17.0.0 <18.0.0', // These versions have reached their end-of-life support date ], diff --git a/package.json b/package.json index b93e51e45a..87b8076e76 100644 --- a/package.json +++ b/package.json @@ -137,7 +137,7 @@ "parse-dashboard": "./bin/parse-dashboard" }, "engines": { - "node": ">=12.22.0" + "node": ">=14.0.0" }, "main": "Parse-Dashboard/app.js", "jest": { diff --git a/src/lib/tests/e2e/dashboard.e2e.test.js b/src/lib/tests/e2e/dashboard.e2e.test.js index e6eac80c7d..67c6054071 100644 --- a/src/lib/tests/e2e/dashboard.e2e.test.js +++ b/src/lib/tests/e2e/dashboard.e2e.test.js @@ -77,7 +77,6 @@ function startParseDashboardAndGetOutput(args) { return new Promise((resolve) => { const indexFilePath = path.resolve('./Parse-Dashboard/index.js'); const child = spawn('node', [indexFilePath, ...args], { cwd: '.', timeout: timeoutInMs }); - setTimeout(() => { child.kill(); }, timeoutInMs); // node.js 12 hack (spawn timeout option is not supported.) let output = ''; child.on('error', () => { resolve(output); });