-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove detailed error from error messages #8958
Comments
Thanks for opening this issue!
|
@mtrezza is the issue still open ? |
Yes |
can you assign this issue to me ? @mtrezza |
Please feel free to pick this up and post a comment for others to be aware that it's in the works. |
I'm picking up this issue and will be working on it. |
@mtrezza basically i have to do this in /src/Adapters/Auth or there any other folder also ? |
This relates to any response message across Parse Server where more information than necessary is returned. I suggest to do this with just 1 or a few messages, then open a PR for feedback, so you don't make a lot of changes and then have to modify them again. |
New Feature / Enhancement Checklist
Current Limitation
For some requests, Parse Server returns more information than necessary in the error response. For example:
This is providing an outside attacker with more info than necessary.
Feature / Enhancement Description
Especially when it comes to access / permission errors, I suggest to make the error messages more ambiguous by generalizing them and removing any specific information. Instead of explaining why a request was unauthorized, the error should be only
unauthorized
without any further details. The detailed error message should only be logged server side.The task would be:
This should not be a breaking change, as long as the error code does not change. Changes of error messages are not considered breaking as logic that relies on parsing error messages is considered bad practice anyway.
The text was updated successfully, but these errors were encountered: