-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Sends pushes only when a deviceToken is set #3764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is intended to solve a bug where some push notifications stuck in sending state
Includes info for running parse-server on master
Codecov Report
@@ Coverage Diff @@
## master #3764 +/- ##
==========================================
- Coverage 90.26% 90.23% -0.04%
==========================================
Files 114 114
Lines 7491 7494 +3
==========================================
Hits 6762 6762
- Misses 729 732 +3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3764 +/- ##
==========================================
- Coverage 90.26% 90.23% -0.04%
==========================================
Files 114 114
Lines 7491 7494 +3
==========================================
Hits 6762 6762
- Misses 729 732 +3
Continue to review full report at Codecov.
|
Thanks, seems like it will fix the issue. Looks like one of the tests is failing though. |
@TylerBrock Do you have any ideas why these tests are failing?
|
I'll work on this fix this Pm. |
@flovilmart Please, let me know if you need any help. |
supersed by #3808 |
Did this fix the parse |
Also what version was this released in? |
This is intended to solve a bug where some push notifications stuck in sending state