Skip to content

Sends pushes only when a deviceToken is set #3764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

felipeandradebezerra
Copy link
Contributor

This is intended to solve a bug where some push notifications stuck in sending state

This is intended to solve a bug where some push notifications stuck in
sending state
Felipe Andrade added 2 commits April 29, 2017 06:18
Includes info for running parse-server on master
@codecov
Copy link

codecov bot commented Apr 30, 2017

Codecov Report

Merging #3764 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3764      +/-   ##
==========================================
- Coverage   90.26%   90.23%   -0.04%     
==========================================
  Files         114      114              
  Lines        7491     7494       +3     
==========================================
  Hits         6762     6762              
- Misses        729      732       +3
Impacted Files Coverage Δ
src/Controllers/PushController.js 95.58% <100%> (+0.2%) ⬆️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 95.17% <0%> (-0.28%) ⬇️
src/Controllers/SchemaController.js 97.05% <0%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6b9548...d5315db. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 30, 2017

Codecov Report

Merging #3764 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3764      +/-   ##
==========================================
- Coverage   90.26%   90.23%   -0.04%     
==========================================
  Files         114      114              
  Lines        7491     7494       +3     
==========================================
  Hits         6762     6762              
- Misses        729      732       +3
Impacted Files Coverage Δ
src/Controllers/PushController.js 95.58% <100%> (+0.2%) ⬆️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 95.17% <0%> (-0.28%) ⬇️
src/Controllers/SchemaController.js 97.05% <0%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6b9548...d5315db. Read the comment docs.

@TylerBrock
Copy link
Contributor

TylerBrock commented Apr 30, 2017

Thanks, seems like it will fix the issue. Looks like one of the tests is failing though.

@felipeandradebezerra
Copy link
Contributor Author

felipeandradebezerra commented May 2, 2017

@TylerBrock Do you have any ideas why these tests are failing?

  1. Parse.Push should allow master key to query _PushStatus
  • Expected '{"deviceType":"ios","deviceToken":{"$exists":true}}' to equal '{"deviceType":"ios"}'.
  1. PushController properly creates _PushStatus
  • Expected '{"deviceToken":{"$exists":true}}' to equal '{}'.

@flovilmart
Copy link
Contributor

I'll work on this fix this Pm.

@flovilmart flovilmart closed this May 11, 2017
@felipeandradebezerra
Copy link
Contributor Author

@flovilmart Please, let me know if you need any help.

@flovilmart
Copy link
Contributor

supersed by #3808

@myusuf3
Copy link

myusuf3 commented May 25, 2017

Did this fix the parse SENDING issue?

@myusuf3
Copy link

myusuf3 commented May 25, 2017

Also what version was this released in?

@felipeandradebezerra
Copy link
Contributor Author

@myusuf3 03b6449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants