-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning in changelog regarding upgrade to 4.0 and index creation #6469
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6469 +/- ##
=======================================
Coverage 93.96% 93.96%
=======================================
Files 169 169
Lines 11801 11801
=======================================
Hits 11089 11089
Misses 712 712 Continue to review full report at Codecov.
|
Could we not just update the changelog and release notes instead of creating a new release? |
|
It’s possible, seems like an easier solution to me? |
at this point, it's easier for me to just release this if you think the wording is good and correct. having said that, i'm glad to close this and you can do as you see fit and I'd be just as happy with that! :). and thanks for the prompt review and responses. much appreciated as always. |
Fair enough, I feel that it could be confusing to create a new release even though the change is in a previous one. I’m happy to apply my suggestions in this PR and then update the release notes accordingly. |
I know you can't add a review, but does this look ok to you? |
@TomWFox that looks great. Let 'er rip. I really appreciate it. |
No worries, you did the real work, nicely written! |
…arse-community#6469) * bump version * add the special note * remove new version & add note about indexes to 4.0.2 & 4.0.0 * Update package-lock.json * Update package.json * add line break * remove double space Co-authored-by: Tom Fox <13188249+TomWFox@users.noreply.github.com>
fixes: #6464