Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning in changelog regarding upgrade to 4.0 and index creation #6469

Merged
merged 7 commits into from
Mar 5, 2020

Conversation

acinader
Copy link
Contributor

@acinader acinader commented Mar 5, 2020

fixes: #6464

@acinader acinader requested a review from TomWFox March 5, 2020 18:07
@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #6469 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6469   +/-   ##
=======================================
  Coverage   93.96%   93.96%           
=======================================
  Files         169      169           
  Lines       11801    11801           
=======================================
  Hits        11089    11089           
  Misses        712      712

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 209d6f7...aacea21. Read the comment docs.

@TomWFox
Copy link
Contributor

TomWFox commented Mar 5, 2020

Could we not just update the changelog and release notes instead of creating a new release?

@acinader
Copy link
Contributor Author

acinader commented Mar 5, 2020

¯\_(ツ)_/¯

@TomWFox
Copy link
Contributor

TomWFox commented Mar 5, 2020

It’s possible, seems like an easier solution to me?

@acinader
Copy link
Contributor Author

acinader commented Mar 5, 2020

at this point, it's easier for me to just release this if you think the wording is good and correct.

having said that, i'm glad to close this and you can do as you see fit and I'd be just as happy with that!

:). and thanks for the prompt review and responses. much appreciated as always.

@TomWFox
Copy link
Contributor

TomWFox commented Mar 5, 2020

Fair enough, I feel that it could be confusing to create a new release even though the change is in a previous one.

I’m happy to apply my suggestions in this PR and then update the release notes accordingly.

@TomWFox TomWFox removed their request for review March 5, 2020 21:39
@TomWFox
Copy link
Contributor

TomWFox commented Mar 5, 2020

I know you can't add a review, but does this look ok to you?

@acinader
Copy link
Contributor Author

acinader commented Mar 5, 2020

@TomWFox that looks great. Let 'er rip. I really appreciate it.

@TomWFox
Copy link
Contributor

TomWFox commented Mar 5, 2020

No worries, you did the real work, nicely written!

@TomWFox TomWFox merged commit b1f1454 into master Mar 5, 2020
@TomWFox TomWFox deleted the 4.1.1-release branch March 5, 2020 21:43
@TomWFox TomWFox added the type:docs Only change in the docs or README label Mar 5, 2020
UnderratedDev pushed a commit to UnderratedDev/parse-server that referenced this pull request Mar 21, 2020
…arse-community#6469)

* bump version

* add the special note

* remove new version & add note about indexes to 4.0.2 & 4.0.0

* Update package-lock.json

* Update package.json

* add line break

* remove double space

Co-authored-by: Tom Fox <13188249+TomWFox@users.noreply.github.com>
@mtrezza mtrezza removed the type:docs Only change in the docs or README label Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release notes should contain index changes
3 participants