Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error type refactor #137

Merged
merged 4 commits into from
Oct 1, 2022
Merged

Error type refactor #137

merged 4 commits into from
Oct 1, 2022

Conversation

trueleo
Copy link
Contributor

@trueleo trueleo commented Oct 1, 2022

Fixes #81

Description

This PR removes the central error type with smaller error types which compose upward to make final response error. Necessary adjustments are made alongside. Finally top level error types convert to actix_error::Error.


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

This PR removes the central error type with smaller error types which compose
upward to make final response error. Necessary adjustments are made alongside.
@trueleo trueleo changed the title Error handling Refactor Error type refactor Oct 1, 2022
@trueleo trueleo marked this pull request as ready for review October 1, 2022 10:19
@nitisht nitisht merged commit 2edc52f into parseablehq:main Oct 1, 2022
@trueleo trueleo deleted the error_handling branch October 1, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use actix_web::Error for top level error handling.
2 participants