From 19d305dc47235f1d1514a02f621f4afa628f10b7 Mon Sep 17 00:00:00 2001
From: Nikhil Sinha <nikhil.sinha@cloudsurfex.com>
Date: Mon, 8 Jul 2024 19:22:06 +0530
Subject: [PATCH] improved error messages for remove ingestor API

---
 server/src/handlers/http/cluster/mod.rs | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/server/src/handlers/http/cluster/mod.rs b/server/src/handlers/http/cluster/mod.rs
index 32ccd5821..74ba8b34c 100644
--- a/server/src/handlers/http/cluster/mod.rs
+++ b/server/src/handlers/http/cluster/mod.rs
@@ -472,7 +472,9 @@ pub async fn remove_ingestor(req: HttpRequest) -> Result<impl Responder, PostErr
     let domain_name = to_url_string(domain_name);
 
     if check_liveness(&domain_name).await {
-        return Err(PostError::Invalid(anyhow::anyhow!("Node Online")));
+        return Err(PostError::Invalid(anyhow::anyhow!(
+            "The ingestor is currently live and cannot be removed"
+        )));
     }
     let object_store = CONFIG.storage().get_object_store();
 
@@ -500,13 +502,13 @@ pub async fn remove_ingestor(req: HttpRequest) -> Result<impl Responder, PostErr
         .await
     {
         Ok(_) => {
-            format!("Node {} Removed Successfully", domain_name)
+            format!("Ingestor {} removed successfully", domain_name)
         }
         Err(err) => {
             if matches!(err, ObjectStorageError::IoError(_)) {
-                format!("Node {} Not Found", domain_name)
+                format!("Ingestor {} is not found", domain_name)
             } else {
-                format!("Error Removing Node {}\n Reason: {}", domain_name, err)
+                format!("Error removing ingestor {}\n Reason: {}", domain_name, err)
             }
         }
     };