Protected feature #2734
Merged
Protected feature #2734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monkbroc
reviewed
Jan 30, 2024
| @@ -24,19 +24,23 @@ | |||
|
|
|||
| #define INTERNAL_FLASH_START_ADD 0x00000000 | |||
| #define INTERNAL_FLASH_END_ADDR 0x00100000 | |||
| #define INTERNAL_FLASH_IF_STRING "@Internal Flash /0x00000000/1*004Ka,47*004Kg,192*004Kg,4*004Kg,4*004Kg,8*004Ka"; | |||
| #define INTERNAL_FLASH_IF_STRING "@Internal Flash /0x00000000/1*004Ka,47*004Kg,192*004Kg,4*004Kg,4*004Kg,8*004Ka" | |||
| #define INTERNAL_FLASH_IF_STRING_PROT "@Internal Flash /0x00000000/1*004Kb,47*004Kb,192*004Kb,4*004Kb,4*004Kb,8*004Kb" | |||
There was a problem hiding this comment.
A comment explaining the reason for the different letters would be helpful so that someone looking at this in the future doesn't need to reverse engineer what the letters mean and why it's important to change them. This comment can wait for the next PR.
monkbroc
reviewed
Jan 30, 2024
services/inc/services_dynalib.h
Outdated
| @@ -96,6 +97,8 @@ DYNALIB_FN(48, services, devicetree_tree_lock, int(void*)) | |||
| DYNALIB_FN(49, services, devicetree_tree_get, int(void*, uint32_t, void*)) | |||
| DYNALIB_FN(50, services, devicetree_string_dictionary_lookup, const char*(uint32_t, void*)) | |||
| DYNALIB_FN(51, services, devicetree_hash_string, uint32_t(const char*, size_t)) | |||
| DYNALIB_FN(52, services, security_mode_set, int(module_info_security_mode, void*)) | |||
There was a problem hiding this comment.
Why do we need security_mode_set in dynalib? Shouldn't the bootloader be the only caller of this method?
There was a problem hiding this comment.
Needed for testing, it also doesn't allow protected->non-protected, so should be fine, but I'll remove this.
monkbroc
approved these changes
Jan 30, 2024
avtolstoy
force-pushed
the
feature/protected
branch
from
07abe9e to
fed0eb0
Compare
scott-brust
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO