[usb][rtl872x] Resolves deadlocks on boot with usbd_isr_ and app threads #2765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
MSOM devices deadlock when a USB serial terminal is left connected to them on boot. Examples are when doing DFU flashing via command line / workbench with either minicom or
particle serial monitorrunning.Solution
This PR avoids a lock between the app thread and the USB ISR thread that happens early on boot when attempting to log before system thread is started. See discussion here
Steps to Test
Connect minicom /
particle serial monitorto follow a device.Flash via DFU / workbench
USB serial should re-enumerate when the device boots and runs
Example App
Any