-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow temporarily disabling device protection #2770
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monkbroc
reviewed
May 21, 2024
monkbroc
reviewed
May 21, 2024
monkbroc
reviewed
May 21, 2024
sergeuz
force-pushed
the
disable-protected-mode/sc-127946
branch
from
May 24, 2024 13:07
0a7dbac
to
ad2609d
Compare
monkbroc
reviewed
Jun 13, 2024
monkbroc
reviewed
Jun 14, 2024
I'm marking this PR as ready for review even though it currently overflows on some of the platforms – we'll investigate that separately. The test steps can be found in sc-127946. |
monkbroc
approved these changes
Jun 14, 2024
…rprocedural modification and reference analysis)
avtolstoy
approved these changes
Jun 18, 2024
Load_SystemFlags(); | ||
system_flags.security_mode_override_value = MODULE_INFO_SECURITY_MODE_NONE; | ||
system_flags.security_mode_override_reset_count = 20; | ||
system_flags.security_mode_override_timeout = 24 * 60 * 60; // Seconds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: define a constant for this?
avtolstoy
force-pushed
the
disable-protected-mode/sc-127946
branch
from
June 19, 2024 14:26
fee5f04
to
b3e24f2
Compare
avtolstoy
force-pushed
the
disable-protected-mode/sc-127946
branch
from
June 19, 2024 16:59
b3e24f2
to
700bfc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement a challenge-response protocol between the device and the cloud to temporarily disable device protection. An external tool like the CLI transfers the information from the device to the API and back.
Changes
Behavior of protected mode
SerialLogHandler
does not output anything in protected mode, but starts outputing when protection is temporarily disabled, and other LogHandlers (including custom ones) still output in protected mode.Control requests
state
returns true when the device is currently protectedoverriden
returns true when the device would have been protected but protection is temporarily disabledUnprotect algorithm
References