Fix clippy warnings/errors #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #436 +/- ##
==========================================
- Coverage 81.92% 81.91% -0.02%
==========================================
Files 63 63
Lines 16728 16718 -10
Branches 16728 16718 -10
==========================================
- Hits 13705 13694 -11
+ Misses 2470 2460 -10
- Partials 553 564 +11
☔ View full report in Codecov by Sentry. |
Conformance comparison report
Number passing in both: 5731 Number failing in both: 612 Number passing in Base (fbaac0f) but now fail: 0 Number failing in Base (fbaac0f) but now pass: 0 |
alancai98
changed the title
alancai98
commented
Oct 24, 2023
Comment on lines
-186
to
-201
| let mut l = self.0.iter(); | ||
| let mut r = other.0.iter(); | ||
|
|
||
| loop { | ||
| match (l.next(), r.next()) { | ||
| (None, None) => return Some(Ordering::Equal), | ||
| (Some(_), None) => return Some(Ordering::Greater), | ||
| (None, Some(_)) => return Some(Ordering::Less), | ||
| (Some(lv), Some(rv)) => match lv.partial_cmp(rv) { | ||
| None => return None, | ||
| Some(Ordering::Less) => return Some(Ordering::Less), | ||
| Some(Ordering::Greater) => return Some(Ordering::Greater), | ||
| Some(Ordering::Equal) => continue, | ||
| }, | ||
| } | ||
| } |
There was a problem hiding this comment.
Having both Ord and PartialOrd implemented (with a non-default implementation) results in a clippy error: https://rust-lang.github.io/rust-clippy/master/index.html#/incorrect_partial_ord_impl_on_ord_type
am357
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like GH Actions CI has been failing since a recent clippy change turned a warning into an error. PR also fixes a different clippy warning.
This should fix the GitHub Actions failure seen in #435.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.