[Feature] Add Operator Product #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EthanObadia
changed the title
jpmoutinho
reviewed
Apr 9, 2024
dominikandreasseitz
changed the title
EthanObadia
changed the title
EthanObadia
changed the title
added 2 commits
April 16, 2024 14:42
There was a problem hiding this comment.
Nice work @EthanObadia looking good. Will approve after you've addressed these very last comments.
dominikandreasseitz
approved these changes
Apr 17, 2024
EthanObadia
changed the title
RolandMacDoland
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Hey @EthanObadia good job ! Looking good to me. Minor typing comments.
gvelikova
reviewed
Apr 19, 2024
gvelikova
reviewed
Apr 19, 2024
gvelikova
reviewed
Apr 19, 2024
added 2 commits
April 22, 2024 14:32
jpmoutinho
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
LGTM. I opened an issue to keep track of the possible optimization of the operator multiplication. We can discuss it at some point.
RolandMacDoland
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Looking good. Nice work @EthanObadia. Very final comments from my over-pedantic mindset. Will approve anyway.
added 2 commits
April 24, 2024 15:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
promote_operator()function to pyqtorch/utils.pyAdd
operator_product()function to pyqtorch/apply.pyAs @jpmoutinho said here, this version of
promote_operator()can be optimize. So, I believe that its optimization will be the object of an other PR later.Closes #153
Closes #154