[Feature] Time-dependence Port #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @dominikandreasseitz looking good. Some comments from me.
This was referenced Aug 30, 2024
vytautas-a
force-pushed
the
ds/timedep_port
branch
from
fe71257
to
aa434b0
Compare
|
@kaosmicadei, here's the working version of time-dependent generator for |
jpmoutinho
reviewed
Aug 30, 2024
There was a problem hiding this comment.
Very nice @vytautas-a, look good :)
I would just do some code cleanup on the HamEvo class and then it should be good to go.
jpmoutinho
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Thanks @vytautas-a. Feel free to merge in the meantime and then we can release. I've already bumped to 1.4.7 here: #276
RolandMacDoland
approved these changes
Sep 2, 2024
Co-authored-by: Roland-djee <9250798+Roland-djee@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting and adjusting @vytautas-a implementation of the time-dependent forward