Mthree #19
Merged
Mthree #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RolandMacDoland
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Thanks a lot @rajaiitp. Looking good. Few comments from my side.
|
Hey @rajaiitp feels like this can be merged. |
|
I wanted to push the changes that you requested in the review along with majority vote, sorry about the delay. I am done, will push in a few mins and request review |
There was a problem hiding this comment.
@rajaiitp Thank you for this. Comments from my side. Question, is the majority voting technique finalised ?
RolandMacDoland
approved these changes
Mar 13, 2024
|
Feel free to ping me for a huddle if you want me to walk you through the idea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing the following protocols (check linked issues for descriptions)