Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Adding tomography measurement protocol #37

Merged
merged 33 commits into from
Aug 6, 2024
Merged

[Feature] Adding tomography measurement protocol #37

merged 33 commits into from
Aug 6, 2024

Conversation

chMoussa
Copy link
Collaborator

@chMoussa chMoussa commented Aug 2, 2024

In this MR, we:

  • Added the tomography protocol from qadence
  • Factored protocols to inherent from a generic Protocol class
  • Modify docs accordingly
  • Added a few tests from qadence

@chMoussa chMoussa self-assigned this Aug 2, 2024
RolandMacDoland
RolandMacDoland reviewed Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@RolandMacDoland RolandMacDoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @chMoussa. I would watch for the types, there are few cases of type annotations from typing remaining. Also, expand a bit on the testing might really be useful.

chMoussa and others added 9 commits August 5, 2024 14:00
@chMoussa @RolandMacDoland
Update qadence_protocols/measurements/protocols.py
6afe91d 
Co-authored-by: Roland-djee <9250798+Roland-djee@users.noreply.github.com>
@chMoussa @RolandMacDoland
Update qadence_protocols/measurements/utils.py
b919cbc 
Co-authored-by: Roland-djee <9250798+Roland-djee@users.noreply.github.com>
@chMoussa @RolandMacDoland
Update qadence_protocols/measurements/utils.py
a5316cb 
Co-authored-by: Roland-djee <9250798+Roland-djee@users.noreply.github.com>
add refs and shadow part to come later
6d9fc11
try import fail
3e34a7f
one liner block
b211a85
type list
cfd9f61
rm instantiation of op X Y for rotation
81c2923
rm typing imports
e132f9f
@RolandMacDoland RolandMacDoland self-requested a review August 6, 2024 09:46
RolandMacDoland
RolandMacDoland approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@RolandMacDoland RolandMacDoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chMoussa. LGTM, minor quibbles.

@chMoussa chMoussa merged commit e5980a4 into main Aug 6, 2024
7 checks passed
@chMoussa chMoussa deleted the cm/measurements branch August 6, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RolandMacDoland RolandMacDoland RolandMacDoland approved these changes

Assignees

@chMoussa chMoussa

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chMoussa @RolandMacDoland