Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] More tests / refactor fill_identities #211

Closed
nmheim opened this issue Nov 22, 2023 · 1 comment
Closed

[Testing] More tests / refactor fill_identities #211

nmheim opened this issue Nov 22, 2023 · 1 comment
Assignees
Labels
testing Everything related to tests

Comments

@nmheim
Copy link
Collaborator

nmheim commented Nov 22, 2023

The fill_identities function is a transpilation pass that adds an identity block to every "empty" slot in a circuit. Currently it is only used for the drawing system.

It may need a refactor. Currently its a bit complicated/ugly. The following examples can be turned into tests:

b = chain(CNOT(0,1), CNOT(1,2))
b = chain(kron(CNOT(0,1)), kron(CNOT(1,2)))
b = kron(CNOT(0,1))
b = chain(SWAP(0,1), SWAP(0,3))
@nmheim nmheim added the good first issue Good for newcomers label Nov 22, 2023
@RolandMacDoland RolandMacDoland changed the title More tests for fill_identities [Testing] More tests for fill_identities Apr 18, 2024
@RolandMacDoland RolandMacDoland added the testing Everything related to tests label Apr 18, 2024
@jpmoutinho jpmoutinho removed the good first issue Good for newcomers label Apr 29, 2024
@mlahariya mlahariya assigned mlahariya and jpmoutinho and unassigned mlahariya Nov 19, 2024
@mlahariya
Copy link
Collaborator

@jpmoutinho Check if relevant and could be added to #613.

@jpmoutinho jpmoutinho changed the title [Testing] More tests for fill_identities [Testing] More tests / refactpr fill_identities Nov 26, 2024
@jpmoutinho jpmoutinho changed the title [Testing] More tests / refactpr fill_identities [Testing] More tests / refactor fill_identities Nov 26, 2024
@jpmoutinho jpmoutinho closed this as not planned Won't fix, can't repro, duplicate, stale Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Everything related to tests
Projects
None yet
Development

No branches or pull requests

4 participants