Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactoring] [Testing] Noise #583

Closed
chMoussa opened this issue Oct 14, 2024 · 2 comments
Closed

[Refactoring] [Testing] Noise #583

chMoussa opened this issue Oct 14, 2024 · 2 comments
Assignees
Labels
feature New feature or request refactoring Refactoring of legacy code testing Everything related to tests

Comments

@chMoussa
Copy link
Collaborator

Folowing the digital noise MR #563, a few extra tasks are to be carried out:

  • Properly making consistent the DigitalNoise with the Noise class and etc... Some are backend independent (Readout), others are analog/digital-specific. It makes sense to separate the different types.
  • Including the noise in each block string: if added, check how it behaves with visualization.
  • Serialization: make _to_dict and _from_dict functions to noise class
  • Add tests! For transpiler functions such as set_noise
@chMoussa chMoussa added feature New feature or request testing Everything related to tests refactoring Refactoring of legacy code labels Oct 14, 2024
@chMoussa
Copy link
Collaborator Author

At the same time, tackle #369

@mlahariya
Copy link
Collaborator

@chMoussa closing this as most things are already implemented. Visualization which is left will be added to mega visualization issue. #613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request refactoring Refactoring of legacy code testing Everything related to tests
Projects
None yet
Development

No branches or pull requests

4 participants