Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Adding more functionality to the expression tree #13

Open
jpmoutinho opened this issue May 14, 2024 · 2 comments
Open

[Feature] Adding more functionality to the expression tree #13

jpmoutinho opened this issue May 14, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@jpmoutinho
Copy link

Based on the original issue in Qadence, and respective prototype MR:
pasqal-io/qadence#399
pasqal-io/qadence#278

@dominikandreasseitz @kaosmicadei please add here what specific tree-like features should be implemented :)

@jpmoutinho jpmoutinho added the enhancement New feature or request label May 14, 2024
@RolandMacDoland
Copy link
Contributor

RolandMacDoland commented May 14, 2024

Some of them are already implemented but in no specific order:

  • Pattern based search and replace gates in a circuit
  • Parameter updates in circuits for training loops (ie. Ignacio's PR)
  • Register update ? Not sure that makes a lot of sense.

@kaosmicadei
Copy link
Contributor

The collect_operators is implemented using the map-reduce technique. That could be generalised to help implement other functionalities. The question is which ones and if it would be interesting to have a generic mapreduce(f_map, f_reduce, expression) implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants