-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Videos are removed from feed entries #75
Comments
Actually videos - and embedded contents in general - are removed by Feedparser due to its sanitization process. Removing sanitization altogether is not an option, since there are to many things that could go wrong while having to deal with unsafe HTML code. Instead, one could write a plugin that disable Feedparser sanitization only for iframe elements, thus allowing embedded videos to slip thru and than parse the entry again to remove any iframe which doesn't point to YouTube, Vimeo or any other popular whitelisted video streaming services. As today iframe element seems the primary suggested way to embed videos into web pages. For example: Vimeo
YouTube
Feedparser could be tamed to accept iframe elements with:
So it looks feasible, but it isn't trivial. ;^) |
I've managed to implement this feature in 5738cae. At the moment the only allowed domains as sources for iframe videos are:
It would be good to have a more precise list. Note: this commit doesn't fix the YT-generated RSS feeds. Currently the YT feeds do not contain embeds but only a thumbnail image and a link to the of the video. This will be handled in another way in the future UI. |
Currently youtube videos do not appear
I think it is not bad, but it would be nice to choose from:
The text was updated successfully, but these errors were encountered: