Skip to content

Commit 5ca0c53

Browse files
DanielBaduraDanielBadura
authored
Merge pull request #667 from patchlevel/enable-phpstan-for-tests
Enable PHPStan for the tests folder, Disable Psalm for test folder
2 parents fb798ff + 045f6f8 commit 5ca0c53

File tree

6 files changed

+975
-763
lines changed

6 files changed

+975
-763
lines changed

‎baseline.xml‎

Lines changed: 12 additions & 347 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,10 @@
11
<?xml version="1.0" encoding="UTF-8"?>
2-
<files psalm-version="6.9.6@61488aa2849793acfb72411829d114b4aa670941">
2+
<files psalm-version="6.12.0@cf420941d061a57050b6c468ef2c778faf40aee2">
33
<file src="src/Aggregate/AggregateRootBehaviour.php">
44
<UnsafeInstantiation>
55
<code><![CDATA[new static()]]></code>
66
</UnsafeInstantiation>
77
</file>
8-
<file src="src/Aggregate/ChildAggregateBehaviour.php">
9-
<MissingConstructor>
10-
<code><![CDATA[$recorder]]></code>
11-
<code><![CDATA[$recorder]]></code>
12-
</MissingConstructor>
13-
</file>
148
<file src="src/CommandBus/Handler/CreateAggregateHandler.php">
159
<InvalidOperand>
1610
<code><![CDATA[$this->parameterResolver->resolve($reflectionMethod, $command)]]></code>
@@ -103,6 +97,17 @@
10397
<code><![CDATA[archive]]></code>
10498
</UndefinedInterfaceMethod>
10599
</file>
100+
<file src="src/Serializer/Normalizer/IdNormalizer.php">
101+
<DeprecatedClass>
102+
<code><![CDATA[ReflectionTypeUtil::classStringInstanceOf(
103+
$reflectionType,
104+
AggregateRootId::class,
105+
)]]></code>
106+
</DeprecatedClass>
107+
<DeprecatedInterface>
108+
<code><![CDATA[IdNormalizer]]></code>
109+
</DeprecatedInterface>
110+
</file>
106111
<file src="src/Serializer/Upcast/Upcast.php">
107112
<MixedAssignment>
108113
<code><![CDATA[$payload[$key]]]></code>
@@ -225,344 +230,4 @@
225230
<code><![CDATA[$value]]></code>
226231
</MixedAssignment>
227232
</file>
228-
<file src="tests/Benchmark/PersonalDataBench.php">
229-
<MissingConstructor>
230-
<code><![CDATA[$multipleEventsId]]></code>
231-
<code><![CDATA[$repository]]></code>
232-
<code><![CDATA[$singleEventId]]></code>
233-
<code><![CDATA[$store]]></code>
234-
</MissingConstructor>
235-
</file>
236-
<file src="tests/Benchmark/SimpleSetupBench.php">
237-
<MissingConstructor>
238-
<code><![CDATA[$multipleEventsId]]></code>
239-
<code><![CDATA[$repository]]></code>
240-
<code><![CDATA[$singleEventId]]></code>
241-
<code><![CDATA[$store]]></code>
242-
</MissingConstructor>
243-
</file>
244-
<file src="tests/Benchmark/SimpleSetupStreamStoreBench.php">
245-
<MissingConstructor>
246-
<code><![CDATA[$multipleEventsId]]></code>
247-
<code><![CDATA[$repository]]></code>
248-
<code><![CDATA[$singleEventId]]></code>
249-
<code><![CDATA[$store]]></code>
250-
</MissingConstructor>
251-
</file>
252-
<file src="tests/Benchmark/SnapshotsBench.php">
253-
<MissingConstructor>
254-
<code><![CDATA[$adapter]]></code>
255-
<code><![CDATA[$id]]></code>
256-
<code><![CDATA[$repository]]></code>
257-
<code><![CDATA[$snapshotStore]]></code>
258-
<code><![CDATA[$store]]></code>
259-
</MissingConstructor>
260-
</file>
261-
<file src="tests/Benchmark/SplitStreamBench.php">
262-
<ArgumentTypeCoercion>
263-
<code><![CDATA[$this->id]]></code>
264-
</ArgumentTypeCoercion>
265-
<MissingConstructor>
266-
<code><![CDATA[$id]]></code>
267-
<code><![CDATA[$repository]]></code>
268-
<code><![CDATA[$store]]></code>
269-
</MissingConstructor>
270-
</file>
271-
<file src="tests/Benchmark/SubscriptionEngineBatchBench.php">
272-
<MissingConstructor>
273-
<code><![CDATA[$id]]></code>
274-
<code><![CDATA[$repository]]></code>
275-
<code><![CDATA[$store]]></code>
276-
<code><![CDATA[$subscriptionEngine]]></code>
277-
</MissingConstructor>
278-
</file>
279-
<file src="tests/Benchmark/SubscriptionEngineBench.php">
280-
<MissingConstructor>
281-
<code><![CDATA[$id]]></code>
282-
<code><![CDATA[$repository]]></code>
283-
<code><![CDATA[$store]]></code>
284-
<code><![CDATA[$subscriptionEngine]]></code>
285-
</MissingConstructor>
286-
</file>
287-
<file src="tests/Integration/ChildAggregate/PersonalInformation.php">
288-
<PropertyNotSetInConstructor>
289-
<code><![CDATA[PersonalInformation]]></code>
290-
</PropertyNotSetInConstructor>
291-
</file>
292-
<file src="tests/Integration/ChildAggregate/Views.php">
293-
<PropertyNotSetInConstructor>
294-
<code><![CDATA[Views]]></code>
295-
</PropertyNotSetInConstructor>
296-
</file>
297-
<file src="tests/Integration/PersonalData/PersonalDataTest.php">
298-
<MixedArgument>
299-
<code><![CDATA[$row['payload']]]></code>
300-
</MixedArgument>
301-
</file>
302-
<file src="tests/Integration/Store/StreamDoctrineDbalStoreTest.php">
303-
<RedundantCondition>
304-
<code><![CDATA[$stream?->close()]]></code>
305-
</RedundantCondition>
306-
<TypeDoesNotContainNull>
307-
<code><![CDATA[$stream]]></code>
308-
</TypeDoesNotContainNull>
309-
</file>
310-
<file src="tests/Integration/Subscription/SubscriptionTest.php">
311-
<InvalidArgument>
312-
<code><![CDATA[0]]></code>
313-
</InvalidArgument>
314-
</file>
315-
<file src="tests/Unit/CommandBus/AggregateHandlerProviderTest.php">
316-
<InvalidArrayAccess>
317-
<code><![CDATA[$result[0]]]></code>
318-
<code><![CDATA[$result[0]]]></code>
319-
</InvalidArrayAccess>
320-
<MixedMethodCall>
321-
<code><![CDATA[callable]]></code>
322-
<code><![CDATA[callable]]></code>
323-
</MixedMethodCall>
324-
</file>
325-
<file src="tests/Unit/CommandBus/Handler/CreateAggregateHandlerTest.php">
326-
<InvalidArgument>
327-
<code><![CDATA[$class::class]]></code>
328-
</InvalidArgument>
329-
</file>
330-
<file src="tests/Unit/CommandBus/Handler/DefaultParameterResolverTest.php">
331-
<MissingParamType>
332-
<code><![CDATA[$foo]]></code>
333-
<code><![CDATA[$foo]]></code>
334-
</MissingParamType>
335-
</file>
336-
<file src="tests/Unit/CommandBus/HandlerFinderTest.php">
337-
<MissingParamType>
338-
<code><![CDATA[$command]]></code>
339-
</MissingParamType>
340-
</file>
341-
<file src="tests/Unit/CommandBus/ServiceHandlerProviderTest.php">
342-
<InvalidArrayAccess>
343-
<code><![CDATA[$result[0]]]></code>
344-
<code><![CDATA[$result[0]]]></code>
345-
</InvalidArrayAccess>
346-
<MixedMethodCall>
347-
<code><![CDATA[callable]]></code>
348-
<code><![CDATA[callable]]></code>
349-
</MixedMethodCall>
350-
</file>
351-
<file src="tests/Unit/CommandBus/SyncCommandBusTest.php">
352-
<InvalidPropertyFetch>
353-
<code><![CDATA[$handler->command]]></code>
354-
</InvalidPropertyFetch>
355-
</file>
356-
<file src="tests/Unit/EventBus/DefaultEventBusTest.php">
357-
<MoreSpecificImplementedParamType>
358-
<code><![CDATA[$message]]></code>
359-
</MoreSpecificImplementedParamType>
360-
</file>
361-
<file src="tests/Unit/Fixture/MessageNormalizer.php">
362-
<MixedArgumentTypeCoercion>
363-
<code><![CDATA[$value]]></code>
364-
</MixedArgumentTypeCoercion>
365-
</file>
366-
<file src="tests/Unit/Fixture/ProfileWithBrokenApplyNoType.php">
367-
<MissingParamType>
368-
<code><![CDATA[$event]]></code>
369-
</MissingParamType>
370-
</file>
371-
<file src="tests/Unit/Metadata/Subscriber/AttributeSubscriberMetadataFactoryTest.php">
372-
<MissingParamType>
373-
<code><![CDATA[$message]]></code>
374-
</MissingParamType>
375-
</file>
376-
<file src="tests/Unit/QueryBus/HandlerFinderTest.php">
377-
<MissingParamType>
378-
<code><![CDATA[$query]]></code>
379-
</MissingParamType>
380-
</file>
381-
<file src="tests/Unit/QueryBus/ServiceHandlerProviderTest.php">
382-
<InvalidArrayAccess>
383-
<code><![CDATA[$result[0]]]></code>
384-
<code><![CDATA[$result[0]]]></code>
385-
</InvalidArrayAccess>
386-
<MixedMethodCall>
387-
<code><![CDATA[callable]]></code>
388-
<code><![CDATA[callable]]></code>
389-
</MixedMethodCall>
390-
</file>
391-
<file src="tests/Unit/QueryBus/SyncQueryBusTest.php">
392-
<InvalidPropertyFetch>
393-
<code><![CDATA[$handler->query]]></code>
394-
</InvalidPropertyFetch>
395-
</file>
396-
<file src="tests/Unit/Schema/DoctrineSchemaSubscriberTest.php">
397-
<DeprecatedClass>
398-
<code><![CDATA[DoctrineSchemaSubscriber::class]]></code>
399-
<code><![CDATA[new DoctrineSchemaSubscriber($schemaConfigurator->reveal())]]></code>
400-
<code><![CDATA[new DoctrineSchemaSubscriber($schemaConfigurator->reveal())]]></code>
401-
</DeprecatedClass>
402-
</file>
403-
<file src="tests/Unit/Store/DoctrineDbalStoreTest.php">
404-
<DeprecatedMethod>
405-
<code><![CDATA[addMethods]]></code>
406-
</DeprecatedMethod>
407-
<InternalMethod>
408-
<code><![CDATA[new DefaultSelectSQLBuilder(
409-
$abstractPlatform->reveal(),
410-
'FOR UPDATE',
411-
'SKIP LOCKED',
412-
)]]></code>
413-
<code><![CDATA[new DefaultSelectSQLBuilder(
414-
$abstractPlatform->reveal(),
415-
'FOR UPDATE',
416-
'SKIP LOCKED',
417-
)]]></code>
418-
<code><![CDATA[new DefaultSelectSQLBuilder(
419-
$abstractPlatform->reveal(),
420-
'FOR UPDATE',
421-
'SKIP LOCKED',
422-
)]]></code>
423-
<code><![CDATA[new DefaultSelectSQLBuilder(
424-
$abstractPlatform->reveal(),
425-
'FOR UPDATE',
426-
'SKIP LOCKED',
427-
)]]></code>
428-
<code><![CDATA[new DefaultSelectSQLBuilder(
429-
$abstractPlatform->reveal(),
430-
'FOR UPDATE',
431-
'SKIP LOCKED',
432-
)]]></code>
433-
<code><![CDATA[new DefaultSelectSQLBuilder(
434-
$abstractPlatform->reveal(),
435-
'FOR UPDATE',
436-
'SKIP LOCKED',
437-
)]]></code>
438-
<code><![CDATA[new DefaultSelectSQLBuilder(
439-
$abstractPlatform->reveal(),
440-
'FOR UPDATE',
441-
'SKIP LOCKED',
442-
)]]></code>
443-
<code><![CDATA[new DefaultSelectSQLBuilder(
444-
$abstractPlatform->reveal(),
445-
'FOR UPDATE',
446-
'SKIP LOCKED',
447-
)]]></code>
448-
</InternalMethod>
449-
</file>
450-
<file src="tests/Unit/Store/StreamDoctrineDbalStoreTest.php">
451-
<DeprecatedMethod>
452-
<code><![CDATA[addMethods]]></code>
453-
</DeprecatedMethod>
454-
<InternalMethod>
455-
<code><![CDATA[new DefaultSelectSQLBuilder(
456-
$abstractPlatform->reveal(),
457-
'FOR UPDATE',
458-
'SKIP LOCKED',
459-
)]]></code>
460-
<code><![CDATA[new DefaultSelectSQLBuilder(
461-
$abstractPlatform->reveal(),
462-
'FOR UPDATE',
463-
'SKIP LOCKED',
464-
)]]></code>
465-
<code><![CDATA[new DefaultSelectSQLBuilder(
466-
$abstractPlatform->reveal(),
467-
'FOR UPDATE',
468-
'SKIP LOCKED',
469-
)]]></code>
470-
<code><![CDATA[new DefaultSelectSQLBuilder(
471-
$abstractPlatform->reveal(),
472-
'FOR UPDATE',
473-
'SKIP LOCKED',
474-
)]]></code>
475-
<code><![CDATA[new DefaultSelectSQLBuilder(
476-
$abstractPlatform->reveal(),
477-
'FOR UPDATE',
478-
'SKIP LOCKED',
479-
)]]></code>
480-
<code><![CDATA[new DefaultSelectSQLBuilder(
481-
$abstractPlatform->reveal(),
482-
'FOR UPDATE',
483-
'SKIP LOCKED',
484-
)]]></code>
485-
<code><![CDATA[new DefaultSelectSQLBuilder(
486-
$abstractPlatform->reveal(),
487-
'FOR UPDATE',
488-
'SKIP LOCKED',
489-
)]]></code>
490-
<code><![CDATA[new DefaultSelectSQLBuilder(
491-
$abstractPlatform->reveal(),
492-
'FOR UPDATE',
493-
'SKIP LOCKED',
494-
)]]></code>
495-
<code><![CDATA[new DefaultSelectSQLBuilder(
496-
$abstractPlatform->reveal(),
497-
'FOR UPDATE',
498-
'SKIP LOCKED',
499-
)]]></code>
500-
<code><![CDATA[new DefaultSelectSQLBuilder(
501-
$abstractPlatform->reveal(),
502-
'FOR UPDATE',
503-
'SKIP LOCKED',
504-
)]]></code>
505-
<code><![CDATA[new DefaultSelectSQLBuilder(
506-
$abstractPlatform->reveal(),
507-
'FOR UPDATE',
508-
'SKIP LOCKED',
509-
)]]></code>
510-
</InternalMethod>
511-
</file>
512-
<file src="tests/Unit/Subscription/Engine/DefaultSubscriptionEngineTest.php">
513-
<PossiblyNullArgument>
514-
<code><![CDATA[$subscriber->throwForBeginBatch]]></code>
515-
<code><![CDATA[$subscriber->throwForBeginBatch]]></code>
516-
<code><![CDATA[$subscriber->throwForCommitBatch]]></code>
517-
<code><![CDATA[$subscriber->throwForCommitBatch]]></code>
518-
<code><![CDATA[$subscriber->throwForMessage]]></code>
519-
<code><![CDATA[$subscriber->throwForMessage]]></code>
520-
<code><![CDATA[$subscriber->throwForMessage]]></code>
521-
<code><![CDATA[$subscriber->throwForMessage]]></code>
522-
</PossiblyNullArgument>
523-
<PossiblyUndefinedArrayOffset>
524-
<code><![CDATA[$update1]]></code>
525-
</PossiblyUndefinedArrayOffset>
526-
</file>
527-
<file src="tests/Unit/Subscription/Engine/GapResolverStoreMessageLoaderTest.php">
528-
<PossiblyNullArrayOffset>
529-
<code><![CDATA[$result]]></code>
530-
</PossiblyNullArrayOffset>
531-
</file>
532-
<file src="tests/Unit/Subscription/Engine/SubscriptionManagerTest.php">
533-
<InvalidArgument>
534-
<code><![CDATA[$subscriptions]]></code>
535-
<code><![CDATA[$subscriptions]]></code>
536-
</InvalidArgument>
537-
</file>
538-
<file src="tests/Unit/Subscription/RetryStrategy/ClockBasedRetryStrategyTest.php">
539-
<ArgumentTypeCoercion>
540-
<code><![CDATA[$maxAttempts]]></code>
541-
</ArgumentTypeCoercion>
542-
</file>
543-
<file src="tests/Unit/Subscription/Subscriber/ArgumentResolver/AggregateIdArgumentResolverTest.php">
544-
<DeprecatedClass>
545-
<code><![CDATA[AggregateIdArgumentResolver::class]]></code>
546-
<code><![CDATA[new AggregateIdArgumentResolver()]]></code>
547-
<code><![CDATA[new AggregateIdArgumentResolver()]]></code>
548-
</DeprecatedClass>
549-
</file>
550-
<file src="tests/Unit/Subscription/Subscriber/ArgumentResolver/LookupResolverTest.php">
551-
<DeprecatedClass>
552-
<code><![CDATA[AggregateIdArgumentResolver::class]]></code>
553-
</DeprecatedClass>
554-
</file>
555-
<file src="tests/Unit/Subscription/Subscriber/MetadataSubscriberAccessorRepositoryTest.php">
556-
<DeprecatedClass>
557-
<code><![CDATA[new ArgumentResolver\AggregateIdArgumentResolver()]]></code>
558-
</DeprecatedClass>
559-
</file>
560-
<file src="tests/Unit/Subscription/Subscriber/MetadataSubscriberAccessorTest.php">
561-
<DeprecatedMethod>
562-
<code><![CDATA[group]]></code>
563-
<code><![CDATA[id]]></code>
564-
<code><![CDATA[realSubscriber]]></code>
565-
<code><![CDATA[runMode]]></code>
566-
</DeprecatedMethod>
567-
</file>
568233
</files>

‎composer.json‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,14 +40,15 @@
4040
"cspray/phinal": "dev-main#9826c3407056a4618f8bba303800403e47ccb3a7",
4141
"doctrine/orm": "^2.18.0 || ^3.0.0",
4242
"infection/infection": "^0.29.12",
43+
"jangregor/phpstan-prophecy": "^2.0",
4344
"league/commonmark": "^2.6.1",
4445
"patchlevel/coding-standard": "^1.3.0",
4546
"patchlevel/event-sourcing-psalm-plugin": "^3.1.0",
4647
"phpbench/phpbench": "^1.4.1",
4748
"phpspec/prophecy-phpunit": "^2.3.0",
4849
"phpstan/phpstan": "^2.1.11",
50+
"phpstan/phpstan-phpunit": "^2.0",
4951
"phpunit/phpunit": "^11.5.15",
50-
"psalm/plugin-phpunit": "^0.19.3",
5152
"roave/infection-static-analysis-plugin": "^1.37.0",
5253
"symfony/messenger": "^5.4.31 || ^6.4.0 || ^7.0.1",
5354
"symfony/var-dumper": "^5.4.29 || ^6.4.0 || ^7.0.0",

0 commit comments

Comments
 (0)