Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed php7.4, added support php8.1 #135

Merged
merged 6 commits into from
Dec 21, 2021
Merged

removed php7.4, added support php8.1 #135

merged 6 commits into from
Dec 21, 2021

Conversation

robinlehrmann
Copy link
Contributor

belongs to #134

@DavidBadura
Copy link
Member

you need to change the php versions in the .github/workflow too ;-)

DavidBadura
DavidBadura requested changes Dec 18, 2021
View reviewed changes
.github/workflows/coding-standard.yml Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
.github/workflows/phpunit.yml Show resolved Hide resolved
@robinlehrmann robinlehrmann marked this pull request as draft December 18, 2021 14:47
@DavidBadura DavidBadura added this to the 1.1.0 milestone Dec 18, 2021
@robinlehrmann
Copy link
Contributor Author

robinlehrmann commented Dec 18, 2021 •
edited
Loading

@DavidBadura
Do you know why this is failing ? https://github.com/patchlevel/event-sourcing/runs/4569869039?check_suite_focus=true 😅
In this line is nothing 🤔 vendor/symfony/console/Helper/Table.php:564
I also didn't find a strstr in your ShowCommandTest 😄

@robinlehrmann robinlehrmann marked this pull request as ready for review December 18, 2021 15:24
@DavidBadura
Copy link
Member

DavidBadura commented Dec 20, 2021 •
edited
Loading

The error was here: https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Console/Helper/Table.php#L566

symfony fixed it in a patch already. I bump the minimum version in this pr #136. If you rebase your branch it should be fixed now :)

DavidBadura
DavidBadura requested changes Dec 20, 2021
View reviewed changes
.github/workflows/phpstan.yml Outdated Show resolved Hide resolved
.github/workflows/psalm.yml Outdated Show resolved Hide resolved
@DavidBadura DavidBadura added the enhancement New feature or request label Dec 20, 2021
@DanielBadura DanielBadura added the dependencies Pull requests that update a dependency file label Dec 20, 2021
@DanielBadura
Copy link
Member

Thanks @robinlehrmann !

@DanielBadura DanielBadura merged commit 64dd241 into patchlevel:1.1.x Dec 21, 2021
@robinlehrmann robinlehrmann deleted the php8.1 branch December 21, 2021 13:49
@DavidBadura DavidBadura mentioned this pull request Dec 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielBadura DanielBadura DanielBadura approved these changes

@DavidBadura DavidBadura DavidBadura approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@robinlehrmann @DavidBadura @DanielBadura