Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to pass upcaster #280

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Allow to pass upcaster #280

merged 1 commit into from
Jun 28, 2022

Conversation

DavidBadura
Copy link
Member

No description provided.

@DavidBadura DavidBadura added the enhancement New feature or request label Jun 28, 2022
@DavidBadura DavidBadura added this to the 2.0.0 milestone Jun 28, 2022
@DavidBadura DavidBadura requested a review from DanielBadura June 28, 2022 14:30
@DavidBadura DavidBadura force-pushed the allow-to-pass-upcaster branch from 70272f5 to 5d14602 Compare June 28, 2022 14:31
@DavidBadura DavidBadura marked this pull request as ready for review June 28, 2022 14:32
@github-actions
Copy link

github-actions bot commented Jun 28, 2022

Hello 👋

here is the most recent benchmark result:

LoadEventsWithSnapshotsBench
============================

Average iteration times by variant

254.8μs   │ ██ 
223.0μs   │ ██ 
191.1μs   │ ██ 
159.3μs   │ ██ 
127.4μs   │ ██ 
95.6μs    │ ██ 
63.7μs    │ ██ 
31.9μs    │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

Memory by variant

14.2mb    │ ██ 
12.4mb    │ ██ 
10.6mb    │ ██ 
8.8mb     │ ██ 
7.1mb     │ ██ 
5.3mb     │ ██ 
3.5mb     │ ██ 
1.8mb     │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

+--------------------+--------------------+--------------------+-----------------+------------+
|                    | time (kde mode)                         | memory                       |
+--------------------+--------------------+--------------------+-----------------+------------+
| subject            | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+--------------------+--------------------+--------------------+-----------------+------------+
| benchLoadEvents () | 254.649μs (±0.18%) | 254.849μs (±0.18%) | 14.152mb        | 14.151mb   |
+--------------------+--------------------+--------------------+-----------------+------------+

WriteEventsBench
================

Average iteration times by variant

38.7ms    │    ██ 
33.9ms    │    ██ 
29.0ms    │    ██ 
24.2ms    │    ██ 
19.4ms    │    ██ 
14.5ms    │    ██ 
9.7ms     │    ██ 
4.8ms     │ ▃▃ ██ 
          └───────
            1  2  

[█ <current>] [█ base] 

1: benchSaveOneEvent    2: benchSaveAfterThous᠁ 

Memory by variant

7.2mb     │ ▂▂ ██ 
6.3mb     │ ██ ██ 
5.4mb     │ ██ ██ 
4.5mb     │ ██ ██ 
3.6mb     │ ██ ██ 
2.7mb     │ ██ ██ 
1.8mb     │ ██ ██ 
906.0kb   │ ██ ██ 
          └───────
            1  2  

[█ <current>] [█ base] 

1: benchSaveOneEvent    2: benchSaveAfterThous᠁ 

+---------------------------------+-------------------+-------------------+-----------------+------------+
|                                 | time (kde mode)                       | memory                       |
+---------------------------------+-------------------+-------------------+-----------------+------------+
| subject                         | Tag: <current>    | Tag: base         | Tag: <current>  | Tag: base  |
+---------------------------------+-------------------+-------------------+-----------------+------------+
| benchSaveOneEvent ()            | 1.235ms (±6.21%)  | 1.244ms (±19.18%) | 6.554mb         | 6.554mb    |
| benchSaveAfterThousandEvents () | 38.250ms (±0.08%) | 38.714ms (±0.59%) | 7.248mb         | 7.248mb    |
+---------------------------------+-------------------+-------------------+-----------------+------------+

LoadEventsBench
===============

Average iteration times by variant

101.9ms   │ ██ 
89.1ms    │ ██ 
76.4ms    │ ██ 
63.7ms    │ ██ 
50.9ms    │ ██ 
38.2ms    │ ██ 
25.5ms    │ ██ 
12.7ms    │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

Memory by variant

20.5mb    │ ██ 
17.9mb    │ ██ 
15.4mb    │ ██ 
12.8mb    │ ██ 
10.2mb    │ ██ 
7.7mb     │ ██ 
5.1mb     │ ██ 
2.6mb     │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

+--------------------+--------------------+--------------------+-----------------+------------+
|                    | time (kde mode)                         | memory                       |
+--------------------+--------------------+--------------------+-----------------+------------+
| subject            | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+--------------------+--------------------+--------------------+-----------------+------------+
| benchLoadEvents () | 101.879ms (±2.78%) | 100.485ms (±0.16%) | 20.491mb        | 20.491mb   |
+--------------------+--------------------+--------------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura mentioned this pull request Jun 28, 2022
@DavidBadura DavidBadura merged commit 38c4032 into 2.0.x Jun 28, 2022
@DavidBadura DavidBadura deleted the allow-to-pass-upcaster branch June 28, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants