Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only build docs on changes for branches #315

Merged
merged 1 commit into from
Sep 24, 2022

Conversation

DanielBadura
Copy link
Member

@DanielBadura DanielBadura commented Sep 23, 2022

We dont need to recreate the current doc page if there are no changes made. For publishing releases we still generate the docs even if we did not change something in the docs, which is highly unlikely but still considered.

Would also make this patch for the bundle if this here is merged.

… made. For publishing releases we still generate the docs even if we did not change something in the docs, which is highly unlikely but still considered.
@github-actions
Copy link

Hello 👋

here is the most recent benchmark result:

WriteEventsBench
================

Average iteration times by variant

57.5ms    │    ██ 
50.3ms    │    ██ 
43.1ms    │    ██ 
36.0ms    │    ██ 
28.8ms    │    ██ 
21.6ms    │    ██ 
14.4ms    │    ██ 
7.2ms     │ ▃▃ ██ 
          └───────
            1  2  

[█ <current>] [█ base] 

1: benchSaveOneEvent    2: benchSaveAfterThous᠁ 

Memory by variant

7.3mb     │ ▂▂ ██ 
6.4mb     │ ██ ██ 
5.5mb     │ ██ ██ 
4.6mb     │ ██ ██ 
3.7mb     │ ██ ██ 
2.8mb     │ ██ ██ 
1.8mb     │ ██ ██ 
918.1kb   │ ██ ██ 
          └───────
            1  2  

[█ <current>] [█ base] 

1: benchSaveOneEvent    2: benchSaveAfterThous᠁ 

+---------------------------------+-------------------+-------------------+-----------------+------------+
|                                 | time (kde mode)                       | memory                       |
+---------------------------------+-------------------+-------------------+-----------------+------------+
| subject                         | Tag: <current>    | Tag: base         | Tag: <current>  | Tag: base  |
+---------------------------------+-------------------+-------------------+-----------------+------------+
| benchSaveOneEvent ()            | 1.917ms (±9.24%)  | 2.155ms (±17.21%) | 6.649mb         | 6.649mb    |
| benchSaveAfterThousandEvents () | 57.173ms (±1.16%) | 57.520ms (±0.49%) | 7.345mb         | 7.345mb    |
+---------------------------------+-------------------+-------------------+-----------------+------------+

LoadEventsWithSnapshotsBench
============================

Average iteration times by variant

357.6μs   │ ██ 
312.9μs   │ ██ 
268.2μs   │ ██ 
223.5μs   │ ██ 
178.8μs   │ ██ 
134.1μs   │ ██ 
89.4μs    │ ██ 
44.7μs    │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

Memory by variant

14.2mb    │ ██ 
12.5mb    │ ██ 
10.7mb    │ ██ 
8.9mb     │ ██ 
7.1mb     │ ██ 
5.3mb     │ ██ 
3.6mb     │ ██ 
1.8mb     │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

+--------------------+--------------------+--------------------+-----------------+------------+
|                    | time (kde mode)                         | memory                       |
+--------------------+--------------------+--------------------+-----------------+------------+
| subject            | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+--------------------+--------------------+--------------------+-----------------+------------+
| benchLoadEvents () | 357.599μs (±0.14%) | 354.731μs (±2.72%) | 14.243mb        | 14.243mb   |
+--------------------+--------------------+--------------------+-----------------+------------+

LoadEventsBench
===============

Average iteration times by variant

131.6ms   │ ██ 
115.2ms   │ ██ 
98.7ms    │ ██ 
82.3ms    │ ██ 
65.8ms    │ ██ 
49.4ms    │ ██ 
32.9ms    │ ██ 
16.5ms    │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

Memory by variant

20.6mb    │ ██ 
18.1mb    │ ██ 
15.5mb    │ ██ 
12.9mb    │ ██ 
10.3mb    │ ██ 
7.7mb     │ ██ 
5.2mb     │ ██ 
2.6mb     │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

+--------------------+--------------------+--------------------+-----------------+------------+
|                    | time (kde mode)                         | memory                       |
+--------------------+--------------------+--------------------+-----------------+------------+
| subject            | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+--------------------+--------------------+--------------------+-----------------+------------+
| benchLoadEvents () | 130.909ms (±0.34%) | 131.633ms (±1.26%) | 20.646mb        | 20.646mb   |
+--------------------+--------------------+--------------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants