Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add clock as required paramter in repository #395

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

DavidBadura
Copy link
Member

Currently the clock has been added as a decorator. However, the RecordedOn information is required. As soon as the user wants to add their own decorator, they need to know that they have to add the RecordedOn decorator themselves. That leads to errors. Instead, the clock is passed directly and the decorator was removed.

@DavidBadura DavidBadura added this to the 3.0.0 milestone Jul 10, 2023
@DavidBadura DavidBadura requested a review from DanielBadura July 10, 2023 21:42
@github-actions
Copy link

Hello 👋

here is the most recent benchmark result:

LoadEventsWithSnapshotsBench
============================

Average iteration times by variant

348.8μs   │ ▆█ 
305.2μs   │ ██ 
261.6μs   │ ██ 
218.0μs   │ ██ 
174.4μs   │ ██ 
130.8μs   │ ██ 
87.2μs    │ ██ 
43.6μs    │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

Memory by variant

13.6mb    │ ██ 
11.9mb    │ ██ 
10.2mb    │ ██ 
8.5mb     │ ██ 
6.8mb     │ ██ 
5.1mb     │ ██ 
3.4mb     │ ██ 
1.7mb     │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

+--------------------+--------------------+--------------------+-----------------+------------+
|                    | time (kde mode)                         | memory                       |
+--------------------+--------------------+--------------------+-----------------+------------+
| subject            | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+--------------------+--------------------+--------------------+-----------------+------------+
| benchLoadEvents () | 334.281μs (±2.90%) | 348.769μs (±4.50%) | 13.552mb        | 13.555mb   |
+--------------------+--------------------+--------------------+-----------------+------------+

LoadEventsBench
===============

Average iteration times by variant

131.6ms   │ ██ 
115.1ms   │ ██ 
98.7ms    │ ██ 
82.2ms    │ ██ 
65.8ms    │ ██ 
49.3ms    │ ██ 
32.9ms    │ ██ 
16.4ms    │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

Memory by variant

13.5mb    │ ██ 
11.8mb    │ ██ 
10.1mb    │ ██ 
8.5mb     │ ██ 
6.8mb     │ ██ 
5.1mb     │ ██ 
3.4mb     │ ██ 
1.7mb     │ ██ 
          └────
            1  

[█ <current>] [█ base] 

1: benchLoadEvents 

+--------------------+--------------------+--------------------+-----------------+------------+
|                    | time (kde mode)                         | memory                       |
+--------------------+--------------------+--------------------+-----------------+------------+
| subject            | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+--------------------+--------------------+--------------------+-----------------+------------+
| benchLoadEvents () | 131.577ms (±0.66%) | 130.789ms (±0.43%) | 13.522mb        | 13.533mb   |
+--------------------+--------------------+--------------------+-----------------+------------+

WriteEventsBench
================

Average iteration times by variant

51.3ms    │    ██ 
44.9ms    │    ██ 
38.5ms    │    ██ 
32.1ms    │    ██ 
25.7ms    │    ██ 
19.3ms    │    ██ 
12.8ms    │    ██ 
6.4ms     │ ▂▂ ██ 
          └───────
            1  2  

[█ <current>] [█ base] 

1: benchSaveOneEvent    2: benchSaveAfterThous᠁ 

Memory by variant

7.4mb     │ ▃▃ ██ 
6.5mb     │ ██ ██ 
5.6mb     │ ██ ██ 
4.6mb     │ ██ ██ 
3.7mb     │ ██ ██ 
2.8mb     │ ██ ██ 
1.9mb     │ ██ ██ 
929.0kb   │ ██ ██ 
          └───────
            1  2  

[█ <current>] [█ base] 

1: benchSaveOneEvent    2: benchSaveAfterThous᠁ 

+---------------------------------+-------------------+-------------------+-----------------+------------+
|                                 | time (kde mode)                       | memory                       |
+---------------------------------+-------------------+-------------------+-----------------+------------+
| subject                         | Tag: <current>    | Tag: base         | Tag: <current>  | Tag: base  |
+---------------------------------+-------------------+-------------------+-----------------+------------+
| benchSaveOneEvent ()            | 1.070ms (±3.57%)  | 1.002ms (±0.71%)  | 6.804mb         | 6.807mb    |
| benchSaveAfterThousandEvents () | 51.105ms (±0.17%) | 51.336ms (±0.10%) | 7.430mb         | 7.432mb    |
+---------------------------------+-------------------+-------------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura merged commit 6b495eb into 3.0.x Jul 11, 2023
@DavidBadura DavidBadura deleted the add-clock-as-required-parameter-in-repository branch July 11, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants