Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename handle to subscribe #448

Merged
merged 1 commit into from
Dec 24, 2023
Merged

rename handle to subscribe #448

merged 1 commit into from
Dec 24, 2023

Conversation

DavidBadura
Copy link
Member

"Handle" was sometimes difficult to understand in the context and it was not easy to explain. "Subscribe" describes much better what happens in the background.

@DavidBadura DavidBadura added this to the 3.0.0 milestone Dec 24, 2023
Copy link

Hello 👋

here is the most recent benchmark result:

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events ()                | 124.348ms (±0.00%) | 123.810ms (±0.00%) | 31.982mb        | 31.982mb   |
| benchSave1Event ()                     | 1.031ms (±0.00%)   | 1.145ms (±0.00%)   | 31.982mb        | 31.982mb   |
| benchSave10000Events ()                | 278.296ms (±0.00%) | 277.491ms (±0.00%) | 32.206mb        | 32.206mb   |
| benchSave10000Aggregates ()            | 10.151s (±0.00%)   | 10.543s (±0.00%)   | 31.982mb        | 31.982mb   |
| benchSave10000AggregatesTransaction () | 625.399ms (±0.00%) | 633.932ms (±0.00%) | 31.982mb        | 31.982mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events () | 2.291ms (±0.00%)   | 2.315ms (±0.00%)   | 35.370mb        | 35.370mb   |
| benchSave10000Events () | 357.203ms (±0.00%) | 357.314ms (±0.00%) | 35.637mb        | 35.637mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

SyncProjectionistBench
======================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchSave1Event ()      | 1.299ms (±0.00%)   | 1.336ms (±0.00%)   | 7.464mb         | 7.464mb    |
| benchSave10000Events () | 458.254ms (±0.00%) | 444.101ms (±0.00%) | 32.795mb        | 32.795mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000EventsMissingSnapshot () | 124.596ms (±0.00%) | 126.919ms (±0.00%) | 32.007mb        | 32.007mb   |
| benchLoad10000Events ()                | 194.150μs (±0.00%) | 191.550μs (±0.00%) | 32.007mb        | 32.007mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura merged commit e4a4983 into 3.0.x Dec 24, 2023
32 of 33 checks passed
@DavidBadura DavidBadura deleted the rename-handle-to-subscribe branch December 24, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants