Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Attributes for Projector #452

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Rename Attributes for Projector #452

merged 2 commits into from
Jan 3, 2024

Conversation

DavidBadura
Copy link
Member

@DavidBadura DavidBadura commented Jan 2, 2024 •
edited
Loading

  • "Projection" into "Projector"
  • "Create" into "Setup"
  • "Drop" into "Teardown"

@DavidBadura DavidBadura added this to the 3.0.0 milestone Jan 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2024 •
edited
Loading

Hello 👋

here is the most recent benchmark result: 

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events ()                | 124.372ms (±0.00%) | 125.602ms (±0.00%) | 32.597mb        | 32.597mb   |
| benchSave1Event ()                     | 978.800μs (±0.00%) | 1.059ms (±0.00%)   | 32.597mb        | 32.597mb   |
| benchSave10000Events ()                | 278.685ms (±0.00%) | 279.852ms (±0.00%) | 32.820mb        | 32.820mb   |
| benchSave10000Aggregates ()            | 10.420s (±0.00%)   | 10.528s (±0.00%)   | 32.597mb        | 32.597mb   |
| benchSave10000AggregatesTransaction () | 731.443ms (±0.00%) | 752.282ms (±0.00%) | 32.597mb        | 32.597mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events () | 2.322ms (±0.00%)   | 2.345ms (±0.00%)   | 35.981mb        | 35.981mb   |
| benchSave10000Events () | 358.202ms (±0.00%) | 365.710ms (±0.00%) | 36.245mb        | 36.245mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

SyncProjectionistBench
======================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchSave1Event ()      | 1.271ms (±0.00%)   | 1.323ms (±0.00%)   | 8.088mb         | 8.088mb    |
| benchSave10000Events () | 448.209ms (±0.00%) | 451.495ms (±0.00%) | 33.419mb        | 33.419mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000EventsMissingSnapshot () | 123.332ms (±0.00%) | 125.208ms (±0.00%) | 32.618mb        | 32.618mb   |
| benchLoad10000Events ()                | 201.200μs (±0.00%) | 195.250μs (±0.00%) | 32.618mb        | 32.618mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura force-pushed the rename-projection-attribute-into-projector branch from 23d478c to 870c2e3 Compare January 2, 2024 17:48
@DavidBadura DavidBadura force-pushed the rename-projection-attribute-into-projector branch 3 times, most recently from a9581cf to 51533f9 Compare January 3, 2024 12:13
@DavidBadura DavidBadura force-pushed the rename-projection-attribute-into-projector branch from 51533f9 to 0494d16 Compare January 3, 2024 12:16
@DavidBadura DavidBadura changed the title rename projection attribute into projector rename projection attributes Jan 3, 2024
@DanielBadura DanielBadura changed the title rename projection attributes Rename Attributes for Projector Jan 3, 2024
@DavidBadura DavidBadura merged commit 0f98c5f into 3.0.x Jan 3, 2024
31 of 33 checks passed
@DavidBadura DavidBadura deleted the rename-projection-attribute-into-projector branch January 3, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielBadura DanielBadura DanielBadura approved these changes

Assignees
No one assigned
Labels
BC-Break
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidBadura @DanielBadura