-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove nested encoding #565
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello 👋 here is the most recent benchmark result:
This comment gets update everytime a new commit comes in! |
DavidBadura
force-pushed
the
remove-nested-encoding
branch
2 times, most recently
from
April 3, 2024 16:28
11689cc
to
eed227e
Compare
DavidBadura
force-pushed
the
remove-nested-encoding
branch
2 times, most recently
from
April 9, 2024 10:06
757a04c
to
964b37f
Compare
DavidBadura
force-pushed
the
remove-nested-encoding
branch
from
April 9, 2024 10:24
964b37f
to
15aeca9
Compare
DanielBadura
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we serialize every single header as json, and at the end save the whole thing again in the db as json. We can make this more optimized by no longer serializing all individual headers as json and only in the DB.
The typehints were opened to allow other serializers. The main thing is to allow a
LegacyHeadersSerializer
that can process the old headers from the 2.x store.