Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix finish flag in subscription engine #594

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

DavidBadura
Copy link
Member

@DavidBadura DavidBadura commented Apr 25, 2024

The flag is there to identify whether work still exists. "No subscriptions" was incorrectly marked as not finished because the flag was just named "streamFinished". I renamed the flag and included this case as "finished".

Otherwise you would have an endless loop in the boot because there was nothing to boot, but it wasn't set to finished either.

@DavidBadura DavidBadura added the bug Something isn't working label Apr 25, 2024
@DavidBadura DavidBadura added this to the 3.0.0 milestone Apr 25, 2024
@DavidBadura DavidBadura force-pushed the fix-finished-subscription-engine branch from 35f81f0 to c3df31b Compare April 25, 2024 07:29
@DavidBadura DavidBadura merged commit 17a4440 into 3.0.x Apr 25, 2024
35 of 37 checks passed
@DavidBadura DavidBadura deleted the fix-finished-subscription-engine branch April 25, 2024 07:31
Copy link

github-actions bot commented Apr 25, 2024

Hello 👋

here is the most recent benchmark result:

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 4.911ms (±0.00%)   | 4.863ms (±0.00%)   | +1.00%    | 37.572mb        | 37.578mb   | -0.02%      |
| benchSave10000Events () | 350.782ms (±0.00%) | 370.633ms (±0.00%) | -5.36%    | 37.070mb        | 37.069mb   | +0.00%      |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 989.600μs (±0.00%) | 959.700μs (±0.00%) | +3.12%    | 33.762mb        | 33.762mb   | 0.00%       |
| benchLoad10000Events ()                | 50.202ms (±0.00%)  | 50.211ms (±0.00%)  | -0.02%    | 33.762mb        | 33.762mb   | 0.00%       |
| benchSave1Event ()                     | 1.227ms (±0.00%)   | 1.024ms (±0.00%)   | +19.91%   | 33.762mb        | 33.762mb   | 0.00%       |
| benchSave10000Events ()                | 220.601ms (±0.00%) | 222.695ms (±0.00%) | -0.94%    | 33.764mb        | 33.764mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.297s (±0.00%)    | 8.409s (±0.00%)    | -1.32%    | 33.762mb        | 33.762mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 6.983s (±0.00%)    | 6.955s (±0.00%)    | +0.41%    | 33.763mb        | 33.763mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 51.342ms (±0.00%)  | 50.765ms (±0.00%)  | +1.14%    | 33.763mb        | 33.763mb   | 0.00%       |
| benchLoad10000Events ()                | 924.300μs (±0.00%) | 895.600μs (±0.00%) | +3.20%    | 33.763mb        | 33.763mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 877.400μs (±0.00%) | 869.800μs (±0.00%) | +0.87%    | 34.892mb        | 34.892mb   | 0.00%       |
| benchLoad10000Events ()                | 88.626ms (±0.00%)  | 82.425ms (±0.00%)  | +7.52%    | 34.892mb        | 34.892mb   | 0.00%       |
| benchSave1Event ()                     | 1.476ms (±0.00%)   | 1.423ms (±0.00%)   | +3.70%    | 34.892mb        | 34.892mb   | 0.00%       |
| benchSave10000Events ()                | 254.017ms (±0.00%) | 246.180ms (±0.00%) | +3.18%    | 34.894mb        | 34.894mb   | 0.00%       |
| benchSave10000Aggregates ()            | 12.433s (±0.00%)   | 12.282s (±0.00%)   | +1.23%    | 34.892mb        | 34.892mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 11.127s (±0.00%)   | 11.053s (±0.00%)   | +0.68%    | 35.394mb        | 35.394mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.134s (±0.00%) | 3.134s (±0.00%) | +0.01%    | 34.162mb        | 34.162mb   | 0.00%       |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants