Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infer aggregate id normalizer #612

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

DavidBadura
Copy link
Member

No description provided.

@DavidBadura DavidBadura added the enhancement New feature or request label Jul 9, 2024
@DavidBadura DavidBadura added this to the 3.2.0 milestone Jul 9, 2024
@DavidBadura DavidBadura requested a review from DanielBadura July 9, 2024 09:11
Copy link

github-actions bot commented Jul 9, 2024

Hello 👋

here is the most recent benchmark result:

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 886.200μs (±0.00%) | 829.100μs (±0.00%) | +6.89%    | 35.395mb        | 35.403mb   | -0.02%      |
| benchLoad10000Events ()                | 81.894ms (±0.00%)  | 83.184ms (±0.00%)  | -1.55%    | 35.395mb        | 34.893mb   | +1.44%      |
| benchSave1Event ()                     | 1.385ms (±0.00%)   | 1.340ms (±0.00%)   | +3.36%    | 34.893mb        | 34.893mb   | 0.00%       |
| benchSave10000Events ()                | 240.444ms (±0.00%) | 248.887ms (±0.00%) | -3.39%    | 34.895mb        | 34.895mb   | 0.00%       |
| benchSave10000Aggregates ()            | 11.608s (±0.00%)   | 12.169s (±0.00%)   | -4.61%    | 34.893mb        | 34.893mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 8.749s (±0.00%)    | 8.723s (±0.00%)    | +0.30%    | 35.393mb        | 35.393mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.042s (±0.00%) | 3.049s (±0.00%) | -0.24%    | 34.162mb        | 34.162mb   | 0.00%       |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 4.643ms (±0.00%)   | 4.836ms (±0.00%)   | -3.99%    | 37.070mb        | 37.070mb   | 0.00%       |
| benchSave10000Events () | 336.835ms (±0.00%) | 338.390ms (±0.00%) | -0.46%    | 37.072mb        | 37.072mb   | 0.00%       |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 969.100μs (±0.00%) | 940.100μs (±0.00%) | +3.08%    | 33.763mb        | 33.763mb   | 0.00%       |
| benchLoad10000Events ()                | 49.444ms (±0.00%)  | 51.436ms (±0.00%)  | -3.87%    | 33.763mb        | 33.763mb   | 0.00%       |
| benchSave1Event ()                     | 1.140ms (±0.00%)   | 910.400μs (±0.00%) | +25.20%   | 33.763mb        | 33.763mb   | 0.00%       |
| benchSave10000Events ()                | 213.750ms (±0.00%) | 216.366ms (±0.00%) | -1.21%    | 33.763mb        | 33.763mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.595s (±0.00%)    | 7.099s (±0.00%)    | +21.08%   | 33.763mb        | 33.763mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 4.712s (±0.00%)    | 4.713s (±0.00%)    | -0.01%    | 33.763mb        | 33.763mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 50.024ms (±0.00%)  | 50.870ms (±0.00%)  | -1.66%    | 33.764mb        | 33.764mb   | 0.00%       |
| benchLoad10000Events ()                | 932.200μs (±0.00%) | 897.500μs (±0.00%) | +3.87%    | 33.764mb        | 33.764mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

@DanielBadura
Copy link
Member

Regarding deptrac: would say this should be added to baseline. We already have there some issues regarding attributes.

@DavidBadura DavidBadura force-pushed the infer-aggregate-id-normalizer branch from fa058b6 to 72a4e48 Compare July 9, 2024 11:55
@DavidBadura DavidBadura force-pushed the infer-aggregate-id-normalizer branch from 72a4e48 to 3cd1048 Compare July 9, 2024 11:57
@DavidBadura DavidBadura merged commit a87ed93 into 3.2.x Jul 9, 2024
37 checks passed
@DavidBadura DavidBadura deleted the infer-aggregate-id-normalizer branch July 9, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants