Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix child aggregates with snapshots #630

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

DavidBadura
Copy link
Member

No description provided.

@DavidBadura DavidBadura added the bug Something isn't working label Sep 3, 2024
@DavidBadura DavidBadura added this to the 3.4.0 milestone Sep 3, 2024
@DavidBadura DavidBadura changed the title add attributes for snapshots on child aggregates & update tests fix child aggregates with snapshots Sep 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

Hello 👋

here is the most recent benchmark result:

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 5.406ms (±0.00%)   | 5.044ms (±0.00%)   | +7.18%    | 37.573mb        | 37.581mb   | -0.02%      |
| benchSave10000Events () | 367.154ms (±0.00%) | 369.918ms (±0.00%) | -0.75%    | 37.645mb        | 37.658mb   | -0.03%      |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 946.400μs (±0.00%) | 1.065ms (±0.00%)   | -11.15%   | 34.744mb        | 34.744mb   | +0.00%      |
| benchLoad10000Events ()                | 48.109ms (±0.00%)  | 48.160ms (±0.00%)  | -0.11%    | 34.744mb        | 34.744mb   | +0.00%      |
| benchSave1Event ()                     | 989.700μs (±0.00%) | 1.010ms (±0.00%)   | -2.02%    | 34.744mb        | 34.744mb   | +0.00%      |
| benchSave10000Events ()                | 235.350ms (±0.00%) | 220.433ms (±0.00%) | +6.77%    | 34.744mb        | 34.744mb   | +0.00%      |
| benchSave10000Aggregates ()            | 8.214s (±0.00%)    | 8.717s (±0.00%)    | -5.77%    | 34.744mb        | 34.744mb   | +0.00%      |
| benchSave10000AggregatesTransaction () | 4.758s (±0.00%)    | 4.704s (±0.00%)    | +1.15%    | 34.744mb        | 34.744mb   | +0.00%      |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 931.900μs (±0.00%) | 915.100μs (±0.00%) | +1.84%    | 34.895mb        | 34.895mb   | +0.00%      |
| benchLoad10000Events ()                | 86.814ms (±0.00%)  | 85.002ms (±0.00%)  | +2.13%    | 34.895mb        | 34.895mb   | +0.00%      |
| benchSave1Event ()                     | 1.678ms (±0.00%)   | 1.593ms (±0.00%)   | +5.32%    | 34.895mb        | 34.895mb   | +0.00%      |
| benchSave10000Events ()                | 263.357ms (±0.00%) | 259.385ms (±0.00%) | +1.53%    | 34.896mb        | 34.896mb   | +0.00%      |
| benchSave10000Aggregates ()            | 12.195s (±0.00%)   | 12.532s (±0.00%)   | -2.69%    | 34.895mb        | 34.895mb   | +0.00%      |
| benchSave10000AggregatesTransaction () | 8.701s (±0.00%)    | 8.786s (±0.00%)    | -0.97%    | 35.396mb        | 35.396mb   | +0.00%      |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.055s (±0.00%) | 3.044s (±0.00%) | +0.36%    | 34.233mb        | 34.233mb   | +0.00%      |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 976.200μs (±0.00%) | 1.119ms (±0.00%)   | -12.72%   | 33.765mb        | 33.765mb   | +0.00%      |
| benchLoad10000Events ()                | 52.027ms (±0.00%)  | 51.459ms (±0.00%)  | +1.10%    | 33.765mb        | 33.765mb   | +0.00%      |
| benchSave1Event ()                     | 1.143ms (±0.00%)   | 1.154ms (±0.00%)   | -0.92%    | 33.765mb        | 33.765mb   | +0.00%      |
| benchSave10000Events ()                | 230.969ms (±0.00%) | 236.657ms (±0.00%) | -2.40%    | 33.765mb        | 33.765mb   | +0.00%      |
| benchSave10000Aggregates ()            | 8.299s (±0.00%)    | 8.846s (±0.00%)    | -6.18%    | 33.765mb        | 33.765mb   | +0.00%      |
| benchSave10000AggregatesTransaction () | 4.728s (±0.00%)    | 4.726s (±0.00%)    | +0.03%    | 33.765mb        | 33.765mb   | +0.00%      |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 51.745ms (±0.00%)  | 51.501ms (±0.00%)  | +0.47%    | 33.765mb        | 33.765mb   | +0.00%      |
| benchLoad10000Events ()                | 888.700μs (±0.00%) | 981.900μs (±0.00%) | -9.49%    | 33.765mb        | 33.765mb   | +0.00%      |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura requested review from DanielBadura and removed request for DanielBadura September 6, 2024 10:03
@DanielBadura DanielBadura merged commit b3cc806 into 3.4.x Sep 18, 2024
38 of 39 checks passed
@DanielBadura DanielBadura deleted the fix-child-aggregates-with-snapshots branch September 18, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants