diff --git a/packages/react-codemods/transforms/pf3-pf4.button.test.js b/packages/react-codemods/transforms/pf3-pf4.button.test.js index a4b04757af1..14879f24bec 100644 --- a/packages/react-codemods/transforms/pf3-pf4.button.test.js +++ b/packages/react-codemods/transforms/pf3-pf4.button.test.js @@ -1,4 +1,3 @@ -import { EOL as SYSTEM_EOL } from 'os'; import prettier from 'prettier'; import { defineInlineTest } from 'jscodeshift/dist/testUtils'; import transform from './pf3-pf4'; diff --git a/packages/react-codemods/transforms/pf3-pf4.js b/packages/react-codemods/transforms/pf3-pf4.js index 22c5b820cee..942e0a0be21 100644 --- a/packages/react-codemods/transforms/pf3-pf4.js +++ b/packages/react-codemods/transforms/pf3-pf4.js @@ -1,4 +1,4 @@ -/* eslint-disable no-console */ +/* eslint-disable no-console,jsdoc/require-jsdoc */ const colors = require('colors'); const componentConfigs = require('../componentConfig'); diff --git a/packages/react-codemods/transforms/pf3-pf4.test.js b/packages/react-codemods/transforms/pf3-pf4.test.js index 1f305e2ba19..b879360dd3c 100644 --- a/packages/react-codemods/transforms/pf3-pf4.test.js +++ b/packages/react-codemods/transforms/pf3-pf4.test.js @@ -1,4 +1,3 @@ -import { EOL as SYSTEM_EOL } from 'os'; import prettier from 'prettier'; import { defineInlineTest, runInlineTest } from 'jscodeshift/dist/testUtils'; import transform from './pf3-pf4'; diff --git a/packages/react-core/src/components/AboutModal/AboutModal.tsx b/packages/react-core/src/components/AboutModal/AboutModal.tsx index acd11cfff74..29c8a57a7cb 100644 --- a/packages/react-core/src/components/AboutModal/AboutModal.tsx +++ b/packages/react-core/src/components/AboutModal/AboutModal.tsx @@ -2,7 +2,7 @@ import * as React from 'react'; import * as ReactDOM from 'react-dom'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/Backdrop/backdrop'; -import { canUseDOM } from 'exenv'; +import { canUseDOM } from '../../helpers'; import { KEY_CODES } from '../../helpers/constants'; import { AboutModalContainer } from './AboutModalContainer'; import { PickOptional } from '../../helpers/typeUtils'; diff --git a/packages/react-core/src/components/AlertGroup/AlertGroup.tsx b/packages/react-core/src/components/AlertGroup/AlertGroup.tsx index 1a0839d86ea..f4a48e321bb 100644 --- a/packages/react-core/src/components/AlertGroup/AlertGroup.tsx +++ b/packages/react-core/src/components/AlertGroup/AlertGroup.tsx @@ -1,6 +1,6 @@ import * as React from 'react'; import * as ReactDOM from 'react-dom'; -import { canUseDOM } from 'exenv'; +import { canUseDOM } from '../../helpers'; import { Omit } from '../../helpers/typeUtils'; import { AlertGroupInline } from './AlertGroupInline'; diff --git a/packages/react-core/src/components/DataList/DataList.tsx b/packages/react-core/src/components/DataList/DataList.tsx index aebf6758fe6..6439d6b653b 100644 --- a/packages/react-core/src/components/DataList/DataList.tsx +++ b/packages/react-core/src/components/DataList/DataList.tsx @@ -1,5 +1,4 @@ import * as React from 'react'; -import { isUndefined } from 'lodash'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/DataList/data-list'; @@ -38,7 +37,7 @@ export const DataList: React.FunctionComponent = ({ isCompact = false, ...props }: DataListProps) => { - const isSelectable = !isUndefined(onSelectDataListItem); + const isSelectable = onSelectDataListItem !== undefined; const updateSelectedDataListItem = (id: string) => { onSelectDataListItem(id); diff --git a/packages/react-core/src/components/DataToolbar/DataToolbar.tsx b/packages/react-core/src/components/DataToolbar/DataToolbar.tsx index b8b76d1daf6..d90e7c04987 100644 --- a/packages/react-core/src/components/DataToolbar/DataToolbar.tsx +++ b/packages/react-core/src/components/DataToolbar/DataToolbar.tsx @@ -1,5 +1,4 @@ import * as React from 'react'; -import { sum, values } from 'lodash'; import styles from '@patternfly/react-styles/css/components/DataToolbar/data-toolbar'; import { css } from '@patternfly/react-styles'; import { DataToolbarContext } from './DataToolbarUtils'; @@ -91,7 +90,7 @@ export class DataToolbar extends React.Component sum(values(this.state.filterInfo)); + getNumberOfFilters = () => Object.values(this.state.filterInfo).reduce((acc, cur) => acc + cur, 0); render() { const { diff --git a/packages/react-core/src/components/Modal/Modal.tsx b/packages/react-core/src/components/Modal/Modal.tsx index 00427055c2e..09fdccfc281 100644 --- a/packages/react-core/src/components/Modal/Modal.tsx +++ b/packages/react-core/src/components/Modal/Modal.tsx @@ -1,6 +1,6 @@ import * as React from 'react'; import * as ReactDOM from 'react-dom'; -import { canUseDOM } from 'exenv'; +import { canUseDOM } from '../../helpers'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/Backdrop/backdrop'; diff --git a/packages/react-core/src/components/Tabs/Tab.tsx b/packages/react-core/src/components/Tabs/Tab.tsx index aca5294a085..1625f7a3200 100644 --- a/packages/react-core/src/components/Tabs/Tab.tsx +++ b/packages/react-core/src/components/Tabs/Tab.tsx @@ -18,4 +18,4 @@ export interface TabProps extends Omit; } -export const Tab: React.FunctionComponent = ({ className = '' }: TabProps) => null; +export const Tab: React.FunctionComponent = (_props: TabProps) => null; diff --git a/packages/react-core/src/components/Wizard/Wizard.tsx b/packages/react-core/src/components/Wizard/Wizard.tsx index c711201ed0e..051aad76017 100644 --- a/packages/react-core/src/components/Wizard/Wizard.tsx +++ b/packages/react-core/src/components/Wizard/Wizard.tsx @@ -1,6 +1,6 @@ import * as React from 'react'; import * as ReactDOM from 'react-dom'; -import { canUseDOM } from 'exenv'; +import { canUseDOM } from '../../helpers'; import { KEY_CODES } from '../../helpers/constants'; import { css } from '@patternfly/react-styles'; import styles from '@patternfly/react-styles/css/components/Wizard/wizard'; diff --git a/packages/react-core/src/components/withOuia/withOuia.tsx b/packages/react-core/src/components/withOuia/withOuia.tsx index 4721736b70d..2808a47c9a8 100644 --- a/packages/react-core/src/components/withOuia/withOuia.tsx +++ b/packages/react-core/src/components/withOuia/withOuia.tsx @@ -1,6 +1,5 @@ import * as React from 'react'; import { isOUIAEnvironment, getUniqueId, generateOUIAId } from './ouia'; -import { Omit } from '../../helpers/typeUtils'; export const OuiaContext = React.createContext(null); diff --git a/packages/react-core/src/helpers/safeHTMLElement.js b/packages/react-core/src/helpers/safeHTMLElement.js index 9f7aed3808e..1c26646dbba 100644 --- a/packages/react-core/src/helpers/safeHTMLElement.js +++ b/packages/react-core/src/helpers/safeHTMLElement.js @@ -1,4 +1,4 @@ // https://github.com/reactjs/react-modal/blob/master/src/helpers/safeHTMLElement.js -import { canUseDOM } from 'exenv'; +import { canUseDOM } from './util'; export default canUseDOM ? window.HTMLElement : {}; diff --git a/packages/react-core/src/helpers/util.ts b/packages/react-core/src/helpers/util.ts index 2631b4f6583..24a27b9eb58 100644 --- a/packages/react-core/src/helpers/util.ts +++ b/packages/react-core/src/helpers/util.ts @@ -247,3 +247,5 @@ export const formatBreakpointMods = ( `${acc}${acc && ' '}${getModifier(styles, `${curr.modifier}${curr.breakpoint ? `-on-${curr.breakpoint}` : ''}`)}`, '' ); + +export const canUseDOM = !!(typeof window !== 'undefined' && window.document && window.document.createElement); diff --git a/packages/react-icons/src/createIcon.js b/packages/react-icons/src/createIcon.js index 6d059c8bdd7..40b9042e170 100644 --- a/packages/react-icons/src/createIcon.js +++ b/packages/react-icons/src/createIcon.js @@ -19,6 +19,7 @@ const createIcon = iconDefinition => { id = `icon-title-${currentId++}`; render() { + // eslint-disable-next-line @typescript-eslint/no-unused-vars const { size, color, title, noStyle, noVerticalAlign, ...props } = this.props; const hasTitle = Boolean(title);