Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/main/scala/com/paulgoldbaum/influxdbclient/Database.scala
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package com.paulgoldbaum.influxdbclient

import com.paulgoldbaum.influxdbclient.Parameter.Consistency.Consistency
import com.paulgoldbaum.influxdbclient.Parameter.Precision.Precision
import com.paulgoldbaum.influxdbclient.implicits.ToPointSyntax

import scala.concurrent.{ExecutionContext, Future}

Expand All @@ -12,12 +13,12 @@ class Database protected[influxdbclient]
with RetentionPolicyManagement
with DatabaseManagement
{
def write(point: Point,
def write[A](point: A,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have concern about keeping binary compatibility. @paulgoldbaum do you have any thoughts ?

precision: Precision = null,
consistency: Consistency = null,
retentionPolicy: String = null): Future[Boolean] =
retentionPolicy: String = null)(implicit toPoint: ToPoint[A]): Future[Boolean] =
{
executeWrite(point.serialize(), precision, consistency, retentionPolicy)
executeWrite(point.toPoint.serialize(), precision, consistency, retentionPolicy)
}

def bulkWrite(points: Seq[Point],
Expand Down
17 changes: 17 additions & 0 deletions src/main/scala/com/paulgoldbaum/influxdbclient/ToPoint.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
package com.paulgoldbaum.influxdbclient

trait ToPoint[-A] {

def convert(value: A): Point

}

object ToPoint {

implicit object PointToPoint extends ToPoint[Point]{

override def convert(value: Point): Point = value

}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package com.paulgoldbaum.influxdbclient

package object implicits {

implicit class ToPointSyntax[A](val value: A) extends AnyVal {

def toPoint(implicit toPoint: ToPoint[A]): Point = toPoint.convert(value)

}

implicit def anyToPoint[A](value: A)(implicit toPoint: ToPoint[A]): Point =
toPoint.convert(value)

}
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,12 @@ class DatabaseSuite extends CustomTestSuite with BeforeAndAfter {
assert(result.series.length == 1)
}

test("A point can be written using ToPoint type class") {
await(database.write(Metric(123, "tag_value")))
val result = await(database.query("SELECT * FROM test_measurement WHERE tag_key='tag_value'"))
assert(result.series.length == 1)
}

test("A point can be written and read with a precision parameter") {
val time = 1444760421270l
await(
Expand Down
16 changes: 16 additions & 0 deletions src/test/scala/com/paulgoldbaum/influxdbclient/Metric.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
package com.paulgoldbaum.influxdbclient

/**
* Class used for testing purposes.
*/
case class Metric(value: Int, tag: String)

object Metric {
implicit val metricToPoint: ToPoint[Metric] = new ToPoint[Metric] {
override def convert(m: Metric): Point =
Point("test_measurement")
.addField("value", m.value)
.addTag("tag_key", m.tag)
}

}