From d15bd0f27404a81ec564ec4886df3b3d44a6b59a Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Fri, 22 Dec 2023 14:47:39 -0800 Subject: [PATCH] chore: render only react child --- .../playwright-ct-react/registerSource.mjs | 3 +- .../playwright-ct-react17/registerSource.mjs | 3 +- .../playwright.ct-react.spec.ts | 34 +++++++++++++++++++ 3 files changed, 38 insertions(+), 2 deletions(-) diff --git a/packages/playwright-ct-react/registerSource.mjs b/packages/playwright-ct-react/registerSource.mjs index 6ac6b8372d74b..e8c2d6ca68145 100644 --- a/packages/playwright-ct-react/registerSource.mjs +++ b/packages/playwright-ct-react/registerSource.mjs @@ -96,7 +96,8 @@ function __pwRender(component) { return !!child.trim(); return true; }); - return __pwReact.createElement(componentFunc || component.type, component.props, children); + const reactChildren = Array.isArray(children) && children.length === 1 ? children[0] : children; + return __pwReact.createElement(componentFunc || component.type, component.props, reactChildren); } window.playwrightMount = async (component, rootElement, hooksConfig) => { diff --git a/packages/playwright-ct-react17/registerSource.mjs b/packages/playwright-ct-react17/registerSource.mjs index e6f89db935998..d0d6f2c37faa3 100644 --- a/packages/playwright-ct-react17/registerSource.mjs +++ b/packages/playwright-ct-react17/registerSource.mjs @@ -95,7 +95,8 @@ function __pwRender(component) { return !!child.trim(); return true; }); - return __pwReact.createElement(componentFunc || component.type, component.props, children); + const reactChildren = Array.isArray(children) && children.length === 1 ? children[0] : children; + return __pwReact.createElement(componentFunc || component.type, component.props, reactChildren); } window.playwrightMount = async (component, rootElement, hooksConfig) => { diff --git a/tests/playwright-test/playwright.ct-react.spec.ts b/tests/playwright-test/playwright.ct-react.spec.ts index 4eb6821007fb4..52572e413249c 100644 --- a/tests/playwright-test/playwright.ct-react.spec.ts +++ b/tests/playwright-test/playwright.ct-react.spec.ts @@ -461,3 +461,37 @@ test('should prioritize the vite host config over the baseUrl config', async ({ expect(result.exitCode).toBe(0); expect(result.passed).toBe(1); }); + +test('should normalize children', async ({ runInlineTest }) => { + const result = await runInlineTest({ + 'playwright.config.ts': playwrightConfig, + 'playwright/index.html': ``, + 'playwright/index.ts': ``, + 'src/component.tsx': ` + import React from 'react'; + export const OneChild: React.FC> = ({ children }) => { + React.Children.only(children); + return <>{children}; + }; + export const OtherComponent: React.FC = () =>

othercomponent

; + `, + + 'src/component.spec.tsx': ` + import { test, expect } from '@playwright/experimental-ct-react'; + import { OneChild, OtherComponent } from './component'; + + test("can pass an HTML element to OneChild", async ({ mount }) => { + const component = await mount(

child

); + await expect(component).toHaveText("child"); + }); + + test("can pass another component to OneChild", async ({ mount }) => { + const component = await mount(); + await expect(component).toHaveText("othercomponent"); + }); + `, + }, { workers: 1 }); + + expect(result.exitCode).toBe(0); + expect(result.passed).toBe(2); +});