diff --git a/.editorconfig b/.editorconfig index ec4c8e83e63..d970f16e796 100644 --- a/.editorconfig +++ b/.editorconfig @@ -19,3 +19,7 @@ indent_size = 2 [*.mdx] indent_style = space indent_size = 2 + +[*.json] +indent_style = space +indent_size = 2 diff --git a/.eslintignore b/.eslintignore new file mode 100644 index 00000000000..247f3f12de1 --- /dev/null +++ b/.eslintignore @@ -0,0 +1,10 @@ +.tmp +**/.git +**/.hg +**/.pnp.* +**/.svn +**/.yarn/** +**/build +**/dist/** +**/node_modules +**/temp diff --git a/.eslintrc.cjs b/.eslintrc.cjs new file mode 100644 index 00000000000..b4f0c7e20ee --- /dev/null +++ b/.eslintrc.cjs @@ -0,0 +1,16 @@ +module.exports = { + extends: ['@payloadcms'], + overrides: [ + { + extends: ['plugin:@typescript-eslint/disable-type-checked'], + files: ['*.js', '*.cjs'], + }, + { + files: ['packages/eslint-config-payload/**'], + rules: { + 'perfectionist/sort-objects': 'off', + }, + }, + ], + root: true, +} diff --git a/.eslintrc.js b/.eslintrc.js deleted file mode 100644 index 47d4a492ee8..00000000000 --- a/.eslintrc.js +++ /dev/null @@ -1,104 +0,0 @@ -module.exports = { - parser: '@typescript-eslint/parser', - parserOptions: { - ecmaVersion: 2020, - sourceType: 'module', - ecmaFeatures: { - jsx: true, - }, - }, - plugins: [ - '@typescript-eslint', - ], - extends: [ - './eslint-config', - ], - settings: { - 'import/resolver': { - node: { - extensions: ['.js', '.jsx', '.ts', '.tsx'], - }, - }, - }, - overrides: [ - { - files: ['test/**/int.spec.ts'], - rules: { - '@typescript-eslint/no-use-before-define': 'off', - '@typescript-eslint/consistent-type-imports': 'warn', - 'jest/prefer-strict-equal': 'off', - } - }, - { - files: ['test/**/e2e.spec.ts'], - extends: [ - 'plugin:playwright/playwright-test' - ], - rules: { - 'jest/consistent-test-it': 'off', - 'jest/require-top-level-describe': 'off', - 'jest/no-test-callback': 'off', - 'jest/prefer-strict-equal': 'off', - 'jest/expect-expect': 'off', - 'jest-dom/prefer-to-have-attribute': 'off', - } - }, - { - files: ['*.ts', '*.tsx'], - parser: '@typescript-eslint/parser', - extends: [ - 'plugin:@typescript-eslint/recommended', - ], - rules: { - 'no-shadow': 'off', - '@typescript-eslint/no-shadow': ['error'], - 'import/no-unresolved': [ - 2, - { - ignore: [ - 'payload-config', - 'payload/generated-types', - ], - }, - ], - }, - }, - { - files: ['*.spec.ts'], - rules: { - '@typescript-eslint/no-use-before-define': 'off', - }, - }, - { - files: ['*.e2e.ts'], - rules: { - '@typescript-eslint/no-use-before-define': 'off', - 'jest/expect-expect': 'off', - }, - }, - ], - rules: { - 'import/no-extraneous-dependencies': ['error', { packageDir: './' }], - 'react/jsx-filename-extension': [2, { extensions: ['.js', '.jsx', '.ts', '.tsx'] }], - 'import/prefer-default-export': 'off', - 'react/prop-types': 'off', - 'react/require-default-props': 'off', - 'react/no-unused-prop-types': 'off', - 'no-console': 'warn', - 'no-sparse-arrays': 'off', - 'no-underscore-dangle': 'off', - 'no-use-before-define': 'off', - 'arrow-body-style': 0, - '@typescript-eslint/no-use-before-define': 'off', - 'import/extensions': [ - 'error', - 'ignorePackages', - { - js: 'never', - jsx: 'never', - ts: 'never', - tsx: 'never', - }, - ], - }, -}; diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 8aae68da5f9..43c4ca6bebd 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -4,14 +4,14 @@ on: pull_request: types: [opened, reopened, synchronize] push: - branches: ["master"] + branches: ['master', '2.0'] jobs: - build_pnpm: + install_and_build_pnpm: runs-on: ubuntu-latest strategy: matrix: - node-version: [16.x, 18.x] + node-version: [16.x, 18.x, 20.x] steps: - uses: actions/checkout@v2 @@ -20,7 +20,7 @@ jobs: with: node-version: ${{ matrix.node-version }} registry-url: https://registry.npmjs.org - scope: "@payloadcms" + scope: '@payloadcms' always-auth: true - uses: pnpm/action-setup@v2 name: Install pnpm @@ -47,12 +47,18 @@ jobs: run: pnpm install env: NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} - - run: pnpm build + - run: pnpm --filter payload build - name: Component Tests - run: pnpm test:components + run: pnpm --filter payload run test:components + + - name: Install Playwright Browsers + run: npx playwright install --with-deps + - name: E2E Tests + run: pnpm --filter payload test:e2e --bail + - name: Integration Tests - run: pnpm test:int + run: pnpm --filter payload run test:int - name: Generate Payload Types run: pnpm dev:generate-types fields @@ -60,42 +66,9 @@ jobs: - name: Generate GraphQL schema file run: pnpm dev:generate-graphql-schema graphql-schema-gen - - name: Install Playwright Browsers - run: npx playwright install --with-deps - - name: E2E Tests - run: pnpm test:e2e --bail - - uses: actions/upload-artifact@v3 if: always() with: name: test-results path: test-results/ retention-days: 30 - - install_npm: - runs-on: ubuntu-latest - strategy: - matrix: - node-version: [16.x] - - steps: - - uses: actions/checkout@v2 - - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v1 - with: - node-version: ${{ matrix.node-version }} - registry-url: https://registry.npmjs.org - scope: "@payloadcms" - always-auth: true - - name: Cache node modules - uses: actions/cache@v1 - with: - path: ~/.npm - key: ${{ runner.os }}-node-npm-${{ hashFiles('**/package-lock.json') }} - restore-keys: | - ${{ runner.os }}-npm-${{ env.cache-name }}- - ${{ runner.os }}-npm- - ${{ runner.os }}- - - run: npm install - env: - NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }} \ No newline at end of file diff --git a/.node-version b/.node-version index 6276cf12fb1..860cc5000ae 100644 --- a/.node-version +++ b/.node-version @@ -1 +1 @@ -v16.14.2 +v18.17.1 diff --git a/.nvmrc b/.nvmrc index 6276cf12fb1..860cc5000ae 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -v16.14.2 +v18.17.1 diff --git a/.prettierignore b/.prettierignore new file mode 100644 index 00000000000..247f3f12de1 --- /dev/null +++ b/.prettierignore @@ -0,0 +1,10 @@ +.tmp +**/.git +**/.hg +**/.pnp.* +**/.svn +**/.yarn/** +**/build +**/dist/** +**/node_modules +**/temp diff --git a/.prettierrc.json b/.prettierrc.json new file mode 100644 index 00000000000..cb8ee2671df --- /dev/null +++ b/.prettierrc.json @@ -0,0 +1,6 @@ +{ + "singleQuote": true, + "trailingComma": "all", + "printWidth": 100, + "semi": false +} diff --git a/.vscode/extensions.json b/.vscode/extensions.json new file mode 100644 index 00000000000..d7df89c9cd0 --- /dev/null +++ b/.vscode/extensions.json @@ -0,0 +1,3 @@ +{ + "recommendations": ["esbenp.prettier-vscode", "dbaeumer.vscode-eslint"] +} diff --git a/eslint-config/configs/base/index.js b/eslint-config/configs/base/index.js deleted file mode 100644 index 742bd1d0095..00000000000 --- a/eslint-config/configs/base/index.js +++ /dev/null @@ -1,17 +0,0 @@ -module.exports = { - plugins: [ - 'node', - ], - env: { - node: true, - }, - extends: [ - './rules/best-practices', - './rules/errors', - './rules/es6', - './rules/imports', - './rules/style', - './rules/variables', - ].map(require.resolve), - rules: {}, -}; diff --git a/eslint-config/configs/base/rules/best-practices.js b/eslint-config/configs/base/rules/best-practices.js deleted file mode 100644 index 9b76b7aa5c6..00000000000 --- a/eslint-config/configs/base/rules/best-practices.js +++ /dev/null @@ -1,356 +0,0 @@ -module.exports = { - rules: { - // enforces getter/setter pairs in objects - 'accessor-pairs': 'off', - - // enforces return statements in callbacks of array's methods - // https://eslint.org/docs/rules/array-callback-return - 'array-callback-return': ['error', { allowImplicit: true }], - - // treat var statements as if they were block scoped - 'block-scoped-var': 'error', - - // specify the maximum cyclomatic complexity allowed in a program - complexity: ['off', 11], - - // enforce that class methods use "this" - // https://eslint.org/docs/rules/class-methods-use-this - 'class-methods-use-this': ['error', { - exceptMethods: [], - }], - - // require return statements to either always or never specify values - 'consistent-return': 'error', - - // specify curly brace conventions for all control statements - curly: ['error', 'multi-line'], // multiline - - // require default case in switch statements - 'default-case': ['error', { commentPattern: '^no default$' }], - - // https://eslint.org/docs/rules/default-param-last - // TODO: enable, semver-minor, when eslint v6.4 is required (which is a major) - 'default-param-last': 'off', - - // encourages use of dot notation whenever possible - 'dot-notation': ['error', { allowKeywords: true }], - - // enforces consistent newlines before or after dots - // https://eslint.org/docs/rules/dot-location - 'dot-location': ['error', 'property'], - - // require the use of === and !== - // https://eslint.org/docs/rules/eqeqeq - eqeqeq: ['error', 'always', { null: 'ignore' }], - - // Require grouped accessor pairs in object literals and classes - // https://eslint.org/docs/rules/grouped-accessor-pairs - // TODO: enable in next major, altho the guide forbids getters/setters anyways - 'grouped-accessor-pairs': 'off', - - // make sure for-in loops have an if statement - 'guard-for-in': 'error', - - // enforce a maximum number of classes per file - // https://eslint.org/docs/rules/max-classes-per-file - 'max-classes-per-file': ['error', 1], - - // disallow the use of alert, confirm, and prompt - 'no-alert': 'warn', - - // disallow use of arguments.caller or arguments.callee - 'no-caller': 'error', - - // disallow lexical declarations in case/default clauses - // https://eslint.org/docs/rules/no-case-declarations.html - 'no-case-declarations': 'error', - - // Disallow returning value in constructor - // https://eslint.org/docs/rules/no-constructor-return - // TODO: enable, semver-major - 'no-constructor-return': 'off', - - // disallow division operators explicitly at beginning of regular expression - // https://eslint.org/docs/rules/no-div-regex - 'no-div-regex': 'off', - - // disallow else after a return in an if - // https://eslint.org/docs/rules/no-else-return - 'no-else-return': ['error', { allowElseIf: false }], - - // disallow empty functions, except for standalone funcs/arrows - // https://eslint.org/docs/rules/no-empty-function - 'no-empty-function': ['error', { - allow: [ - 'arrowFunctions', - 'functions', - 'methods', - ], - }], - - // disallow empty destructuring patterns - // https://eslint.org/docs/rules/no-empty-pattern - 'no-empty-pattern': 'error', - - // disallow comparisons to null without a type-checking operator - 'no-eq-null': 'off', - - // disallow use of eval() - 'no-eval': 'error', - - // disallow adding to native types - 'no-extend-native': 'error', - - // disallow unnecessary function binding - 'no-extra-bind': 'error', - - // disallow Unnecessary Labels - // https://eslint.org/docs/rules/no-extra-label - 'no-extra-label': 'error', - - // disallow fallthrough of case statements - 'no-fallthrough': 'error', - - // disallow the use of leading or trailing decimal points in numeric literals - 'no-floating-decimal': 'error', - - // disallow reassignments of native objects or read-only globals - // https://eslint.org/docs/rules/no-global-assign - 'no-global-assign': ['error', { exceptions: [] }], - // deprecated in favor of no-global-assign - 'no-native-reassign': 'off', - - // disallow implicit type conversions - // https://eslint.org/docs/rules/no-implicit-coercion - 'no-implicit-coercion': ['off', { - boolean: false, - number: true, - string: true, - allow: [], - }], - - // disallow var and named functions in global scope - // https://eslint.org/docs/rules/no-implicit-globals - 'no-implicit-globals': 'off', - - // disallow use of eval()-like methods - 'no-implied-eval': 'error', - - // disallow this keywords outside of classes or class-like objects - 'no-invalid-this': 'off', - - // disallow usage of __iterator__ property - 'no-iterator': 'error', - - // disallow use of labels for anything other then loops and switches - 'no-labels': ['error', { allowLoop: false, allowSwitch: false }], - - // disallow unnecessary nested blocks - 'no-lone-blocks': 'error', - - // disallow creation of functions within loops - 'no-loop-func': 'error', - - // disallow magic numbers - // https://eslint.org/docs/rules/no-magic-numbers - 'no-magic-numbers': ['off', { - ignore: [], - ignoreArrayIndexes: true, - enforceConst: true, - detectObjects: false, - }], - - // disallow use of multiple spaces - 'no-multi-spaces': ['error', { - ignoreEOLComments: false, - }], - - // disallow use of multiline strings - 'no-multi-str': 'error', - - // disallow use of new operator when not part of the assignment or comparison - 'no-new': 'error', - - // disallow use of new operator for Function object - 'no-new-func': 'error', - - // disallows creating new instances of String, Number, and Boolean - 'no-new-wrappers': 'error', - - // disallow use of (old style) octal literals - 'no-octal': 'error', - - // disallow use of octal escape sequences in string literals, such as - // var foo = 'Copyright \251'; - 'no-octal-escape': 'error', - - // disallow reassignment of function parameters - // disallow parameter object manipulation except for specific exclusions - // rule: https://eslint.org/docs/rules/no-param-reassign.html - 'no-param-reassign': ['error', { - props: true, - ignorePropertyModificationsFor: [ - 'acc', // for reduce accumulators - 'accumulator', // for reduce accumulators - 'e', // for e.returnvalue - 'ctx', // for Koa routing - 'req', // for Express requests - 'request', // for Express requests - 'res', // for Express responses - 'response', // for Express responses - '$scope', // for Angular 1 scopes - 'staticContext', // for ReactRouter context - ], - }], - - // disallow usage of __proto__ property - 'no-proto': 'error', - - // disallow declaring the same variable more then once - 'no-redeclare': 'error', - - // disallow certain object properties - // https://eslint.org/docs/rules/no-restricted-properties - 'no-restricted-properties': ['error', - { - object: 'arguments', - property: 'callee', - message: 'arguments.callee is deprecated', - }, { - object: 'global', - property: 'isFinite', - message: 'Please use Number.isFinite instead', - }, { - object: 'self', - property: 'isFinite', - message: 'Please use Number.isFinite instead', - }, { - object: 'window', - property: 'isFinite', - message: 'Please use Number.isFinite instead', - }, { - object: 'global', - property: 'isNaN', - message: 'Please use Number.isNaN instead', - }, { - object: 'self', - property: 'isNaN', - message: 'Please use Number.isNaN instead', - }, { - object: 'window', - property: 'isNaN', - message: 'Please use Number.isNaN instead', - }, { - property: '__defineGetter__', - message: 'Please use Object.defineProperty instead.', - }, { - property: '__defineSetter__', - message: 'Please use Object.defineProperty instead.', - }, { - object: 'Math', - property: 'pow', - message: 'Use the exponentiation operator (**) instead.', - }], - - // disallow use of assignment in return statement - 'no-return-assign': ['error', 'always'], - - // disallow redundant `return await` - 'no-return-await': 'error', - - // disallow use of `javascript:` urls. - 'no-script-url': 'error', - - // disallow self assignment - // https://eslint.org/docs/rules/no-self-assign - 'no-self-assign': ['error', { - props: true, - }], - - // disallow comparisons where both sides are exactly the same - 'no-self-compare': 'error', - - // disallow use of comma operator - 'no-sequences': 'error', - - // restrict what can be thrown as an exception - 'no-throw-literal': 'error', - - // disallow unmodified conditions of loops - // https://eslint.org/docs/rules/no-unmodified-loop-condition - 'no-unmodified-loop-condition': 'off', - - // disallow usage of expressions in statement position - 'no-unused-expressions': ['error', { - allowShortCircuit: false, - allowTernary: false, - allowTaggedTemplates: false, - }], - - // disallow unused labels - // https://eslint.org/docs/rules/no-unused-labels - 'no-unused-labels': 'error', - - // disallow unnecessary .call() and .apply() - 'no-useless-call': 'off', - - // Disallow unnecessary catch clauses - // https://eslint.org/docs/rules/no-useless-catch - 'no-useless-catch': 'error', - - // disallow useless string concatenation - // https://eslint.org/docs/rules/no-useless-concat - 'no-useless-concat': 'error', - - // disallow unnecessary string escaping - // https://eslint.org/docs/rules/no-useless-escape - 'no-useless-escape': 'error', - - // disallow redundant return; keywords - // https://eslint.org/docs/rules/no-useless-return - 'no-useless-return': 'error', - - // disallow use of void operator - // https://eslint.org/docs/rules/no-void - 'no-void': 'error', - - // disallow usage of configurable warning terms in comments: e.g. todo - 'no-warning-comments': ['off', { terms: ['todo', 'fixme', 'xxx'], location: 'start' }], - - // disallow use of the with statement - 'no-with': 'error', - - // require using Error objects as Promise rejection reasons - // https://eslint.org/docs/rules/prefer-promise-reject-errors - 'prefer-promise-reject-errors': ['error', { allowEmptyReject: true }], - - // Suggest using named capture group in regular expression - // https://eslint.org/docs/rules/prefer-named-capture-group - 'prefer-named-capture-group': 'off', - - // https://eslint.org/docs/rules/prefer-regex-literals - // TODO; enable, semver-minor, once eslint v6.4 is required (which is a major) - 'prefer-regex-literals': 'off', - - // require use of the second argument for parseInt() - radix: 'error', - - // require `await` in `async function` (note: this is a horrible rule that should never be used) - // https://eslint.org/docs/rules/require-await - 'require-await': 'off', - - // Enforce the use of u flag on RegExp - // https://eslint.org/docs/rules/require-unicode-regexp - 'require-unicode-regexp': 'off', - - // requires to declare all vars on top of their containing scope - 'vars-on-top': 'error', - - // require immediate function invocation to be wrapped in parentheses - // https://eslint.org/docs/rules/wrap-iife.html - 'wrap-iife': ['error', 'outside', { functionPrototypeMethods: false }], - - // require or disallow Yoda conditions - yoda: 'error', - }, -}; diff --git a/eslint-config/configs/base/rules/errors.js b/eslint-config/configs/base/rules/errors.js deleted file mode 100644 index 8ca3a1cffe8..00000000000 --- a/eslint-config/configs/base/rules/errors.js +++ /dev/null @@ -1,154 +0,0 @@ -module.exports = { - rules: { - // Enforce “for” loop update clause moving the counter in the right direction - // https://eslint.org/docs/rules/for-direction - 'for-direction': 'error', - - // Enforces that a return statement is present in property getters - // https://eslint.org/docs/rules/getter-return - 'getter-return': ['error', { allowImplicit: true }], - - // disallow using an async function as a Promise executor - // https://eslint.org/docs/rules/no-async-promise-executor - 'no-async-promise-executor': 'error', - - // Disallow await inside of loops - // https://eslint.org/docs/rules/no-await-in-loop - 'no-await-in-loop': 'error', - - // Disallow comparisons to negative zero - // https://eslint.org/docs/rules/no-compare-neg-zero - 'no-compare-neg-zero': 'error', - - // disallow assignment in conditional expressions - 'no-cond-assign': ['error', 'always'], - - // disallow use of console - 'no-console': ['warn', { allow: ['warn', 'error'] }], - - // disallow use of constant expressions in conditions - 'no-constant-condition': 'warn', - - // disallow control characters in regular expressions - 'no-control-regex': 'error', - - // disallow use of debugger - 'no-debugger': 'error', - - // disallow duplicate arguments in functions - 'no-dupe-args': 'error', - - // Disallow duplicate conditions in if-else-if chains - // https://eslint.org/docs/rules/no-dupe-else-if - // TODO: enable, semver-major - 'no-dupe-else-if': 'off', - - // disallow duplicate keys when creating object literals - 'no-dupe-keys': 'error', - - // disallow a duplicate case label. - 'no-duplicate-case': 'error', - - // disallow empty statements - 'no-empty': 'error', - - // disallow the use of empty character classes in regular expressions - 'no-empty-character-class': 'error', - - // disallow assigning to the exception in a catch block - 'no-ex-assign': 'error', - - // disallow double-negation boolean casts in a boolean context - // https://eslint.org/docs/rules/no-extra-boolean-cast - 'no-extra-boolean-cast': 'error', - - // disallow unnecessary parentheses - // https://eslint.org/docs/rules/no-extra-parens - 'no-extra-parens': ['off', 'all', { - conditionalAssign: true, - nestedBinaryExpressions: false, - returnAssign: false, - ignoreJSX: 'all', // delegate to eslint-plugin-react - enforceForArrowConditionals: false, - }], - - // disallow unnecessary semicolons - 'no-extra-semi': 'error', - - // disallow overwriting functions written as function declarations - 'no-func-assign': 'error', - - // https://eslint.org/docs/rules/no-import-assign - // TODO: enable, semver-minor, once eslint v6.4 is required (which is a major) - 'no-import-assign': 'off', - - // disallow function or variable declarations in nested blocks - 'no-inner-declarations': 'error', - - // disallow invalid regular expression strings in the RegExp constructor - 'no-invalid-regexp': 'error', - - // disallow irregular whitespace outside of strings and comments - 'no-irregular-whitespace': 'error', - - // Disallow characters which are made with multiple code points in character class syntax - // https://eslint.org/docs/rules/no-misleading-character-class - 'no-misleading-character-class': 'error', - - // disallow the use of object properties of the global object (Math and JSON) as functions - 'no-obj-calls': 'error', - - // disallow use of Object.prototypes builtins directly - // https://eslint.org/docs/rules/no-prototype-builtins - 'no-prototype-builtins': 'error', - - // disallow multiple spaces in a regular expression literal - 'no-regex-spaces': 'error', - - // Disallow returning values from setters - // https://eslint.org/docs/rules/no-setter-return - // TODO: enable, semver-major (altho the guide forbids getters/setters already) - 'no-setter-return': 'off', - - // disallow sparse arrays - 'no-sparse-arrays': 'error', - - // Disallow template literal placeholder syntax in regular strings - // https://eslint.org/docs/rules/no-template-curly-in-string - 'no-template-curly-in-string': 'error', - - // Avoid code that looks like two expressions but is actually one - // https://eslint.org/docs/rules/no-unexpected-multiline - 'no-unexpected-multiline': 'error', - - // disallow unreachable statements after a return, throw, continue, or break statement - 'no-unreachable': 'error', - - // disallow return/throw/break/continue inside finally blocks - // https://eslint.org/docs/rules/no-unsafe-finally - 'no-unsafe-finally': 'error', - - // disallow negating the left operand of relational operators - // https://eslint.org/docs/rules/no-unsafe-negation - 'no-unsafe-negation': 'error', - // disallow negation of the left operand of an in expression - // deprecated in favor of no-unsafe-negation - 'no-negated-in-lhs': 'off', - - // Disallow assignments that can lead to race conditions due to usage of await or yield - // https://eslint.org/docs/rules/require-atomic-updates - // TODO: enable, semver-major - 'require-atomic-updates': 'off', - - // disallow comparisons with the value NaN - 'use-isnan': 'error', - - // ensure JSDoc comments are valid - // https://eslint.org/docs/rules/valid-jsdoc - 'valid-jsdoc': 'off', - - // ensure that the results of typeof are compared against a valid string - // https://eslint.org/docs/rules/valid-typeof - 'valid-typeof': ['error', { requireStringLiterals: true }], - }, -}; diff --git a/eslint-config/configs/base/rules/es6.js b/eslint-config/configs/base/rules/es6.js deleted file mode 100644 index c27ca1d64ac..00000000000 --- a/eslint-config/configs/base/rules/es6.js +++ /dev/null @@ -1,176 +0,0 @@ -module.exports = { - env: { - es6: true, - }, - parserOptions: { - ecmaVersion: 6, - sourceType: 'module', - ecmaFeatures: { - generators: false, - objectLiteralDuplicateProperties: false, - }, - }, - rules: { - // enforces no braces where they can be omitted - // https://eslint.org/docs/rules/arrow-body-style - 'arrow-body-style': ['error', 'as-needed', { - requireReturnForObjectLiteral: false, - }], - - // require parens in arrow function arguments - // https://eslint.org/docs/rules/arrow-parens - 'arrow-parens': ['error', 'always'], - - // require space before/after arrow function's arrow - // https://eslint.org/docs/rules/arrow-spacing - 'arrow-spacing': ['error', { before: true, after: true }], - - // verify super() callings in constructors - 'constructor-super': 'error', - - // enforce the spacing around the * in generator functions - // https://eslint.org/docs/rules/generator-star-spacing - 'generator-star-spacing': ['error', { before: false, after: true }], - - // disallow modifying variables of class declarations - // https://eslint.org/docs/rules/no-class-assign - 'no-class-assign': 'error', - - // disallow arrow functions where they could be confused with comparisons - // https://eslint.org/docs/rules/no-confusing-arrow - 'no-confusing-arrow': ['error', { - allowParens: true, - }], - - // disallow modifying variables that are declared using const - 'no-const-assign': 'error', - - // disallow duplicate class members - // https://eslint.org/docs/rules/no-dupe-class-members - 'no-dupe-class-members': 'error', - - // disallow importing from the same path more than once - // https://eslint.org/docs/rules/no-duplicate-imports - // replaced by https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-duplicates.md - 'no-duplicate-imports': 'off', - - // disallow symbol constructor - // https://eslint.org/docs/rules/no-new-symbol - 'no-new-symbol': 'error', - - // disallow specific imports - // https://eslint.org/docs/rules/no-restricted-imports - 'no-restricted-imports': ['off', { - paths: [], - patterns: [], - }], - - // disallow to use this/super before super() calling in constructors. - // https://eslint.org/docs/rules/no-this-before-super - 'no-this-before-super': 'error', - - // disallow useless computed property keys - // https://eslint.org/docs/rules/no-useless-computed-key - 'no-useless-computed-key': 'error', - - // disallow unnecessary constructor - // https://eslint.org/docs/rules/no-useless-constructor - 'no-useless-constructor': 'error', - - // disallow renaming import, export, and destructured assignments to the same name - // https://eslint.org/docs/rules/no-useless-rename - 'no-useless-rename': ['error', { - ignoreDestructuring: false, - ignoreImport: false, - ignoreExport: false, - }], - - // require let or const instead of var - 'no-var': 'error', - - // require method and property shorthand syntax for object literals - // https://eslint.org/docs/rules/object-shorthand - 'object-shorthand': ['error', 'always', { - ignoreConstructors: false, - avoidQuotes: true, - }], - - // suggest using arrow functions as callbacks - 'prefer-arrow-callback': ['error', { - allowNamedFunctions: false, - allowUnboundThis: true, - }], - - // suggest using of const declaration for variables that are never modified after declared - 'prefer-const': ['error', { - destructuring: 'any', - ignoreReadBeforeAssign: true, - }], - - // Prefer destructuring from arrays and objects - // https://eslint.org/docs/rules/prefer-destructuring - 'prefer-destructuring': ['error', - { - VariableDeclarator: { - array: false, - object: true, - }, - AssignmentExpression: { - array: true, - object: false, - }, - }, { - enforceForRenamedProperties: false, - }, - ], - - // disallow parseInt() in favor of binary, octal, and hexadecimal literals - // https://eslint.org/docs/rules/prefer-numeric-literals - 'prefer-numeric-literals': 'error', - - // suggest using Reflect methods where applicable - // https://eslint.org/docs/rules/prefer-reflect - 'prefer-reflect': 'off', - - // use rest parameters instead of arguments - // https://eslint.org/docs/rules/prefer-rest-params - 'prefer-rest-params': 'error', - - // suggest using the spread operator instead of .apply() - // https://eslint.org/docs/rules/prefer-spread - 'prefer-spread': 'error', - - // suggest using template literals instead of string concatenation - // https://eslint.org/docs/rules/prefer-template - 'prefer-template': 'error', - - // disallow generator functions that do not have yield - // https://eslint.org/docs/rules/require-yield - 'require-yield': 'error', - - // enforce spacing between object rest-spread - // https://eslint.org/docs/rules/rest-spread-spacing - 'rest-spread-spacing': ['error', 'never'], - - // import sorting - // https://eslint.org/docs/rules/sort-imports - 'sort-imports': ['off', { - ignoreCase: false, - ignoreDeclarationSort: false, - ignoreMemberSort: false, - memberSyntaxSortOrder: ['none', 'all', 'multiple', 'single'], - }], - - // require a Symbol description - // https://eslint.org/docs/rules/symbol-description - 'symbol-description': 'error', - - // enforce usage of spacing in template strings - // https://eslint.org/docs/rules/template-curly-spacing - 'template-curly-spacing': 'error', - - // enforce spacing around the * in yield* expressions - // https://eslint.org/docs/rules/yield-star-spacing - 'yield-star-spacing': ['error', 'after'], - }, -}; diff --git a/eslint-config/configs/base/rules/imports.js b/eslint-config/configs/base/rules/imports.js deleted file mode 100644 index 287c91f049b..00000000000 --- a/eslint-config/configs/base/rules/imports.js +++ /dev/null @@ -1,234 +0,0 @@ -module.exports = { - env: { - es6: true, - }, - parserOptions: { - ecmaVersion: 6, - sourceType: 'module', - }, - plugins: [ - 'import', - ], - settings: { - 'import/resolver': { - node: { - extensions: ['.mjs', '.js', '.json'], - }, - }, - 'import/extensions': [ - '.js', - '.mjs', - '.jsx', - ], - 'import/core-modules': [], - 'import/ignore': [ - 'node_modules', - '\\.(coffee|scss|css|less|hbs|svg|json)$', - ], - }, - rules: { - // Static analysis: - - // ensure imports point to files/modules that can be resolved - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-unresolved.md - 'import/no-unresolved': ['error', { commonjs: true, caseSensitive: true }], - - // ensure named imports coupled with named exports - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/named.md#when-not-to-use-it - 'import/named': 'error', - - // ensure default import coupled with default export - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/default.md#when-not-to-use-it - 'import/default': 'off', - - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/namespace.md - 'import/namespace': 'off', - - // Helpful warnings: - - // disallow invalid exports, e.g. multiple defaults - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/export.md - 'import/export': 'error', - - // do not allow a default import name to match a named export - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-named-as-default.md - 'import/no-named-as-default': 'error', - - // warn on accessing default export property names that are also named exports - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-named-as-default-member.md - 'import/no-named-as-default-member': 'error', - - // disallow use of jsdoc-marked-deprecated imports - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-deprecated.md - 'import/no-deprecated': 'off', - - // Forbid the use of extraneous packages - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-extraneous-dependencies.md - // paths are treated both as absolute paths, and relative to process.cwd() - 'import/no-extraneous-dependencies': ['error'], - - // Forbid mutable exports - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-mutable-exports.md - 'import/no-mutable-exports': 'error', - - // Module systems: - - // disallow require() - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-commonjs.md - 'import/no-commonjs': 'off', - - // disallow AMD require/define - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-amd.md - 'import/no-amd': 'error', - - // No Node.js builtin modules - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-nodejs-modules.md - // TODO: enable? - 'import/no-nodejs-modules': 'off', - - // Style guide: - - // disallow non-import statements appearing before import statements - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/first.md - 'import/first': 'error', - - // disallow non-import statements appearing before import statements - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/imports-first.md - // deprecated: use `import/first` - 'import/imports-first': 'off', - - // disallow duplicate imports - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-duplicates.md - 'import/no-duplicates': 'error', - - // disallow namespace imports - // TODO: enable? - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-namespace.md - 'import/no-namespace': 'off', - - // Ensure consistent use of file extension within the import path - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/extensions.md - 'import/extensions': ['error', 'ignorePackages', { - js: 'never', - mjs: 'never', - jsx: 'never', - }], - - // ensure absolute imports are above relative imports and that unassigned imports are ignored - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/order.md - // TODO: enforce a stricter convention in module import order? - 'import/order': ['error', { groups: [['builtin', 'external', 'internal']] }], - - // Require a newline after the last import/require in a group - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/newline-after-import.md - 'import/newline-after-import': 'error', - - // Require modules with a single export to use a default export - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/prefer-default-export.md - 'import/prefer-default-export': 'error', - - // Restrict which files can be imported in a given folder - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-restricted-paths.md - 'import/no-restricted-paths': 'off', - - // Forbid modules to have too many dependencies - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/max-dependencies.md - 'import/max-dependencies': ['off', { max: 10 }], - - // Forbid import of modules using absolute paths - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-absolute-path.md - 'import/no-absolute-path': 'error', - - // Forbid require() calls with expressions - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-dynamic-require.md - 'import/no-dynamic-require': 'error', - - // prevent importing the submodules of other modules - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-internal-modules.md - 'import/no-internal-modules': ['off', { - allow: [], - }], - - // Warn if a module could be mistakenly parsed as a script by a consumer - // leveraging Unambiguous JavaScript Grammar - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/unambiguous.md - // this should not be enabled until this proposal has at least been *presented* to TC39. - // At the moment, it's not a thing. - 'import/unambiguous': 'off', - - // Forbid Webpack loader syntax in imports - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-webpack-loader-syntax.md - 'import/no-webpack-loader-syntax': 'error', - - // Prevent unassigned imports - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-unassigned-import.md - // importing for side effects is perfectly acceptable, if you need side effects. - 'import/no-unassigned-import': 'off', - - // Prevent importing the default as if it were named - // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-named-default.md - 'import/no-named-default': 'error', - - // Reports if a module's default export is unnamed - // https://github.com/benmosher/eslint-plugin-import/blob/d9b712ac7fd1fddc391f7b234827925c160d956f/docs/rules/no-anonymous-default-export.md - 'import/no-anonymous-default-export': ['off', { - allowArray: false, - allowArrowFunction: false, - allowAnonymousClass: false, - allowAnonymousFunction: false, - allowLiteral: false, - allowObject: false, - }], - - // This rule enforces that all exports are declared at the bottom of the file. - // https://github.com/benmosher/eslint-plugin-import/blob/98acd6afd04dcb6920b81330114e146dc8532ea4/docs/rules/exports-last.md - // TODO: enable? - 'import/exports-last': 'off', - - // Reports when named exports are not grouped together in a single export declaration - // or when multiple assignments to CommonJS module.exports or exports object are present - // in a single file. - // https://github.com/benmosher/eslint-plugin-import/blob/44a038c06487964394b1e15b64f3bd34e5d40cde/docs/rules/group-exports.md - 'import/group-exports': 'off', - - // forbid default exports. this is a terrible rule, do not use it. - // https://github.com/benmosher/eslint-plugin-import/blob/44a038c06487964394b1e15b64f3bd34e5d40cde/docs/rules/no-default-export.md - 'import/no-default-export': 'off', - - // Prohibit named exports. this is a terrible rule, do not use it. - // https://github.com/benmosher/eslint-plugin-import/blob/1ec80fa35fa1819e2d35a70e68fb6a149fb57c5e/docs/rules/no-named-export.md - 'import/no-named-export': 'off', - - // Forbid a module from importing itself - // https://github.com/benmosher/eslint-plugin-import/blob/44a038c06487964394b1e15b64f3bd34e5d40cde/docs/rules/no-self-import.md - 'import/no-self-import': 'error', - - // Forbid cyclical dependencies between modules - // https://github.com/benmosher/eslint-plugin-import/blob/d81f48a2506182738409805f5272eff4d77c9348/docs/rules/no-cycle.md - 'import/no-cycle': ['error', { maxDepth: Infinity }], - - // Ensures that there are no useless path segments - // https://github.com/benmosher/eslint-plugin-import/blob/ebafcbf59ec9f653b2ac2a0156ca3bcba0a7cf57/docs/rules/no-useless-path-segments.md - 'import/no-useless-path-segments': ['error', { commonjs: true }], - - // dynamic imports require a leading comment with a webpackChunkName - // https://github.com/benmosher/eslint-plugin-import/blob/ebafcbf59ec9f653b2ac2a0156ca3bcba0a7cf57/docs/rules/dynamic-import-chunkname.md - 'import/dynamic-import-chunkname': ['off', { - importFunctions: [], - webpackChunknameFormat: '[0-9a-zA-Z-_/.]+', - }], - - // Use this rule to prevent imports to folders in relative parent paths. - // https://github.com/benmosher/eslint-plugin-import/blob/c34f14f67f077acd5a61b3da9c0b0de298d20059/docs/rules/no-relative-parent-imports.md - 'import/no-relative-parent-imports': 'off', - - // Reports modules without any exports, or with unused exports - // https://github.com/benmosher/eslint-plugin-import/blob/f63dd261809de6883b13b6b5b960e6d7f42a7813/docs/rules/no-unused-modules.md - // TODO: enable, semver-major - 'import/no-unused-modules': ['off', { - ignoreExports: [], - missingExports: true, - unusedExports: true, - }], - }, -}; diff --git a/eslint-config/configs/base/rules/style.js b/eslint-config/configs/base/rules/style.js deleted file mode 100644 index 49ffef4740f..00000000000 --- a/eslint-config/configs/base/rules/style.js +++ /dev/null @@ -1,525 +0,0 @@ -module.exports = { - rules: { - // enforce line breaks after opening and before closing array brackets - // https://eslint.org/docs/rules/array-bracket-newline - // TODO: enable? semver-major - 'array-bracket-newline': ['off', 'consistent'], // object option alternative: { multiline: true, minItems: 3 } - - // enforce line breaks between array elements - // https://eslint.org/docs/rules/array-element-newline - // TODO: enable? semver-major - 'array-element-newline': ['off', { multiline: true, minItems: 3 }], - - // enforce spacing inside array brackets - 'array-bracket-spacing': ['error', 'never'], - - // enforce spacing inside single-line blocks - // https://eslint.org/docs/rules/block-spacing - 'block-spacing': ['error', 'always'], - - // enforce one true brace style - 'brace-style': ['error', '1tbs', { allowSingleLine: true }], - - // require camel case names - camelcase: ['error', { properties: 'never', ignoreDestructuring: false }], - - // enforce or disallow capitalization of the first letter of a comment - // https://eslint.org/docs/rules/capitalized-comments - 'capitalized-comments': ['off', 'never', { - line: { - ignorePattern: '.*', - ignoreInlineComments: true, - ignoreConsecutiveComments: true, - }, - block: { - ignorePattern: '.*', - ignoreInlineComments: true, - ignoreConsecutiveComments: true, - }, - }], - - // require trailing commas in multiline object literals - 'comma-dangle': ['error', { - arrays: 'always-multiline', - objects: 'always-multiline', - imports: 'always-multiline', - exports: 'always-multiline', - functions: 'always-multiline', - }], - - // enforce spacing before and after comma - 'comma-spacing': ['error', { before: false, after: true }], - - // enforce one true comma style - 'comma-style': ['error', 'last', { - exceptions: { - ArrayExpression: false, - ArrayPattern: false, - ArrowFunctionExpression: false, - CallExpression: false, - FunctionDeclaration: false, - FunctionExpression: false, - ImportDeclaration: false, - ObjectExpression: false, - ObjectPattern: false, - VariableDeclaration: false, - NewExpression: false, - }, - }], - - // disallow padding inside computed properties - 'computed-property-spacing': ['error', 'never'], - - // enforces consistent naming when capturing the current execution context - 'consistent-this': 'off', - - // enforce newline at the end of file, with no multiple empty lines - 'eol-last': ['error', 'always'], - - // https://eslint.org/docs/rules/function-call-argument-newline - // TODO: enable, semver-minor, once eslint v6.2 is required (which is a major) - 'function-call-argument-newline': ['off', 'consistent'], - - // enforce spacing between functions and their invocations - // https://eslint.org/docs/rules/func-call-spacing - 'func-call-spacing': ['error', 'never'], - - // requires function names to match the name of the variable or property to which they are - // assigned - // https://eslint.org/docs/rules/func-name-matching - 'func-name-matching': ['off', 'always', { - includeCommonJSModuleExports: false, - considerPropertyDescriptor: true, - }], - - // require function expressions to have a name - // https://eslint.org/docs/rules/func-names - 'func-names': 'warn', - - // enforces use of function declarations or expressions - // https://eslint.org/docs/rules/func-style - // TODO: enable - 'func-style': ['off', 'expression'], - - // enforce consistent line breaks inside function parentheses - // https://eslint.org/docs/rules/function-paren-newline - 'function-paren-newline': ['error', 'consistent'], - - // Blacklist certain identifiers to prevent them being used - // https://eslint.org/docs/rules/id-blacklist - 'id-blacklist': 'off', - - // this option enforces minimum and maximum identifier lengths - // (variable names, property names etc.) - 'id-length': 'off', - - // require identifiers to match the provided regular expression - 'id-match': 'off', - - // Enforce the location of arrow function bodies with implicit returns - // https://eslint.org/docs/rules/implicit-arrow-linebreak - 'implicit-arrow-linebreak': ['error', 'beside'], - - // this option sets a specific tab width for your code - // https://eslint.org/docs/rules/indent - indent: ['error', 2, { - SwitchCase: 1, - VariableDeclarator: 1, - outerIIFEBody: 1, - // MemberExpression: null, - FunctionDeclaration: { - parameters: 1, - body: 1, - }, - FunctionExpression: { - parameters: 1, - body: 1, - }, - CallExpression: { - arguments: 1, - }, - ArrayExpression: 1, - ObjectExpression: 1, - ImportDeclaration: 1, - flatTernaryExpressions: false, - // list derived from https://github.com/benjamn/ast-types/blob/HEAD/def/jsx.js - ignoredNodes: ['JSXElement', 'JSXElement > *', 'JSXAttribute', 'JSXIdentifier', 'JSXNamespacedName', 'JSXMemberExpression', 'JSXSpreadAttribute', 'JSXExpressionContainer', 'JSXOpeningElement', 'JSXClosingElement', 'JSXText', 'JSXEmptyExpression', 'JSXSpreadChild'], - ignoreComments: false, - }], - - // specify whether double or single quotes should be used in JSX attributes - // https://eslint.org/docs/rules/jsx-quotes - 'jsx-quotes': ['off', 'prefer-double'], - - // enforces spacing between keys and values in object literal properties - 'key-spacing': ['error', { beforeColon: false, afterColon: true }], - - // require a space before & after certain keywords - 'keyword-spacing': ['error', { - before: true, - after: true, - overrides: { - return: { after: true }, - throw: { after: true }, - case: { after: true }, - }, - }], - - // enforce position of line comments - // https://eslint.org/docs/rules/line-comment-position - // TODO: enable? - 'line-comment-position': ['off', { - position: 'above', - ignorePattern: '', - applyDefaultPatterns: true, - }], - - // disallow mixed 'LF' and 'CRLF' as linebreaks - // https://eslint.org/docs/rules/linebreak-style - 'linebreak-style': ['error', 'unix'], - - // require or disallow an empty line between class members - // https://eslint.org/docs/rules/lines-between-class-members - 'lines-between-class-members': ['error', 'always', { exceptAfterSingleLine: false }], - - // enforces empty lines around comments - 'lines-around-comment': 'off', - - // require or disallow newlines around directives - // https://eslint.org/docs/rules/lines-around-directive - 'lines-around-directive': ['error', { - before: 'always', - after: 'always', - }], - - // specify the maximum depth that blocks can be nested - 'max-depth': ['off', 4], - - // specify the maximum length of a line in your program - // https://eslint.org/docs/rules/max-len - 'max-len': ['off'], - - // specify the max number of lines in a file - // https://eslint.org/docs/rules/max-lines - 'max-lines': ['off', { - max: 300, - skipBlankLines: true, - skipComments: true, - }], - - // enforce a maximum function length - // https://eslint.org/docs/rules/max-lines-per-function - 'max-lines-per-function': ['off', { - max: 50, - skipBlankLines: true, - skipComments: true, - IIFEs: true, - }], - - // specify the maximum depth callbacks can be nested - 'max-nested-callbacks': 'off', - - // limits the number of parameters that can be used in the function declaration. - 'max-params': ['off', 3], - - // specify the maximum number of statement allowed in a function - 'max-statements': ['off', 10], - - // restrict the number of statements per line - // https://eslint.org/docs/rules/max-statements-per-line - 'max-statements-per-line': ['off', { max: 1 }], - - // enforce a particular style for multiline comments - // https://eslint.org/docs/rules/multiline-comment-style - 'multiline-comment-style': ['off', 'starred-block'], - - // require multiline ternary - // https://eslint.org/docs/rules/multiline-ternary - // TODO: enable? - 'multiline-ternary': ['off', 'never'], - - // require a capital letter for constructors - 'new-cap': ['error', { - newIsCap: true, - newIsCapExceptions: [], - capIsNew: false, - capIsNewExceptions: ['Immutable.Map', 'Immutable.Set', 'Immutable.List'], - }], - - // disallow the omission of parentheses when invoking a constructor with no arguments - // https://eslint.org/docs/rules/new-parens - 'new-parens': 'error', - - // allow/disallow an empty newline after var statement - 'newline-after-var': 'off', - - // https://eslint.org/docs/rules/newline-before-return - 'newline-before-return': 'off', - - // enforces new line after each method call in the chain to make it - // more readable and easy to maintain - // https://eslint.org/docs/rules/newline-per-chained-call - 'newline-per-chained-call': ['error', { ignoreChainWithDepth: 4 }], - - // disallow use of the Array constructor - 'no-array-constructor': 'error', - - // disallow use of bitwise operators - // https://eslint.org/docs/rules/no-bitwise - 'no-bitwise': 'error', - - // disallow use of the continue statement - // https://eslint.org/docs/rules/no-continue - 'no-continue': 'error', - - // disallow comments inline after code - 'no-inline-comments': 'off', - - // disallow if as the only statement in an else block - // https://eslint.org/docs/rules/no-lonely-if - 'no-lonely-if': 'error', - - // disallow un-paren'd mixes of different operators - // https://eslint.org/docs/rules/no-mixed-operators - 'no-mixed-operators': ['error', { - // the list of arthmetic groups disallows mixing `%` and `**` - // with other arithmetic operators. - groups: [ - ['%', '**'], - ['%', '+'], - ['%', '-'], - ['%', '*'], - ['%', '/'], - ['/', '*'], - ['&', '|', '<<', '>>', '>>>'], - ['==', '!=', '===', '!=='], - ['&&', '||'], - ], - allowSamePrecedence: false, - }], - - // disallow mixed spaces and tabs for indentation - 'no-mixed-spaces-and-tabs': 'error', - - // disallow use of chained assignment expressions - // https://eslint.org/docs/rules/no-multi-assign - 'no-multi-assign': ['error'], - - // disallow multiple empty lines, only one newline at the end, and no new lines at the beginning - // https://eslint.org/docs/rules/no-multiple-empty-lines - 'no-multiple-empty-lines': ['error', { max: 2, maxBOF: 1, maxEOF: 0 }], - - // disallow negated conditions - // https://eslint.org/docs/rules/no-negated-condition - 'no-negated-condition': 'off', - - // disallow nested ternary expressions - 'no-nested-ternary': 'error', - - // disallow use of the Object constructor - 'no-new-object': 'error', - - // disallow use of unary operators, ++ and -- - // https://eslint.org/docs/rules/no-plusplus - 'no-plusplus': 'error', - - // disallow certain syntax forms - // https://eslint.org/docs/rules/no-restricted-syntax - 'no-restricted-syntax': [ - 'error', - { - selector: 'ForInStatement', - message: 'for..in loops iterate over the entire prototype chain, which is virtually never what you want. Use Object.{keys,values,entries}, and iterate over the resulting array.', - }, - { - selector: 'ForOfStatement', - message: 'iterators/generators require regenerator-runtime, which is too heavyweight for this guide to allow them. Separately, loops should be avoided in favor of array iterations.', - }, - { - selector: 'LabeledStatement', - message: 'Labels are a form of GOTO; using them makes code confusing and hard to maintain and understand.', - }, - { - selector: 'WithStatement', - message: '`with` is disallowed in strict mode because it makes code impossible to predict and optimize.', - }, - ], - - // disallow space between function identifier and application - 'no-spaced-func': 'error', - - // disallow tab characters entirely - 'no-tabs': 'error', - - // disallow the use of ternary operators - 'no-ternary': 'off', - - // disallow trailing whitespace at the end of lines - 'no-trailing-spaces': ['error', { - skipBlankLines: false, - ignoreComments: false, - }], - - // disallow dangling underscores in identifiers - // https://eslint.org/docs/rules/no-underscore-dangle - 'no-underscore-dangle': ['error', { - allow: [], - allowAfterThis: false, - allowAfterSuper: false, - enforceInMethodNames: true, - }], - - // disallow the use of Boolean literals in conditional expressions - // also, prefer `a || b` over `a ? a : b` - // https://eslint.org/docs/rules/no-unneeded-ternary - 'no-unneeded-ternary': ['error', { defaultAssignment: false }], - - // disallow whitespace before properties - // https://eslint.org/docs/rules/no-whitespace-before-property - 'no-whitespace-before-property': 'error', - - // enforce the location of single-line statements - // https://eslint.org/docs/rules/nonblock-statement-body-position - 'nonblock-statement-body-position': ['error', 'beside', { overrides: {} }], - - // require padding inside curly braces - 'object-curly-spacing': ['error', 'always'], - - // enforce line breaks between braces - // https://eslint.org/docs/rules/object-curly-newline - 'object-curly-newline': ['error', { - ObjectExpression: { multiline: true, consistent: true }, - ObjectPattern: { multiline: true, consistent: true }, - ImportDeclaration: { multiline: true, consistent: true }, - ExportDeclaration: { multiline: true, consistent: true }, - }], - - // enforce "same line" or "multiple line" on object properties. - // https://eslint.org/docs/rules/object-property-newline - 'object-property-newline': ['error', { - allowAllPropertiesOnSameLine: true, - }], - - // allow just one var statement per function - 'one-var': ['error', 'never'], - - // require a newline around variable declaration - // https://eslint.org/docs/rules/one-var-declaration-per-line - 'one-var-declaration-per-line': ['error', 'always'], - - // require assignment operator shorthand where possible or prohibit it entirely - // https://eslint.org/docs/rules/operator-assignment - 'operator-assignment': ['error', 'always'], - - // Requires operator at the beginning of the line in multiline statements - // https://eslint.org/docs/rules/operator-linebreak - 'operator-linebreak': ['error', 'before', { overrides: { '=': 'none' } }], - - // disallow padding within blocks - 'padded-blocks': ['error', - { - blocks: 'never', - classes: 'never', - switches: 'never', - }, - { - allowSingleLineBlocks: true, - }, - ], - - // Require or disallow padding lines between statements - // https://eslint.org/docs/rules/padding-line-between-statements - 'padding-line-between-statements': 'off', - - // Disallow the use of Math.pow in favor of the ** operator - // https://eslint.org/docs/rules/prefer-exponentiation-operator - // TODO: enable, semver-major when eslint 5 is dropped - 'prefer-exponentiation-operator': 'off', - - // Prefer use of an object spread over Object.assign - // https://eslint.org/docs/rules/prefer-object-spread - 'prefer-object-spread': 'error', - - // require quotes around object literal property names - // https://eslint.org/docs/rules/quote-props.html - 'quote-props': ['error', 'as-needed', { keywords: false, unnecessary: true, numbers: false }], - - // specify whether double or single quotes should be used - quotes: ['error', 'single', { avoidEscape: true }], - - // do not require jsdoc - // https://eslint.org/docs/rules/require-jsdoc - 'require-jsdoc': 'off', - - // require or disallow use of semicolons instead of ASI - semi: ['error', 'always'], - - // enforce spacing before and after semicolons - 'semi-spacing': ['error', { before: false, after: true }], - - // Enforce location of semicolons - // https://eslint.org/docs/rules/semi-style - 'semi-style': ['error', 'last'], - - // requires object keys to be sorted - 'sort-keys': ['off', 'asc', { caseSensitive: false, natural: true }], - - // sort variables within the same declaration block - 'sort-vars': 'off', - - // require or disallow space before blocks - 'space-before-blocks': 'error', - - // require or disallow space before function opening parenthesis - // https://eslint.org/docs/rules/space-before-function-paren - 'space-before-function-paren': ['error', { - anonymous: 'always', - named: 'never', - asyncArrow: 'always', - }], - - // require or disallow spaces inside parentheses - 'space-in-parens': ['error', 'never'], - - // require spaces around operators - 'space-infix-ops': 'error', - - // Require or disallow spaces before/after unary operators - // https://eslint.org/docs/rules/space-unary-ops - 'space-unary-ops': ['error', { - words: true, - nonwords: false, - overrides: { - }, - }], - - // require or disallow a space immediately following the // or /* in a comment - // https://eslint.org/docs/rules/spaced-comment - 'spaced-comment': ['error', 'always', { - line: { - exceptions: ['-', '+'], - markers: ['=', '!'], // space here to support sprockets directives - }, - block: { - exceptions: ['-', '+'], - markers: ['=', '!', ':', '::'], // space here to support sprockets directives and flow comment types - balanced: true, - }, - }], - - // Enforce spacing around colons of switch statements - // https://eslint.org/docs/rules/switch-colon-spacing - 'switch-colon-spacing': ['error', { after: true, before: false }], - - // Require or disallow spacing between template tags and their literals - // https://eslint.org/docs/rules/template-tag-spacing - 'template-tag-spacing': ['error', 'never'], - - // require or disallow the Unicode Byte Order Mark - // https://eslint.org/docs/rules/unicode-bom - 'unicode-bom': ['error', 'never'], - - // require regex literals to be wrapped in parentheses - 'wrap-regex': 'off', - }, -}; diff --git a/eslint-config/configs/base/rules/variables.js b/eslint-config/configs/base/rules/variables.js deleted file mode 100644 index 96408bd4137..00000000000 --- a/eslint-config/configs/base/rules/variables.js +++ /dev/null @@ -1,44 +0,0 @@ -const confusingBrowserGlobals = require('confusing-browser-globals'); - -module.exports = { - rules: { - // enforce or disallow variable initializations at definition - 'init-declarations': 'off', - - // disallow the catch clause parameter name being the same as a variable in the outer scope - 'no-catch-shadow': 'off', - - // disallow deletion of variables - 'no-delete-var': 'error', - - // disallow labels that share a name with a variable - // https://eslint.org/docs/rules/no-label-var - 'no-label-var': 'error', - - // disallow specific globals - 'no-restricted-globals': ['error', 'isFinite', 'isNaN'].concat(confusingBrowserGlobals), - - // disallow declaration of variables already declared in the outer scope - 'no-shadow': 'error', - - // disallow shadowing of names such as arguments - 'no-shadow-restricted-names': 'error', - - // disallow use of undeclared variables unless mentioned in a /*global */ block - 'no-undef': 'error', - - // disallow use of undefined when initializing variables - 'no-undef-init': 'error', - - // disallow use of undefined variable - // https://eslint.org/docs/rules/no-undefined - // TODO: enable? - 'no-undefined': 'off', - - // disallow declaration of variables that are not used in the code - 'no-unused-vars': ['error', { vars: 'all', args: 'after-used', ignoreRestSiblings: true }], - - // disallow use of variables before they are defined - 'no-use-before-define': ['error', { functions: true, classes: true, variables: true }], - }, -}; diff --git a/eslint-config/configs/react/rules/react-hooks.js b/eslint-config/configs/react/rules/react-hooks.js deleted file mode 100644 index 26ca87538a0..00000000000 --- a/eslint-config/configs/react/rules/react-hooks.js +++ /dev/null @@ -1,11 +0,0 @@ -module.exports = { - rules: { - // Enforce Rules of Hooks - // https://github.com/facebook/react/blob/c11015ff4f610ac2924d1fc6d569a17657a404fd/packages/eslint-plugin-react-hooks/src/RulesOfHooks.js - 'react-hooks/rules-of-hooks': 'error', - - // Verify the list of the dependencies for Hooks like useEffect and similar - // https://github.com/facebook/react/blob/1204c789776cb01fbaf3e9f032e7e2ba85a44137/packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js - 'react-hooks/exhaustive-deps': 'error', - }, -}; diff --git a/eslint-config/index.js b/eslint-config/index.js deleted file mode 100644 index efc05b0e8cb..00000000000 --- a/eslint-config/index.js +++ /dev/null @@ -1,8 +0,0 @@ -module.exports = { - extends: [ - './configs/base', - './configs/jest', - './configs/react', - ].map(require.resolve), - rules: {}, -}; diff --git a/package.json b/package.json index ab469b2b710..f84b43cff1a 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,7 @@ { - "name": "payload", - "version": "1.14.0", + "name": "payload-monorepo", + "private": true, + "version": "0.0.0", "description": "Node, React and MongoDB Headless CMS and Application Framework", "license": "MIT", "engines": { @@ -85,10 +86,16 @@ "react", "auth" ], - "dependencies": {}, + "dependencies": { + "turbo": "^1.10.13" + }, "devDependencies": { - "typescript": "5.2.2", - "@types/node": "20.5.6" + "@payloadcms/eslint-config": "workspace:*", + "@types/node": "20.5.7", + "copyfiles": "2.4.1", + "cross-env": "7.0.3", + "prettier": "^3.0.3", + "typescript": "5.2.2" }, "files": [ "bin.js", diff --git a/packages/db-mongodb/.eslintignore b/packages/db-mongodb/.eslintignore new file mode 100644 index 00000000000..247f3f12de1 --- /dev/null +++ b/packages/db-mongodb/.eslintignore @@ -0,0 +1,10 @@ +.tmp +**/.git +**/.hg +**/.pnp.* +**/.svn +**/.yarn/** +**/build +**/dist/** +**/node_modules +**/temp diff --git a/packages/db-mongodb/.eslintrc.cjs b/packages/db-mongodb/.eslintrc.cjs new file mode 100644 index 00000000000..6a2f2ade080 --- /dev/null +++ b/packages/db-mongodb/.eslintrc.cjs @@ -0,0 +1,15 @@ +/** @type {import('prettier').Config} */ +module.exports = { + extends: ['@payloadcms'], + overrides: [ + { + extends: ['plugin:@typescript-eslint/disable-type-checked'], + files: ['*.js', '*.cjs'], + }, + ], + parserOptions: { + project: ['./tsconfig.json'], + tsconfigRootDir: __dirname, + }, + root: true, +} diff --git a/packages/db-mongodb/.prettierignore b/packages/db-mongodb/.prettierignore new file mode 100644 index 00000000000..247f3f12de1 --- /dev/null +++ b/packages/db-mongodb/.prettierignore @@ -0,0 +1,10 @@ +.tmp +**/.git +**/.hg +**/.pnp.* +**/.svn +**/.yarn/** +**/build +**/dist/** +**/node_modules +**/temp diff --git a/packages/db-mongodb/package.json b/packages/db-mongodb/package.json index b4fc14ef75c..aa30200dd4a 100644 --- a/packages/db-mongodb/package.json +++ b/packages/db-mongodb/package.json @@ -36,7 +36,8 @@ "devDependencies": { "@types/mongoose-aggregate-paginate-v2": "1.0.9", "mongodb-memory-server": "8.13.0", - "payload": "workspace:*" + "payload": "workspace:*", + "@payloadcms/eslint-config": "workspace:*" }, "dependencies": { "bson-objectid": "2.0.4", diff --git a/packages/db-mongodb/tsconfig.json b/packages/db-mongodb/tsconfig.json index 46c69757baa..6f981e9dcff 100644 --- a/packages/db-mongodb/tsconfig.json +++ b/packages/db-mongodb/tsconfig.json @@ -1,9 +1,10 @@ { "compilerOptions": { + "target": "ES2019", "moduleResolution": "Node16", /* Required for exports to work */ "composite": true, "declaration": true, /* Generates corresponding '.d.ts' file. */ - "module": "CommonJS", /* Specify what module code is generated. */ + "module": "Node16", /* Specify what module code is generated. */ "rootDir": "./src", /* Specify the root folder within your source files. */ "outDir": "./dist", /* Specify an output folder for all emitted files. */ "esModuleInterop": true, /* Emit additional JavaScript to ease support for importing CommonJS modules. This enables 'allowSyntheticDefaultImports' for type compatibility. */ diff --git a/packages/db-postgres/.eslintignore b/packages/db-postgres/.eslintignore new file mode 100644 index 00000000000..247f3f12de1 --- /dev/null +++ b/packages/db-postgres/.eslintignore @@ -0,0 +1,10 @@ +.tmp +**/.git +**/.hg +**/.pnp.* +**/.svn +**/.yarn/** +**/build +**/dist/** +**/node_modules +**/temp diff --git a/packages/db-postgres/.eslintrc.cjs b/packages/db-postgres/.eslintrc.cjs new file mode 100644 index 00000000000..6a2f2ade080 --- /dev/null +++ b/packages/db-postgres/.eslintrc.cjs @@ -0,0 +1,15 @@ +/** @type {import('prettier').Config} */ +module.exports = { + extends: ['@payloadcms'], + overrides: [ + { + extends: ['plugin:@typescript-eslint/disable-type-checked'], + files: ['*.js', '*.cjs'], + }, + ], + parserOptions: { + project: ['./tsconfig.json'], + tsconfigRootDir: __dirname, + }, + root: true, +} diff --git a/packages/db-postgres/.prettierignore b/packages/db-postgres/.prettierignore new file mode 100644 index 00000000000..247f3f12de1 --- /dev/null +++ b/packages/db-postgres/.prettierignore @@ -0,0 +1,10 @@ +.tmp +**/.git +**/.hg +**/.pnp.* +**/.svn +**/.yarn/** +**/build +**/dist/** +**/node_modules +**/temp diff --git a/packages/db-postgres/package.json b/packages/db-postgres/package.json index 4e614e4bb3b..dc29235260f 100644 --- a/packages/db-postgres/package.json +++ b/packages/db-postgres/package.json @@ -48,6 +48,7 @@ "@types/pg": "8.10.2", "@types/to-snake-case": "1.0.0", "better-sqlite3": "^8.5.0", - "payload": "workspace:*" + "payload": "workspace:*", + "@payloadcms/eslint-config": "workspace:*" } } diff --git a/packages/db-postgres/tsconfig.json b/packages/db-postgres/tsconfig.json index 5242e45c8e1..6f981e9dcff 100644 --- a/packages/db-postgres/tsconfig.json +++ b/packages/db-postgres/tsconfig.json @@ -1,9 +1,10 @@ { "compilerOptions": { + "target": "ES2019", "moduleResolution": "Node16", /* Required for exports to work */ "composite": true, "declaration": true, /* Generates corresponding '.d.ts' file. */ - "module": "commonjs", /* Specify what module code is generated. */ + "module": "Node16", /* Specify what module code is generated. */ "rootDir": "./src", /* Specify the root folder within your source files. */ "outDir": "./dist", /* Specify an output folder for all emitted files. */ "esModuleInterop": true, /* Emit additional JavaScript to ease support for importing CommonJS modules. This enables 'allowSyntheticDefaultImports' for type compatibility. */ diff --git a/eslint-config/configs/jest/index.js b/packages/eslint-config-payload/eslint-config/configs/jest/index.cjs similarity index 74% rename from eslint-config/configs/jest/index.js rename to packages/eslint-config-payload/eslint-config/configs/jest/index.cjs index d2dc3a9af69..cdecdc751b3 100644 --- a/eslint-config/configs/jest/index.js +++ b/packages/eslint-config-payload/eslint-config/configs/jest/index.cjs @@ -7,8 +7,8 @@ module.exports = { 'jest-dom', ], extends: [ - './rules/jest', - './rules/jest-dom', + './rules/jest.cjs', + './rules/jest-dom.cjs', ].map(require.resolve), rules: {}, }; diff --git a/eslint-config/configs/jest/rules/jest-dom.js b/packages/eslint-config-payload/eslint-config/configs/jest/rules/jest-dom.cjs similarity index 100% rename from eslint-config/configs/jest/rules/jest-dom.js rename to packages/eslint-config-payload/eslint-config/configs/jest/rules/jest-dom.cjs diff --git a/eslint-config/configs/jest/rules/jest.js b/packages/eslint-config-payload/eslint-config/configs/jest/rules/jest.cjs similarity index 100% rename from eslint-config/configs/jest/rules/jest.js rename to packages/eslint-config-payload/eslint-config/configs/jest/rules/jest.cjs diff --git a/eslint-config/configs/react/index.js b/packages/eslint-config-payload/eslint-config/configs/react/index.cjs similarity index 80% rename from eslint-config/configs/react/index.js rename to packages/eslint-config-payload/eslint-config/configs/react/index.cjs index d753fcef8da..f80c46802c9 100644 --- a/eslint-config/configs/react/index.js +++ b/packages/eslint-config-payload/eslint-config/configs/react/index.cjs @@ -18,9 +18,8 @@ module.exports = { }, }, extends: [ - './rules/react-a11y', - './rules/react-hooks', - './rules/react', + './rules/react-a11y.cjs', + './rules/react.cjs', ].map(require.resolve), rules: {}, }; diff --git a/eslint-config/configs/react/rules/react-a11y.js b/packages/eslint-config-payload/eslint-config/configs/react/rules/react-a11y.cjs similarity index 98% rename from eslint-config/configs/react/rules/react-a11y.js rename to packages/eslint-config-payload/eslint-config/configs/react/rules/react-a11y.cjs index f5f83d6bbb0..915566cbaf4 100644 --- a/eslint-config/configs/react/rules/react-a11y.js +++ b/packages/eslint-config-payload/eslint-config/configs/react/rules/react-a11y.cjs @@ -1,3 +1,5 @@ +// Sourced from https://github.com/airbnb/javascript/blob/master/packages/eslint-config-airbnb/rules/react-a11y.js + module.exports = { rules: { // Enforce that anchors have content diff --git a/eslint-config/configs/react/rules/react.js b/packages/eslint-config-payload/eslint-config/configs/react/rules/react.cjs similarity index 100% rename from eslint-config/configs/react/rules/react.js rename to packages/eslint-config-payload/eslint-config/configs/react/rules/react.cjs diff --git a/packages/eslint-config-payload/eslint-config/index.cjs b/packages/eslint-config-payload/eslint-config/index.cjs new file mode 100644 index 00000000000..00079eea303 --- /dev/null +++ b/packages/eslint-config-payload/eslint-config/index.cjs @@ -0,0 +1,62 @@ +module.exports = { + env: { + es6: true, + browser: true, + node: true, + }, + extends: [ + 'eslint:recommended', + 'plugin:perfectionist/recommended-natural', + 'plugin:@typescript-eslint/recommended-type-checked', + 'plugin:regexp/recommended', + 'plugin:react/recommended', + 'plugin:react-hooks/recommended', + './configs/jest/index.cjs', + './configs/react/index.cjs', + 'prettier', + ], + parser: '@typescript-eslint/parser', + parserOptions: { + ecmaFeatures: { + jsx: true, + }, + ecmaVersion: 'latest', + sourceType: 'module', + }, + plugins: ['@typescript-eslint'], + overrides: [ + { + files: ['*.js', '*.cjs'], + extends: ['plugin:@typescript-eslint/disable-type-checked'], + }, + ], + rules: { + '@typescript-eslint/ban-ts-comment': 'off', + '@typescript-eslint/consistent-type-imports': 'warn', + '@typescript-eslint/no-explicit-any': 'warn', + // Type-aware any rules: + '@typescript-eslint/no-unsafe-assignment': 'off', + '@typescript-eslint/no-unsafe-member-access': 'off', + '@typescript-eslint/no-unsafe-call': 'off', + '@typescript-eslint/no-unsafe-argument': 'off', + '@typescript-eslint/no-unsafe-return': 'off', + // This rule doesn't work well in .tsx files + '@typescript-eslint/no-misused-promises': 'off', + // Type-aware any rules end + '@typescript-eslint/no-use-before-define': 'off', + 'arrow-body-style': 0, + 'import/prefer-default-export': 'off', + 'no-console': 'warn', + 'no-sparse-arrays': 'off', + 'no-underscore-dangle': 'off', + 'no-use-before-define': 'off', + 'react/no-unused-prop-types': 'off', + 'react/prop-types': 'off', + 'react/require-default-props': 'off', + }, + settings: { + 'import/parsers': { + '@typescript-eslint/parser': ['.ts', '.tsx'], + }, + }, +}; diff --git a/packages/eslint-config-payload/index.js b/packages/eslint-config-payload/index.js new file mode 100644 index 00000000000..8983c4cbdb1 --- /dev/null +++ b/packages/eslint-config-payload/index.js @@ -0,0 +1,4 @@ +module.exports = { + root: true, + extends: ['./eslint-config/index.cjs'], +}; diff --git a/packages/eslint-config-payload/package.json b/packages/eslint-config-payload/package.json new file mode 100644 index 00000000000..7ca7aab6ec2 --- /dev/null +++ b/packages/eslint-config-payload/package.json @@ -0,0 +1,31 @@ +{ + "name": "@payloadcms/eslint-config", + "version": "0.0.1", + "private": true, + "description": "Payload styles for ESLint and Prettier", + "main": "index.js", + "prettier": "./prettier", + "scripts": { + "test": "echo \"Error: no test specified\" && exit 1" + }, + "dependencies": { + "@types/eslint": "8.44.2", + "@typescript-eslint/eslint-plugin": "6.5.0", + "@typescript-eslint/parser": "6.5.0", + "eslint": "8.48.0", + "eslint-config-prettier": "^9.0.0", + "eslint-plugin-import": "2.28.1", + "eslint-plugin-jest": "27.2.3", + "eslint-plugin-jest-dom": "5.1.0", + "eslint-plugin-jsx-a11y": "6.7.1", + "eslint-plugin-node": "11.1.0", + "eslint-plugin-perfectionist": "^1.5.1", + "eslint-plugin-playwright": "0.16.0", + "eslint-plugin-react": "7.33.2", + "eslint-plugin-react-hooks": "4.6.0", + "eslint-plugin-regexp": "^1.15.0" + }, + "keywords": [], + "author": "", + "license": "MIT" +} diff --git a/packages/payload/.eslintignore b/packages/payload/.eslintignore new file mode 100644 index 00000000000..247f3f12de1 --- /dev/null +++ b/packages/payload/.eslintignore @@ -0,0 +1,10 @@ +.tmp +**/.git +**/.hg +**/.pnp.* +**/.svn +**/.yarn/** +**/build +**/dist/** +**/node_modules +**/temp diff --git a/packages/payload/.eslintrc.cjs b/packages/payload/.eslintrc.cjs new file mode 100644 index 00000000000..68efd14d725 --- /dev/null +++ b/packages/payload/.eslintrc.cjs @@ -0,0 +1,64 @@ +module.exports = { + extends: ['@payloadcms'], + ignorePatterns: ['**/payload-types.ts'], + overrides: [ + { + extends: ['plugin:@typescript-eslint/disable-type-checked'], + files: [ + '*.js', + '*.cjs', + 'playwright.config.ts', + 'playwright.bail.config.ts', + 'bin-cks.cjs', + 'bin-esm.mjs', + 'esm-loader.mjs', + 'esm-loader-playwright.mjs', + ], + }, + { + files: ['test/**/*.ts'], + rules: { + '@typescript-eslint/no-unsafe-assignment': 'off', + '@typescript-eslint/no-use-before-define': 'off', + // turn the @typescript-eslint/unbound-method rule off *only* for test files. See https://typescript-eslint.io/rules/unbound-method/#when-not-to-use-it + '@typescript-eslint/unbound-method': 'off', + 'perfectionist/sort-objects': 'off', + }, + }, + { + files: ['test/**/int.spec.ts'], + rules: { + '@typescript-eslint/no-unsafe-assignment': 'off', + '@typescript-eslint/no-use-before-define': 'off', + 'jest/prefer-strict-equal': 'off', + }, + }, + { + extends: ['plugin:playwright/playwright-test'], + files: ['test/**/e2e.spec.ts'], + rules: { + '@typescript-eslint/no-unsafe-assignment': 'off', + '@typescript-eslint/no-use-before-define': 'off', + 'jest/consistent-test-it': 'off', + 'jest/expect-expect': 'off', + 'jest/no-test-callback': 'off', + 'jest/prefer-strict-equal': 'off', + 'jest/require-top-level-describe': 'off', + 'jest-dom/prefer-to-have-attribute': 'off', + }, + }, + { + files: ['*.e2e.ts'], + rules: { + '@typescript-eslint/no-unsafe-assignment': 'off', + '@typescript-eslint/no-use-before-define': 'off', + 'jest/expect-expect': 'off', + }, + }, + ], + parserOptions: { + project: ['./tsconfig.json'], + tsconfigRootDir: __dirname, + }, + root: true, +} diff --git a/packages/payload/.prettierignore b/packages/payload/.prettierignore new file mode 100644 index 00000000000..247f3f12de1 --- /dev/null +++ b/packages/payload/.prettierignore @@ -0,0 +1,10 @@ +.tmp +**/.git +**/.hg +**/.pnp.* +**/.svn +**/.yarn/** +**/build +**/dist/** +**/node_modules +**/temp diff --git a/packages/payload/package.json b/packages/payload/package.json index c93a4d86739..9f6938e9482 100644 --- a/packages/payload/package.json +++ b/packages/payload/package.json @@ -238,12 +238,10 @@ "@swc/jest": "0.2.29", "@testing-library/jest-dom": "5.17.0", "@testing-library/react": "13.4.0", - "@trbl/eslint-config": "3.0.1", "@types/asap": "2.0.0", "@types/body-parser": "1.19.2", "@types/compression": "1.7.2", "@types/connect-history-api-fallback": "1.5.0", - "@types/eslint": "7.29.0", "@types/express": "4.17.17", "@types/express-fileupload": "1.4.1", "@types/express-rate-limit": "5.1.3", @@ -288,21 +286,10 @@ "@types/webpack-bundle-analyzer": "4.6.0", "@types/webpack-env": "1.18.1", "@types/webpack-hot-middleware": "2.25.6", - "@typescript-eslint/eslint-plugin": "5.62.0", - "@typescript-eslint/parser": "5.62.0", "better-sqlite3": "8.5.0", "confusing-browser-globals": "1.0.11", "copyfiles": "2.4.1", "cross-env": "7.0.3", - "eslint": "8.45.0", - "eslint-plugin-import": "2.27.5", - "eslint-plugin-jest": "27.2.3", - "eslint-plugin-jest-dom": "4.0.3", - "eslint-plugin-jsx-a11y": "6.7.1", - "eslint-plugin-node": "11.1.0", - "eslint-plugin-playwright": "0.12.0", - "eslint-plugin-react": "7.33.0", - "eslint-plugin-react-hooks": "4.6.0", "form-data": "3.0.1", "get-port": "5.1.1", "glob": "8.1.0", @@ -321,7 +308,8 @@ "shelljs": "0.8.5", "slash": "3.0.0", "terser": "5.19.2", - "ts-node": "10.9.1" + "ts-node": "10.9.1", + "@payloadcms/eslint-config": "workspace:*" }, "files": [ "bin.js", diff --git a/packages/payload/tsconfig.json b/packages/payload/tsconfig.json index 3c5f4149631..c3a4d2239a2 100644 --- a/packages/payload/tsconfig.json +++ b/packages/payload/tsconfig.json @@ -2,9 +2,9 @@ "extends": "../../tsconfig.json", "compilerOptions": { "composite": true, - "target": "es2019", + "target": "ES2019", "sourceMap": true, - "module": "commonjs", + "module": "Node16", "allowJs": true, /* Allow javascript files to be compiled. */ "checkJs": false, /* Report errors in .js files. */ "jsx": "react", /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */ @@ -50,4 +50,4 @@ "node_modules", ".eslintrc.js" ] - } \ No newline at end of file + } diff --git a/tsconfig.json b/tsconfig.json index 978885040ff..826f441efcc 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -8,21 +8,41 @@ }, { "path": "./packages/db-postgres" - }, - ], - "include": [ - "**/*", - "src/", + } ], + "compilerOptions": { + "types": ["node"], + "composite": true, + "target": "ES2019", + "sourceMap": true, + "module": "Node16", + "allowJs": true /* Allow javascript files to be compiled. */, + "checkJs": false /* Report errors in .js files. */, + "jsx": "react" /* Specify JSX code generation: 'preserve', 'react-native', or 'react'. */, + "declaration": true /* Generates corresponding '.d.ts' file. */, + /* Concatenate and emit output to single file. */ + "outDir": "./dist" /* Redirect output structure to the directory. */, + "rootDir": "./src" /* Specify the root directory of input files. Use to control the output directory structure with --outDir. */, + /* Do not emit comments to output. */ + "noEmit": false /* Do not emit outputs. */, + "strict": false /* Enable all strict type-checking options. */, + "moduleResolution": "Node16" /* Specify module resolution strategy: 'node' (Node.js) or 'classic' (TypeScript pre-1.6). */, + "esModuleInterop": true /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */, + "resolveJsonModule": true, + "skipLibCheck": true /* Skip type checking of declaration files. */, + "forceConsistentCasingInFileNames": true /* Disallow inconsistently-cased references to the same file. */ + }, + "include": ["**/*", "src/"], "exclude": [ "dist", "build", "tests", - "**/*.spec.js", - "**/*.spec.ts", + "test", "node_modules", ".eslintrc.js", - "test", - "**/test/**/*", + "**/*.spec.js", + "**/*.spec.jsx", + "**/*.spec.ts", + "**/*.spec.tsx" ] -} \ No newline at end of file +} diff --git a/turbo.json b/turbo.json new file mode 100644 index 00000000000..2b1ef65e34f --- /dev/null +++ b/turbo.json @@ -0,0 +1,17 @@ +{ + "$schema": "https://turbo.build/schema.json", + "pipeline": { + "build": { + "outputs": ["./dist/**"], + "dependsOn": ["^build"], + "cache": false + }, + "lint": { + "dependsOn": ["^lint"], + "cache": false + }, + "dev": { + "cache": false + } + } +}