fix(ui): pagination resets perPage #10199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
🚀 This is included in version v3.12.0 |
kendelljoseph
pushed a commit
that referenced
this pull request
Feb 21, 2025
When using various controls within the List View, those selections are sometimes not persisted. This is especially evident when selecting `perPage` from the List View, where the URL and UI would reflect this selection, but the controls would be stale. Similarly, after changing `perPage` then navigating to another page through the pagination controls, `perPage` would reset back to the original value. Same with the sort controls, where sorting by a particular column would not be reflected in the UI. This was because although we modify the URL search params and fire off a new query with those changes, we were not updating local component state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using various controls within the List View, those selections are sometimes not persisted. This is especially evident when selecting
perPagefrom the List View, where the URL and UI would reflect this selection, but the controls would be stale. Similarly, after changingperPagethen navigating to another page through the pagination controls,perPagewould reset back to the original value. Same with the sort controls, where sorting by a particular column would not be reflected in the UI. This was because although we modify the URL search params and fire off a new query with those changes, we were not updating local component state.