-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shipping address validation on Paysheet starts #100
Comments
Hi @mauro-poq - Sorry for the delay. We should be invoking the We've picked up the work and the change should be in the next release of the SDK. Will keep you updated! |
Hey @tdchow how are you? Questions:
Note: |
hi @mauro-poq! Apologies for not getting back to you here! I was able to verify that the second time the SDK is invoked, the Thanks for calling this bug out. I've created a ticket for the team to resolve this. We'll keep you updated on the fix here. |
Hello @mauro-poq This fix for this should come out in the next release. |
Hi @mauro-poq the fix will be in the next version |
This is a critical item as the failure to make the callback call means we do not have the opportunity to calculate the correct taxes for a given purchase. This will not go unnoticed by end users looking to game the checkout process potentially leaving us paying taxes for PayPal customers, or worse, not paying the taxes and incurring fines and penalties from taxing authorities. |
Hi @tdchow and @chpypl, I have tested this in the new version (0.112.0) to see if the change were included, however, I can see now that the |
Hi @mauro-poq - sorry for the delayed response. The removal of |
Hey @tdchow - no problem man! I see, I think it will not be a problem, but before checking with the BE team, can you confirm if the fields will be present when the user places the order (press the pay button)? |
The OnShippingChange callback should be called initially when the paysheet is loaded and whenever the buyer changes their shipping address - both of which should be before the user clicks on the CTA button. If you're seeing different behavior please let me know and we can further investigate! |
Hey @tdchow I can confirm that the fix is in place and working. Feel free to close or change the status of this issue. |
@mauro-poq - Awesome, thanks so much for retesting and following up here. Will close out this issue. |
I have a case where the user has only invalid addresses in PayPal when I start the Paysheet, in my case the user has only UK addresses and the company accepts only US addresses for delivery. So when the user opens the Paysheet we have already a default address set by PayPal SDK but the
onShippingChange
is not called, so I'm not able to call my BackEnd to verify.Talking to the iOS developer, he said to me that every time he opens the paysheet the
onShippingChange
is invoked and he is able to validate the address.I don't know if this is a bug or not, however, is there a way to make the SDK invoke
onShippingChange
as soon as the user opens the paysheet, maybe some configuration?Other scenarios are working fine, if the user changes the address I receive the callback and I'm able to validate the address.
The text was updated successfully, but these errors were encountered: