Cleanup FQDN host names in SignalFx client #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 7, 2021 11:08
Signed-off-by: Abdul Qadeer <aqadeer@paypal.com>
Add UTs for SignalFx client Signed-off-by: Abdul Qadeer <aqadeer@paypal.com>
ridv
reviewed
Sep 7, 2021
main.go
Outdated
| func init() { | ||
| logLevel, _ := os.LookupEnv("LOG_LEVEL") | ||
| parsedLogLevel, err := log.ParseLevel(logLevel) | ||
| if err != nil { |
There was a problem hiding this comment.
I think this should be err == nil .
It may be a good idea to log a message saying there was an error parsing the log level failed and we're falling back on the library default if the environment variable was indeed set.
Something like:
logLevel, evnLogLevelSet := os.LookupEnv("LOG_LEVEL")
parsedLogLevel, err := log.ParseLevel(logLevel)
if evnLogLevelSet && err != nil {
log.Info("Unable to parse log level set. Defaulting to ", log.GetLevel())
}
if err == nil {
log.SetLevel(parsedLogLevel)
}There was a problem hiding this comment.
Good catch, updated
|
|
||
| // This function extracts host name from its FQDN | ||
| // This assumes that host names themselves don't contain "." | ||
| func cleanUpHostname(hostname string) string { |
There was a problem hiding this comment.
Can you give an example of the input and output expected by this function? (It may also be worth putting this in as a comment.)
There was a problem hiding this comment.
Added, also modified var/function names to make it clearer
Signed-off-by: Abdul Qadeer <aqadeer@paypal.com>
wangchen615
previously approved these changes
Sep 7, 2021
ridv
reviewed
Sep 7, 2021
main.go
Outdated
| logLevel, evnLogLevelSet := os.LookupEnv("LOG_LEVEL") | ||
| parsedLogLevel, err := log.ParseLevel(logLevel) | ||
| if evnLogLevelSet && err != nil { | ||
| log.Info("unable to parse log level set; defaulting to: %v", log.GetLevel()) |
There was a problem hiding this comment.
Suggested change
| log.Info("unable to parse log level set; defaulting to: %v", log.GetLevel()) | |
| log.Infof("unable to parse log level set; defaulting to: %v", log.GetLevel()) |
Signed-off-by: Abdul Qadeer <aqadeer@paypal.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32 and #33. Partially address #26.
Also adds "cluster" filter for SignalFx client.