Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Increase minimum label height to 20px #2422

Closed
wants to merge 1 commit into from

Conversation

avocadomayo
Copy link

@avocadomayo avocadomayo commented Jul 24, 2024

Description

Co-authored by @gcaven

Hello PayPal SDK team 👋 We are trying to render a PayPal button using the disableMaxHeight: true and disableMaxWidth: true params so the PayPal button sizes according to the container.

We noticed the PayPal logo scales proportionately to the container size, but at small container sizes, the PayPal logo gets very small such that it looks inconsistent to other branded buttons on the page- please see screenshots below.

@westeezy helped us and pointed us out to where the .paypal-button-label-container CSS is generated. However, labelHeight is dynamic and used in a lot of places, so we were curious if you could help us make sense of whether this fits in your product requirements and move this forward. Many thanks in advance 🙏

Reproduction Steps (if applicable)

  1. In the style param, set disableMaxHeight: true and disableMaxWidth: true
  2. Render the PayPal button in a small container, eg. 100px width x 42px height

Screenshots (if applicable)

Current state

Screenshot 2024-07-24 at 14 25 47

Desired state

Screenshot 2024-07-24 at 14 28 47

Why are we making these changes? Include references to any related Jira tasks or GitHub Issues

Dependent Changes (if applicable)

Groups who should review (if applicable)

❤️ Thank you!

@avocadomayo avocadomayo changed the title Increase minimum label height to 20px [DO NOT MERGE] Increase minimum label height to 20px Jul 24, 2024
Copy link

github-actions bot commented Dec 2, 2024

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@github-actions github-actions bot added the Stale label Dec 2, 2024
@avocadomayo avocadomayo closed this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant