cleanup #124
Annotations
25 warnings
redundant closure:
pdf/src/build.rs#L68
warning: redundant closure
--> pdf/src/build.rs:68:18
|
68 | .map(|ops| Content::from_ops(ops));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `Content::from_ops`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
= note: `#[warn(clippy::redundant_closure)]` on by default
|
this expression borrows a value the compiler would automatically borrow:
pdf/src/object/mod.rs#L749
warning: this expression borrows a value the compiler would automatically borrow
--> pdf/src/object/mod.rs:749:21
|
749 | Ok(Box::new((&**self).deep_clone(cloner)?))
| ^^^^^^^^^ help: change this to: `(**self)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`:
pdf/src/object/mod.rs#L592
warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`
--> pdf/src/object/mod.rs:592:70
|
592 | Primitive::Array(ref parts) => Ok(Primitive::Array(parts.into_iter().map(|p| p.deep_clone(cloner)).try_collect()?)),
| ^^^^^^^^^ help: call directly: `iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
= note: `#[warn(clippy::into_iter_on_ref)]` on by default
|
unused variable: `old`:
pdf/src/build.rs#L290
warning: unused variable: `old`
--> pdf/src/build.rs:290:22
|
290 | if let Some((old, new)) = self.shared.get(&key) {
| ^^^ help: if this is intentional, prefix it with an underscore: `_old`
|
unused variable: `cloner`:
pdf/src/encoding.rs#L105
warning: unused variable: `cloner`
--> pdf/src/encoding.rs:105:26
|
105 | fn deep_clone(&self, cloner: &mut impl pdf::object::Cloner) -> Result<Self> {
| ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cloner`
|
unused variable: `update`:
pdf/src/primitive.rs#L267
warning: unused variable: `update`
--> pdf/src/primitive.rs:267:28
|
267 | fn to_primitive(&self, update: &mut impl Updater) -> Result<Primitive> {
| ^^^^^^ help: if this is intentional, prefix it with an underscore: `_update`
|
unused variable: `cloner`:
pdf/src/object/mod.rs#L756
warning: unused variable: `cloner`
--> pdf/src/object/mod.rs:756:38
|
756 | fn deep_clone(&self, cloner: &mut impl Cloner) -> Result<Self> {
| ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cloner`
...
763 | deep_clone_simple!(f32, i32, u32, bool, Name, (), Date, PdfString, Rect, u8, Arc<[u8]>, Vec<u16>);
| ------------------------------------------------------------------------------------------------- in this macro invocation
|
= note: this warning originates in the macro `deep_clone_simple` (in Nightly builds, run with -Z macro-backtrace for more info)
|
unused variable: `range`:
pdf/src/object/mod.rs#L85
warning: unused variable: `range`
--> pdf/src/object/mod.rs:85:41
|
85 | fn stream_data(&self, id: PlainRef, range: Range<usize>) -> Result<Arc<[u8]>> {
| ^^^^^ help: if this is intentional, prefix it with an underscore: `_range`
|
unused variable: `id`:
pdf/src/object/mod.rs#L85
warning: unused variable: `id`
--> pdf/src/object/mod.rs:85:27
|
85 | fn stream_data(&self, id: PlainRef, range: Range<usize>) -> Result<Arc<[u8]>> {
| ^^ help: if this is intentional, prefix it with an underscore: `_id`
|
unused variable: `cloner`:
pdf/src/object/function.rs#L208
warning: unused variable: `cloner`
--> pdf/src/object/function.rs:208:26
|
208 | fn deep_clone(&self, cloner: &mut impl Cloner) -> Result<Self> {
| ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cloner`
|
unused variable: `update`:
pdf/src/object/function.rs#L182
warning: unused variable: `update`
--> pdf/src/object/function.rs:182:28
|
182 | fn to_primitive(&self, update: &mut impl Updater) -> Result<Primitive> {
| ^^^^^^ help: if this is intentional, prefix it with an underscore: `_update`
|
= note: `#[warn(unused_variables)]` on by default
|
`Rect` is ambiguous:
pdf/src/build.rs#L84
warning: `Rect` is ambiguous
--> pdf/src/build.rs:84:31
|
84 | self.media_box = Some(Rect {
| ^^^^ ambiguous name
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #114095 <https://github.com/rust-lang/rust/issues/114095>
= note: ambiguous because of multiple glob imports of a name in the same module
note: `Rect` could refer to the struct imported here
--> pdf/src/build.rs:15:5
|
15 | use crate::object::*;
| ^^^^^^^^^^^^^^^^
= help: consider adding an explicit import of `Rect` to disambiguate
note: `Rect` could also refer to the struct imported here
--> pdf/src/build.rs:16:5
|
16 | use crate::content::*;
| ^^^^^^^^^^^^^^^^^
= help: consider adding an explicit import of `Rect` to disambiguate
|
`Rect` is ambiguous:
pdf/src/build.rs#L27
warning: `Rect` is ambiguous
--> pdf/src/build.rs:27:26
|
27 | pub trim_box: Option<Rect>,
| ^^^^ ambiguous name
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #114095 <https://github.com/rust-lang/rust/issues/114095>
= note: ambiguous because of multiple glob imports of a name in the same module
note: `Rect` could refer to the struct imported here
--> pdf/src/build.rs:15:5
|
15 | use crate::object::*;
| ^^^^^^^^^^^^^^^^
= help: consider adding an explicit import of `Rect` to disambiguate
note: `Rect` could also refer to the struct imported here
--> pdf/src/build.rs:16:5
|
16 | use crate::content::*;
| ^^^^^^^^^^^^^^^^^
= help: consider adding an explicit import of `Rect` to disambiguate
|
`Rect` is ambiguous:
pdf/src/build.rs#L26
warning: `Rect` is ambiguous
--> pdf/src/build.rs:26:26
|
26 | pub crop_box: Option<Rect>,
| ^^^^ ambiguous name
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #114095 <https://github.com/rust-lang/rust/issues/114095>
= note: ambiguous because of multiple glob imports of a name in the same module
note: `Rect` could refer to the struct imported here
--> pdf/src/build.rs:15:5
|
15 | use crate::object::*;
| ^^^^^^^^^^^^^^^^
= help: consider adding an explicit import of `Rect` to disambiguate
note: `Rect` could also refer to the struct imported here
--> pdf/src/build.rs:16:5
|
16 | use crate::content::*;
| ^^^^^^^^^^^^^^^^^
= help: consider adding an explicit import of `Rect` to disambiguate
|
`Rect` is ambiguous:
pdf/src/build.rs#L25
warning: `Rect` is ambiguous
--> pdf/src/build.rs:25:27
|
25 | pub media_box: Option<Rect>,
| ^^^^ ambiguous name
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #114095 <https://github.com/rust-lang/rust/issues/114095>
= note: ambiguous because of multiple glob imports of a name in the same module
note: `Rect` could refer to the struct imported here
--> pdf/src/build.rs:15:5
|
15 | use crate::object::*;
| ^^^^^^^^^^^^^^^^
= help: consider adding an explicit import of `Rect` to disambiguate
note: `Rect` could also refer to the struct imported here
--> pdf/src/build.rs:16:5
|
16 | use crate::content::*;
| ^^^^^^^^^^^^^^^^^
= help: consider adding an explicit import of `Rect` to disambiguate
= note: `#[warn(ambiguous_glob_imports)]` on by default
|
unused import: `Object`:
pdf/src/any.rs#L5
warning: unused import: `Object`
--> pdf/src/any.rs:5:21
|
5 | use crate::object::{Object};
| ^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
variable does not need to be mutable:
pdf_derive/src/lib.rs#L755
warning: variable does not need to be mutable
--> pdf_derive/src/lib.rs:755:25
|
755 | let (impl_generics, mut ty_generics, where_clause) = generics.split_for_impl();
| ----^^^^^^^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
unused variable: `f`:
pdf_derive/src/lib.rs#L457
warning: unused variable: `f`
--> pdf_derive/src/lib.rs:457:85
|
457 | let labels: Vec<Ident> = fields.unnamed.iter().enumerate().map(|(i, f)| {
| ^ help: if this is intentional, prefix it with an underscore: `_f`
|
unused variable: `attrs`:
pdf_derive/src/lib.rs#L273
warning: unused variable: `attrs`
--> pdf_derive/src/lib.rs:273:9
|
273 | let attrs = GlobalAttrs::from_ast(ast);
| ^^^^^ help: if this is intentional, prefix it with an underscore: `_attrs`
|
= note: `#[warn(unused_variables)]` on by default
|
unused imports: `punctuated::Punctuated`, `token::Where`:
pdf_derive/src/lib.rs#L99
warning: unused imports: `punctuated::Punctuated`, `token::Where`
--> pdf_derive/src/lib.rs:99:14
|
99 | use syn::{*, punctuated::Punctuated, token::Where};
| ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
variable does not need to be mutable:
pdf_derive/src/lib.rs#L755
warning: variable does not need to be mutable
--> pdf_derive/src/lib.rs:755:25
|
755 | let (impl_generics, mut ty_generics, where_clause) = generics.split_for_impl();
| ----^^^^^^^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
|
unused variable: `f`:
pdf_derive/src/lib.rs#L457
warning: unused variable: `f`
--> pdf_derive/src/lib.rs:457:85
|
457 | let labels: Vec<Ident> = fields.unnamed.iter().enumerate().map(|(i, f)| {
| ^ help: if this is intentional, prefix it with an underscore: `_f`
|
unused variable: `attrs`:
pdf_derive/src/lib.rs#L273
warning: unused variable: `attrs`
--> pdf_derive/src/lib.rs:273:9
|
273 | let attrs = GlobalAttrs::from_ast(ast);
| ^^^^^ help: if this is intentional, prefix it with an underscore: `_attrs`
|
= note: `#[warn(unused_variables)]` on by default
|
unused imports: `punctuated::Punctuated`, `token::Where`:
pdf_derive/src/lib.rs#L99
warning: unused imports: `punctuated::Punctuated`, `token::Where`
--> pdf_derive/src/lib.rs:99:14
|
99 | use syn::{*, punctuated::Punctuated, token::Where};
| ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
check-clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|