error[E0609]: no field `normal` on type `&_` --> examples/src/bin/form.rs:49:48 | 49 | let normal = file.resolver().get(a.normal); | ^^^^^^

error[E0609]: no field `appearance_streams` on type `pdf::object::RcRef<_>` --> examples/src/bin/form.rs:48:36 | 48 | if let Some(ref a) = annot.appearance_streams { | ^^^^^^^^^^^^^^^^^^ unknown field

error[E0308]: mismatched types --> examples/src/bin/form.rs:47:41 | 47 | let annot = file.resolver().get(annot)?; | --- ^^^^^ expected `Ref<_>`, found `MaybeRef<Annot>` | | | arguments to this method are incorrect | = note: expected struct `pdf::object::Ref<_>` found enum `pdf::object::MaybeRef<pdf::object::Annot>` note: method defined here --> /home/runner/work/pdf/pdf/pdf/src/object/mod.rs:64:8 | 64 | fn get<T: Object+DataSize>(&self, r: Ref<T>) -> Result<RcRef<T>>; | ^^^

Clippy had exited with the 101 exit code

warning: field assignment outside of initializer for an instance created with Default::default() --> examples/src/bin/extract_page.rs:77:5 | 77 | info.title = Some(PdfString::from("test")); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: consider initializing the variable with `pdf::object::InfoDict { title: Some(PdfString::from("test")), ..Default::default() }` and removing relevant reassignments --> examples/src/bin/extract_page.rs:76:5 | 76 | let mut info = InfoDict::default(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default = note: `#[warn(clippy::field_reassign_with_default)]` on by default

warning: unused import: `Log` --> examples/src/bin/form.rs:8:30 | 8 | use pdf::file::{FileOptions, Log}; | ^^^ | = note: `#[warn(unused_imports)]` on by default

warning: this expression creates a reference which is immediately dereferenced by the compiler --> pdf/src/build.rs:268:36 | 268 | match self.map.get(&r1) { | ^^^ help: change this to: `r1` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: accessing first element with `inner.descendant_fonts.get(0)` --> pdf/src/font.rs:257:43 | 257 | FontData::Type0(ref inner) => inner.descendant_fonts.get(0).and_then(|f| f.cid_to_gid_map()), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `inner.descendant_fonts.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first

warning: accessing first element with `t.descendant_fonts.get(0)` --> pdf/src/font.rs:246:39 | 246 | FontData::Type0(ref t) => t.descendant_fonts.get(0).and_then(|f| f.embedded_data(resolve)), | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `t.descendant_fonts.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first

warning: this expression borrows a value the compiler would automatically borrow --> pdf/src/object/mod.rs:759:21 | 759 | Ok(Box::new((&**self).deep_clone(cloner)?)) | ^^^^^^^^^ help: change this to: `(**self)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` --> pdf/src/object/mod.rs:602:70 | 602 | Primitive::Array(ref parts) => Ok(Primitive::Array(parts.into_iter().map(|p| p.deep_clone(cloner)).try_collect()?)), | ^^^^^^^^^ help: call directly: `iter` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref = note: `#[warn(clippy::into_iter_on_ref)]` on by default

warning: accessing first element with `array.get(0)` --> pdf/src/object/types.rs:1236:52 | 1236 | let page = Object::from_primitive(try_opt!(array.get(0)).clone(), resolve)?; | ^^^^^^^^^^^^ help: try: `array.first()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first = note: `#[warn(clippy::get_first)]` on by default

warning: unused variable: `old` --> pdf/src/build.rs:397:22 | 397 | if let Some((old, new)) = self.shared.get(&key) { | ^^^ help: if this is intentional, prefix it with an underscore: `_old`

warning: unused variable: `cloner` --> pdf/src/encoding.rs:105:26 | 105 | fn deep_clone(&self, cloner: &mut impl pdf::object::Cloner) -> Result<Self> { | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cloner`

warning: unused variable: `update` --> pdf/src/primitive.rs:270:28 | 270 | fn to_primitive(&self, update: &mut impl Updater) -> Result<Primitive> { | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_update`

warning: unused variable: `cloner` --> pdf/src/object/mod.rs:766:38 | 766 | fn deep_clone(&self, cloner: &mut impl Cloner) -> Result<Self> { | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cloner` ... 773 | deep_clone_simple!(f32, i32, u32, bool, Name, (), Date, PdfString, Rectangle, u8, Arc<[u8]>, Vec<u16>); | ------------------------------------------------------------------------------------------------------ in this macro invocation | = note: this warning originates in the macro `deep_clone_simple` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unused variable: `cloner` --> pdf/src/object/mod.rs:766:38 | 766 | fn deep_clone(&self, cloner: &mut impl Cloner) -> Result<Self> { | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cloner` ... 773 | deep_clone_simple!(f32, i32, u32, bool, Name, (), Date, PdfString, Rectangle, u8, Arc<[u8]>, Vec<u16>); | ------------------------------------------------------------------------------------------------------ in this macro invocation | = note: this warning originates in the macro `deep_clone_simple` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unused variable: `cloner` --> pdf/src/object/mod.rs:766:38 | 766 | fn deep_clone(&self, cloner: &mut impl Cloner) -> Result<Self> { | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cloner` ... 773 | deep_clone_simple!(f32, i32, u32, bool, Name, (), Date, PdfString, Rectangle, u8, Arc<[u8]>, Vec<u16>); | ------------------------------------------------------------------------------------------------------ in this macro invocation | = note: this warning originates in the macro `deep_clone_simple` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unused variable: `cloner` --> pdf/src/object/mod.rs:766:38 | 766 | fn deep_clone(&self, cloner: &mut impl Cloner) -> Result<Self> { | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cloner` ... 773 | deep_clone_simple!(f32, i32, u32, bool, Name, (), Date, PdfString, Rectangle, u8, Arc<[u8]>, Vec<u16>); | ------------------------------------------------------------------------------------------------------ in this macro invocation | = note: this warning originates in the macro `deep_clone_simple` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unused variable: `cloner` --> pdf/src/object/mod.rs:766:38 | 766 | fn deep_clone(&self, cloner: &mut impl Cloner) -> Result<Self> { | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cloner` ... 773 | deep_clone_simple!(f32, i32, u32, bool, Name, (), Date, PdfString, Rectangle, u8, Arc<[u8]>, Vec<u16>); | ------------------------------------------------------------------------------------------------------ in this macro invocation | = note: this warning originates in the macro `deep_clone_simple` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unused variable: `cloner` --> pdf/src/object/mod.rs:766:38 | 766 | fn deep_clone(&self, cloner: &mut impl Cloner) -> Result<Self> { | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cloner` ... 773 | deep_clone_simple!(f32, i32, u32, bool, Name, (), Date, PdfString, Rectangle, u8, Arc<[u8]>, Vec<u16>); | ------------------------------------------------------------------------------------------------------ in this macro invocation | = note: this warning originates in the macro `deep_clone_simple` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unused variable: `cloner` --> pdf/src/object/mod.rs:766:38 | 766 | fn deep_clone(&self, cloner: &mut impl Cloner) -> Result<Self> { | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cloner` ... 773 | deep_clone_simple!(f32, i32, u32, bool, Name, (), Date, PdfString, Rectangle, u8, Arc<[u8]>, Vec<u16>); | ------------------------------------------------------------------------------------------------------ in this macro invocation | = note: this warning originates in the macro `deep_clone_simple` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unused variable: `cloner` --> pdf/src/object/mod.rs:766:38 | 766 | fn deep_clone(&self, cloner: &mut impl Cloner) -> Result<Self> { | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cloner` ... 773 | deep_clone_simple!(f32, i32, u32, bool, Name, (), Date, PdfString, Rectangle, u8, Arc<[u8]>, Vec<u16>); | ------------------------------------------------------------------------------------------------------ in this macro invocation | = note: this warning originates in the macro `deep_clone_simple` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unused variable: `cloner` --> pdf/src/object/mod.rs:766:38 | 766 | fn deep_clone(&self, cloner: &mut impl Cloner) -> Result<Self> { | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cloner` ... 773 | deep_clone_simple!(f32, i32, u32, bool, Name, (), Date, PdfString, Rectangle, u8, Arc<[u8]>, Vec<u16>); | ------------------------------------------------------------------------------------------------------ in this macro invocation | = note: this warning originates in the macro `deep_clone_simple` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unused variable: `cloner` --> pdf/src/object/mod.rs:766:38 | 766 | fn deep_clone(&self, cloner: &mut impl Cloner) -> Result<Self> { | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cloner` ... 773 | deep_clone_simple!(f32, i32, u32, bool, Name, (), Date, PdfString, Rectangle, u8, Arc<[u8]>, Vec<u16>); | ------------------------------------------------------------------------------------------------------ in this macro invocation | = note: this warning originates in the macro `deep_clone_simple` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unused variable: `cloner` --> pdf/src/object/mod.rs:766:38 | 766 | fn deep_clone(&self, cloner: &mut impl Cloner) -> Result<Self> { | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cloner` ... 773 | deep_clone_simple!(f32, i32, u32, bool, Name, (), Date, PdfString, Rectangle, u8, Arc<[u8]>, Vec<u16>); | ------------------------------------------------------------------------------------------------------ in this macro invocation | = note: this warning originates in the macro `deep_clone_simple` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unused variable: `cloner` --> pdf/src/object/mod.rs:766:38 | 766 | fn deep_clone(&self, cloner: &mut impl Cloner) -> Result<Self> { | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cloner` ... 773 | deep_clone_simple!(f32, i32, u32, bool, Name, (), Date, PdfString, Rectangle, u8, Arc<[u8]>, Vec<u16>); | ------------------------------------------------------------------------------------------------------ in this macro invocation | = note: this warning originates in the macro `deep_clone_simple` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: unused variable: `range` --> pdf/src/object/mod.rs:85:41 | 85 | fn stream_data(&self, id: PlainRef, range: Range<usize>) -> Result<Arc<[u8]>> { | ^^^^^ help: if this is intentional, prefix it with an underscore: `_range`

warning: unused variable: `id` --> pdf/src/object/mod.rs:85:27 | 85 | fn stream_data(&self, id: PlainRef, range: Range<usize>) -> Result<Arc<[u8]>> { | ^^ help: if this is intentional, prefix it with an underscore: `_id`

warning: unused variable: `cloner` --> pdf/src/object/function.rs:208:26 | 208 | fn deep_clone(&self, cloner: &mut impl Cloner) -> Result<Self> { | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_cloner`

warning: unused variable: `update` --> pdf/src/object/function.rs:182:28 | 182 | fn to_primitive(&self, update: &mut impl Updater) -> Result<Primitive> { | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_update` | = note: `#[warn(unused_variables)]` on by default

warning: variable does not need to be mutable --> pdf_derive/src/lib.rs:766:25 | 766 | let (impl_generics, mut ty_generics, where_clause) = generics.split_for_impl(); | ----^^^^^^^^^^^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` on by default

warning: unused variable: `field` --> pdf_derive/src/lib.rs:728:39 | 728 | let other = parts.iter().filter(|(field, attrs, _)| attrs.other).flat_map(|(field, _, _)| field).next(); | ^^^^^ help: if this is intentional, prefix it with an underscore: `_field`

warning: unused variable: `f` --> pdf_derive/src/lib.rs:457:85 | 457 | let labels: Vec<Ident> = fields.unnamed.iter().enumerate().map(|(i, f)| { | ^ help: if this is intentional, prefix it with an underscore: `_f`

warning: unused variable: `attrs` --> pdf_derive/src/lib.rs:273:9 | 273 | let attrs = GlobalAttrs::from_ast(ast); | ^^^^^ help: if this is intentional, prefix it with an underscore: `_attrs` | = note: `#[warn(unused_variables)]` on by default

warning: unused imports: `punctuated::Punctuated`, `token::Where` --> pdf_derive/src/lib.rs:99:14 | 99 | use syn::{*, punctuated::Punctuated, token::Where}; | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

warning: use of deprecated type alias `object::types::ViewRect` --> pdf/src/build.rs:85:31 | 85 | self.media_box = Some(ViewRect { | ^^^^^^^^

warning: use of deprecated type alias `object::types::ViewRect` --> pdf/src/build.rs:28:26 | 28 | pub trim_box: Option<ViewRect>, | ^^^^^^^^

warning: use of deprecated type alias `object::types::ViewRect` --> pdf/src/build.rs:27:26 | 27 | pub crop_box: Option<ViewRect>, | ^^^^^^^^

warning: use of deprecated type alias `object::types::ViewRect` --> pdf/src/build.rs:26:27 | 26 | pub media_box: Option<ViewRect>, | ^^^^^^^^ | = note: `#[warn(deprecated)]` on by default

warning: `ViewRect` is ambiguous --> pdf/src/build.rs:85:31 | 85 | self.media_box = Some(ViewRect { | ^^^^^^^^ ambiguous name | = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! = note: for more information, see issue #114095 <https://github.com/rust-lang/rust/issues/114095> = note: ambiguous because of multiple glob imports of a name in the same module note: `ViewRect` could refer to the type alias imported here --> pdf/src/build.rs:16:5 | 16 | use crate::object::*; | ^^^^^^^^^^^^^^^^ = help: consider adding an explicit import of `ViewRect` to disambiguate note: `ViewRect` could also refer to the struct imported here --> pdf/src/build.rs:17:5 | 17 | use crate::content::*; | ^^^^^^^^^^^^^^^^^ = help: consider adding an explicit import of `ViewRect` to disambiguate

warning: `ViewRect` is ambiguous --> pdf/src/build.rs:28:26 | 28 | pub trim_box: Option<ViewRect>, | ^^^^^^^^ ambiguous name | = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! = note: for more information, see issue #114095 <https://github.com/rust-lang/rust/issues/114095> = note: ambiguous because of multiple glob imports of a name in the same module note: `ViewRect` could refer to the type alias imported here --> pdf/src/build.rs:16:5 | 16 | use crate::object::*; | ^^^^^^^^^^^^^^^^ = help: consider adding an explicit import of `ViewRect` to disambiguate note: `ViewRect` could also refer to the struct imported here --> pdf/src/build.rs:17:5 | 17 | use crate::content::*; | ^^^^^^^^^^^^^^^^^ = help: consider adding an explicit import of `ViewRect` to disambiguate

warning: `ViewRect` is ambiguous --> pdf/src/build.rs:27:26 | 27 | pub crop_box: Option<ViewRect>, | ^^^^^^^^ ambiguous name | = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! = note: for more information, see issue #114095 <https://github.com/rust-lang/rust/issues/114095> = note: ambiguous because of multiple glob imports of a name in the same module note: `ViewRect` could refer to the type alias imported here --> pdf/src/build.rs:16:5 | 16 | use crate::object::*; | ^^^^^^^^^^^^^^^^ = help: consider adding an explicit import of `ViewRect` to disambiguate note: `ViewRect` could also refer to the struct imported here --> pdf/src/build.rs:17:5 | 17 | use crate::content::*; | ^^^^^^^^^^^^^^^^^ = help: consider adding an explicit import of `ViewRect` to disambiguate

warning: `ViewRect` is ambiguous --> pdf/src/build.rs:26:27 | 26 | pub media_box: Option<ViewRect>, | ^^^^^^^^ ambiguous name | = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! = note: for more information, see issue #114095 <https://github.com/rust-lang/rust/issues/114095> = note: ambiguous because of multiple glob imports of a name in the same module note: `ViewRect` could refer to the type alias imported here --> pdf/src/build.rs:16:5 | 16 | use crate::object::*; | ^^^^^^^^^^^^^^^^ = help: consider adding an explicit import of `ViewRect` to disambiguate note: `ViewRect` could also refer to the struct imported here --> pdf/src/build.rs:17:5 | 17 | use crate::content::*; | ^^^^^^^^^^^^^^^^^ = help: consider adding an explicit import of `ViewRect` to disambiguate = note: `#[warn(ambiguous_glob_imports)]` on by default

warning: unused import: `Object` --> pdf/src/any.rs:5:21 | 5 | use crate::object::{Object}; | ^^^^^^

warning: unused import: `snafu::ErrorCompat` --> pdf/src/error.rs:7:5 | 7 | use snafu::ErrorCompat; | ^^^^^^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

warning: variable does not need to be mutable --> pdf_derive/src/lib.rs:766:25 | 766 | let (impl_generics, mut ty_generics, where_clause) = generics.split_for_impl(); | ----^^^^^^^^^^^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` on by default

warning: unused variable: `field` --> pdf_derive/src/lib.rs:728:39 | 728 | let other = parts.iter().filter(|(field, attrs, _)| attrs.other).flat_map(|(field, _, _)| field).next(); | ^^^^^ help: if this is intentional, prefix it with an underscore: `_field`

warning: unused variable: `f` --> pdf_derive/src/lib.rs:457:85 | 457 | let labels: Vec<Ident> = fields.unnamed.iter().enumerate().map(|(i, f)| { | ^ help: if this is intentional, prefix it with an underscore: `_f`

warning: unused variable: `attrs` --> pdf_derive/src/lib.rs:273:9 | 273 | let attrs = GlobalAttrs::from_ast(ast); | ^^^^^ help: if this is intentional, prefix it with an underscore: `_attrs` | = note: `#[warn(unused_variables)]` on by default

warning: unused imports: `punctuated::Punctuated`, `token::Where` --> pdf_derive/src/lib.rs:99:14 | 99 | use syn::{*, punctuated::Punctuated, token::Where}; | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default