Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add step to check for MkDocs #17

Closed
wants to merge 1 commit into from

Conversation

tupaschoal
Copy link

Better safe then sorry, I'm suggesting a step that just tries to run MkDocs in a simple action before actually trying to build

@peaceiris
Copy link
Owner

As I said at #16, it is better that we manage the version of dependencies by Pipenv.lock or requirements.txt. We can check the version by reading those files.

@tupaschoal
Copy link
Author

My intent here was just to make sure it runs by trying a simple command. Could have been "help" or anything else.

If you think it doesn't make sense, feel free to close it.

@peaceiris
Copy link
Owner

I think that the current example is enough as just an example. Of course, users can expand their YAML settings as they like at their repository. Thank you for your suggestion.

@peaceiris peaceiris closed this Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants