Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify MkDocs example #16

Closed
wants to merge 1 commit into from
Closed

Conversation

tupaschoal
Copy link

This might be a very näive suggestion, but using a requirements.txt for something as simple as using MkDocs seems like an overkill. What do you think?

@peaceiris
Copy link
Owner

In general, we should lock the version of dependencies for stable CI/CD execution using pip freeze or pipenv lock. I don't think that this change is better.

@tupaschoal
Copy link
Author

I figured for MkDocs it might not be needed, but I get your point. Closing PR, thanks

@tupaschoal tupaschoal closed this Sep 6, 2019
@peaceiris
Copy link
Owner

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants