Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: Define config types and validate those #322

Open
peaceiris opened this issue Nov 25, 2020 · 3 comments
Open

proposal: Define config types and validate those #322

peaceiris opened this issue Nov 25, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request proposal
Milestone

Comments

@peaceiris
Copy link
Owner

peaceiris commented Nov 25, 2020

Is your feature request related to a problem? Please describe.

Validate config file at first.

Describe the solution you'd like

Libraries

Describe alternatives you've considered

Additional context

@peaceiris peaceiris self-assigned this Nov 25, 2020
@github-actions
Copy link
Contributor

Thank you @peaceiris for suggesting this.

@peaceiris peaceiris added the enhancement New feature or request label Jun 18, 2021
@peaceiris peaceiris added this to the v1 milestone Jul 31, 2021
@peaceiris peaceiris changed the title proposal: Define config types proposal: Define config types and validate those Aug 9, 2021
@Andre601
Copy link
Contributor

export interface Labeled {
    issue: Issue;
    pr?:   Issue;
}

This wonders me... Would this make issue required? SInce it lacks the ? which to my basic ts knowledge makes it optional/nullable?

@peaceiris
Copy link
Owner Author

peaceiris commented Aug 11, 2021

That is a simple example generated with yaml-to-typescript. In order to avoid misunderstandings, I have deleted that and added some useful libraries for validation.

@peaceiris peaceiris modified the milestones: v1.11.0, v2.0.0 Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request proposal
Projects
None yet
Development

No branches or pull requests

2 participants