fix(docz-core): node env for production

doczjs · Jun 22, 2018 · 615aa1f · 615aa1f
1 parent 5973969
commit 615aa1f
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/packages/docz-core/src/Bundler.ts b/packages/docz-core/src/Bundler.ts
@@ -20,8 +20,6 @@ export interface BundlerConstructor<Config> {
   build: BuildFn<Config>
 }
 
-const IS_PROD = process.env.NODE_ENV === 'production'
-
 export class Bundler<C = any> {
   private readonly args: Args
   private config: C
@@ -39,7 +37,7 @@ export class Bundler<C = any> {
 
   public getConfig(): C {
     const config = this.mountConfig(this.config)
-    return this.args.modifyBundlerConfig(config, !IS_PROD)
+    return this.args.modifyBundlerConfig(config, !this.isProd())
   }
 
   public async createServer(config: C): Promise<BundlerServer> {
@@ -54,6 +52,10 @@ export class Bundler<C = any> {
     const { plugins } = this.args
     const reduce = Plugin.reduceFromPlugins<C>(plugins)
 
-    return reduce('modifyBundlerConfig', config, !IS_PROD)
+    return reduce('modifyBundlerConfig', config, !this.isProd())
+  }
+
+  private isProd(): boolean {
+    return process.env.NODE_ENV === 'production'
   }
 }
diff --git a/packages/docz-core/src/bundlers/webpack/config.ts b/packages/docz-core/src/bundlers/webpack/config.ts
@@ -92,7 +92,7 @@ export const createConfig = (babelrc: BabelRC) => (
 
   config.merge({
     optimization: {
-      nodeEnv: 'dev',
+      nodeEnv: env,
       namedModules: true,
       noEmitOnErrors: true,
       runtimeChunk: true,
@@ -101,6 +101,7 @@ export const createConfig = (babelrc: BabelRC) => (
         name: 'vendors',
       },
       ...(isProd && {
+        minimize: true,
         minimizer: [uglify],
       }),
     },

diff --git a/packages/docz-core/src/commands/build.ts b/packages/docz-core/src/commands/build.ts
@@ -8,6 +8,9 @@ import { Entries } from '../Entries'
 import { Config } from './args'
 import { Plugin } from '../Plugin'
 
+process.env.BABEL_ENV = process.env.BABEL_ENV || 'production'
+process.env.NODE_ENV = process.env.NODE_ENV || 'production'
+
 export const build = async (args: Config) => {
   const config = loadConfig(args)
   const bundler = webpack(config, 'production')

diff --git a/packages/docz-core/src/commands/dev.ts b/packages/docz-core/src/commands/dev.ts
@@ -1,5 +1,5 @@
-import logger from 'signale'
 import * as fs from 'fs-extra'
+import logger from 'signale'
 import detectPort from 'detect-port'
 
 import * as paths from '../config/paths'