please rename montex "v2" to "v1rgb" #6
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there @peepeetee!
Hope you are healthy .. I hear you're on lockdown :(
Okay - this is going to be a long explanation - but I'll try to simplify it.
It turns out that Idobao's Montex PCB has changed the board layout for the WS2812 LED array. The board that Lewis sent you was correct at the time - this is the board that was sold via the Drop sale.
That new board -- that Idobao has branded as "V2" -- is not the same. This new board has the KEYMAP the same as your effort/code/board, but the LED-MAP is not (the the WS2812 array is totally different) - rendering your code completely visually not correct for the branded V2 board. (It is still right for the original Montex RGB!)
The difference I can illustrate with the following picture.
So you can imagine the confusion this is causing with the users!
So I was thinking that we should call your code "V1 RGB" ... or folder name "
v1rgb
". For @IDOBAOKB there's no need to change anything ... they can keep all the old branding as "IDOBAO MONTEX PAD RGB VERSION KEYBOARD KIT" for the "v1rgb
", and keep the new "V2" board as ... "V2". This effort is more about how the code lives on QMK.All I need from your side is to adapt the code you have on PR #15865 to this new "
v1rgb
" name. And you can do this by merging this code into the QMK PR.I've done (and tested) all the code with a user (@willi-on-fire) and I've also done the code for the "v2" board (and there is a seperate, working, PR for that too, PR #16897).
I've also already created the VIA
json
files for both the "v1rgb
" and the "v2
" ... github.com/Idobao/the-via.keyboards/tree/vr-add-id27-v2/src/idobao/montex, and I will PR that to VIA once QMK accepts both 15865 and 16897.All the work is done.
But I need your help - since you already have an open PR in QMK we can just amend yours instead of me creating a new one. And then clear the flag on that PR.
Keep safe ;)