Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MediaConnection.on('close') event is not firing when another close the connection. #780

Closed
zedL opened this issue Jan 20, 2021 · 11 comments
Closed

MediaConnection.on('close') event is not firing when another close the connection. #780

zedL opened this issue Jan 20, 2021 · 11 comments
Labels
released on @rc

Comments

@zedL
Copy link

zedL commented Jan 20, 2021

see also this on stackoverflow (not me, but same issue)
https://stackoverflow.com/questions/64651890/peerjs-close-video-call-not-firing-close-event
@newelement
Copy link

Yep, this has been reported a few times. Awaiting a fix myself.

@MikePooh
Copy link

MikePooh commented Feb 9, 2021

The problem is still observing

@zazics
Copy link

zazics commented Feb 24, 2021

Same problem. I found a workaround by also using a DataStream. DataStream 'close' event is fired on both side. So when DataStream is closed by the other side, I also close MediaStream.

@commonskubin
Copy link

Experienced the same case, no remote close event for MediaConnection with version 1.3.1, using peer.js's cloud server.

Not sure it is client side not firing or server is not relaying the message.

@zeridos
Copy link

zeridos commented Mar 16, 2021

Tested yesterday, same issue on 1.3.2. Instead I used DataStream close as workaround to close the call on both side.

@Payetus
Copy link

Payetus commented Mar 22, 2021

Any news about this?

@rayrenz
Copy link

rayrenz commented Apr 16, 2021 •
edited
Loading

Also waiting for this to get fixed. I thought my code was the problem but it looks to be the same issue.

@kevinshen56714
Copy link

Same here.

@marcjulianfleck
Copy link

Is this Bug still not fixed? Still experience this issue!

@yiwong2001
Copy link

Tested yesterday, same issue on 1.3.2. Instead I used DataStream close as workaround to close the call on both side.

what is DataStream?

jonasgloning added a commit that referenced this issue Jun 22, 2023
@jonasgloning
fix(MediaConnection): close event is fired on remote Peer
0836356 
See e3b67a6

Closes #636, Closes #1089, Closes #1032, Closes #832, Closes #780, Closes #653
github-actions bot pushed a commit that referenced this issue Aug 14, 2023
@semantic-release-bot @jonasgloning
chore(release): 1.5.0-rc.1 [skip ci]
d2b845b 
# [1.5.0-rc.1](v1.4.8-rc.1...v1.5.0-rc.1) (2023-08-14)

### Bug Fixes

* **datachannel:** sending order is now preserved correctly ([#1038](#1038)) ([0fb6179](0fb6179)), closes [#746](#746)
* **deps:** update dependency peerjs-js-binarypack to v1.0.2 ([7452e75](7452e75))
* **deps:** update dependency webrtc-adapter to v8.2.2 ([62402fc](62402fc))
* **deps:** update dependency webrtc-adapter to v8.2.3 ([963455e](963455e))
* **MediaConnection:** `close` event is fired on remote Peer ([0836356](0836356)), closes [#636](#636) [#1089](#1089) [#1032](#1032) [#832](#832) [#780](#780) [#653](#653)

### Features

* **DataConnection:** handle close messages and flush option ([6ca38d3](6ca38d3)), closes [#982](#982)
* **MediaChannel:** Add experimental `willCloseOnRemote` event to MediaConnection. ([ed84829](ed84829))
* MsgPack/Cbor serialization ([fcffbf2](fcffbf2))
@github-actions
Copy link

🎉 This issue has been resolved in version 1.5.0-rc.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Sep 3, 2023
@semantic-release-bot @jonasgloning
chore(release): 1.5.0 [skip ci]
59cea73 
# [1.5.0](v1.4.7...v1.5.0) (2023-09-03)

### Bug Fixes

* **datachannel:** sending order is now preserved correctly ([#1038](#1038)) ([0fb6179](0fb6179)), closes [#746](#746)
* **deps:** update dependency @swc/helpers to ^0.4.0 ([a7de8b7](a7de8b7))
* **deps:** update dependency cbor-x to v1.5.4 ([c1f04ec](c1f04ec))
* **deps:** update dependency eventemitter3 to v5 ([caf01c6](caf01c6))
* **deps:** update dependency peerjs-js-binarypack to v1.0.2 ([7452e75](7452e75))
* **deps:** update dependency webrtc-adapter to v8 ([431f00b](431f00b))
* **deps:** update dependency webrtc-adapter to v8.2.2 ([62402fc](62402fc))
* **deps:** update dependency webrtc-adapter to v8.2.3 ([963455e](963455e))
* **MediaConnection:** `close` event is fired on remote Peer ([0836356](0836356)), closes [#636](#636) [#1089](#1089) [#1032](#1032) [#832](#832) [#780](#780) [#653](#653)
* **npm audit:** Updates all dependencies that cause npm audit to issue a warning ([6ef5707](6ef5707))

### Features

* `.type` property on `Error`s emitted from connections ([#1126](#1126)) ([debe7a6](debe7a6))
* `PeerError` from connections ([ad3a0cb](ad3a0cb))
* **DataConnection:** handle close messages and flush option ([6ca38d3](6ca38d3)), closes [#982](#982)
* **MediaChannel:** Add experimental `willCloseOnRemote` event to MediaConnection. ([ed84829](ed84829))
* MsgPack/Cbor serialization ([fcffbf2](fcffbf2))
* MsgPack/Cbor serialization ([#1120](#1120)) ([4367256](4367256)), closes [#611](#611)
@akhil-rana akhil-rana mentioned this issue Sep 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released on @rc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests